This is an archive of the discontinued LLVM Phabricator instance.

Extract parseBindID method
ClosedPublic

Authored by steveire on Aug 25 2018, 9:15 AM.

Diff Detail

Event Timeline

steveire created this revision.Aug 25 2018, 9:15 AM
klimek added inline comments.Aug 27 2018, 1:10 AM
lib/ASTMatchers/Dynamic/Parser.cpp
362

CloseToken seems to not be used afterwards either here or in the follow-up patch?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 4:12 PM
Closed by commit rL341141: Extract parseBindID method (authored by steveire). · Explain Why
This revision was automatically updated to reflect the committed changes.
steveire marked an inline comment as done.Aug 30 2018, 4:22 PM
steveire added inline comments.
lib/ASTMatchers/Dynamic/Parser.cpp
362

Good catch, thanks. Fixed before committing.