steveire (Stephen Kelly)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2013, 6:50 AM (267 w, 4 d)

Recent Activity

Today

steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

I prefer the API from Peter. I think it's a good additional step from where Aaron and I reached in IRC discussion (this patch currently).

Tue, Oct 23, 5:58 AM

Yesterday

steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

This is already not the case with set output diag etc.

Mon, Oct 22, 12:46 PM
steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

This seems confusing to me because I would expect set foo bar to set the value of a variable foo to bar,

Mon, Oct 22, 12:36 PM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Update docs

Mon, Oct 22, 9:04 AM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

New design

Mon, Oct 22, 8:56 AM
steveire updated the diff for D53501: [clang-query] Refactor Output settings to booleans.

Update tests

Mon, Oct 22, 8:44 AM
steveire updated the diff for D53500: Add 'detailed-ast' output as an alias for 'dump'.

Update tests

Mon, Oct 22, 8:33 AM
steveire created D53501: [clang-query] Refactor Output settings to booleans.
Mon, Oct 22, 8:13 AM
steveire updated the diff for D53500: Add 'detailed-ast' output as an alias for 'dump'.

Format

Mon, Oct 22, 8:11 AM
steveire updated the diff for D53498: Re-word command help for clang-query.

Format

Mon, Oct 22, 8:10 AM
steveire created D53500: Add 'detailed-ast' output as an alias for 'dump'.
Mon, Oct 22, 7:57 AM
steveire created D53498: Re-word command help for clang-query.
Mon, Oct 22, 7:49 AM

Sat, Oct 20

steveire retitled D52857: [clang-query] Add non-exclusive output API from Deprecate 'set output foo' API of clang-query to [clang-query] Add non-exclusive output API .
Sat, Oct 20, 4:47 AM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Don't deprecate existing API

Sat, Oct 20, 4:47 AM
steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

Perhaps the best solution is to introduce this new API, but not deprecate the existing 'exclusive' API.

Sat, Oct 20, 2:49 AM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Update test

Sat, Oct 20, 2:40 AM
steveire committed rCTE344840: [clang-query] Add option to print matcher expression.
[clang-query] Add option to print matcher expression
Sat, Oct 20, 2:16 AM
steveire committed rL344840: [clang-query] Add option to print matcher expression.
[clang-query] Add option to print matcher expression
Sat, Oct 20, 2:16 AM
steveire closed D52859: [clang-query] Add option to print matcher expression.
Sat, Oct 20, 2:16 AM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Fix test

Sat, Oct 20, 1:54 AM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Fix tests

Sat, Oct 20, 1:50 AM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Rename dump-output to ast-output.

Sat, Oct 20, 1:46 AM

Thu, Oct 11

steveire accepted D52806: [python] [tests] Support overriding library path via environment.
Thu, Oct 11, 2:33 AM

Wed, Oct 10

steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

I don't see this functionality being so critical that we need to deprecate the existing spelling when there are backwards compatible options available, which is why I'm opposed to this patch going in with the proposed syntax.

Wed, Oct 10, 9:02 AM
steveire added a comment to D52857: [clang-query] Add non-exclusive output API.
you have to find the right place to stick the `set dump-output true` in order to enable it.
Wed, Oct 10, 7:37 AM

Tue, Oct 9

steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

What's more, given that clang-output has no real documentation to speak of, how will users even *know* to update their scripts?

Tue, Oct 9, 2:58 PM
steveire added a comment to D52857: [clang-query] Add non-exclusive output API.
  • The scripts will continue to work at least until set output is removed, which is not going to happen soon.
  • A comma-delimited list of options means that if I have foo, bar, bat enabled and want to add bang, I need to set output foo, bar, bat, bang. Or alternatively if I want to remove bat, I need to write out all the others. I don't think that's suitable.
Tue, Oct 9, 8:01 AM
steveire added a reviewer for D52857: [clang-query] Add non-exclusive output API: sammccall.
Tue, Oct 9, 2:07 AM
steveire edited reviewers for D52859: [clang-query] Add option to print matcher expression, added: sammccall; removed: klimek.
Tue, Oct 9, 2:07 AM
steveire added a reviewer for D52859: [clang-query] Add option to print matcher expression: klimek.
Tue, Oct 9, 1:56 AM
steveire added a reviewer for D52857: [clang-query] Add non-exclusive output API: klimek.
Tue, Oct 9, 1:56 AM
steveire committed rC344026: [ASTMatcher] Add missing imaginaryLiteral.
[ASTMatcher] Add missing imaginaryLiteral
Tue, Oct 9, 1:46 AM
steveire committed rL344026: [ASTMatcher] Add missing imaginaryLiteral.
[ASTMatcher] Add missing imaginaryLiteral
Tue, Oct 9, 1:46 AM
steveire committed rL344023: Remove non-existant typeloc matchers from documentation.
Remove non-existant typeloc matchers from documentation
Tue, Oct 9, 1:26 AM
steveire committed rC344023: Remove non-existant typeloc matchers from documentation.
Remove non-existant typeloc matchers from documentation
Tue, Oct 9, 1:26 AM
steveire committed rC344022: Regenerate AST Matcher docs.
Regenerate AST Matcher docs
Tue, Oct 9, 1:26 AM
steveire committed rL344022: Regenerate AST Matcher docs.
Regenerate AST Matcher docs
Tue, Oct 9, 1:26 AM
steveire committed rL344021: Fix indentation.
Fix indentation
Tue, Oct 9, 1:26 AM
steveire committed rC344021: Fix indentation.
Fix indentation
Tue, Oct 9, 1:25 AM

Mon, Oct 8

steveire abandoned D52820: Update instructions after change in clang buildsystem.
Mon, Oct 8, 11:34 AM
steveire abandoned D52819: Support checking out cte to 'extra' only as backward compatibility.
Mon, Oct 8, 11:34 AM
steveire added a comment to D52857: [clang-query] Add non-exclusive output API.

Can I convince someone to be interested enough in this to approve it?

Mon, Oct 8, 11:32 AM
steveire added reviewers for D52859: [clang-query] Add option to print matcher expression: ilya-biryukov, ioeric.
Mon, Oct 8, 4:26 AM
steveire added reviewers for D52857: [clang-query] Add non-exclusive output API: ioeric, ilya-biryukov.
Mon, Oct 8, 4:26 AM

Thu, Oct 4

steveire committed rC343807: [NestedNameSpecifier] Add missing stream-specific dump methods.
[NestedNameSpecifier] Add missing stream-specific dump methods
Thu, Oct 4, 12:24 PM
steveire committed rL343807: [NestedNameSpecifier] Add missing stream-specific dump methods.
[NestedNameSpecifier] Add missing stream-specific dump methods
Thu, Oct 4, 12:24 PM
steveire closed D52870: [NestedNameSpecifier] Add missing stream-specific dump methods.
Thu, Oct 4, 12:24 PM
steveire updated the diff for D52870: [NestedNameSpecifier] Add missing stream-specific dump methods.

Format

Thu, Oct 4, 11:30 AM
steveire created D52870: [NestedNameSpecifier] Add missing stream-specific dump methods.
Thu, Oct 4, 1:51 AM

Wed, Oct 3

steveire added a reviewer for D52857: [clang-query] Add non-exclusive output API: pcc.
Wed, Oct 3, 7:07 PM
steveire added inline comments to D52857: [clang-query] Add non-exclusive output API.
Wed, Oct 3, 7:07 PM
steveire added a dependency for D52859: [clang-query] Add option to print matcher expression: D52857: [clang-query] Add non-exclusive output API.
Wed, Oct 3, 7:06 PM
steveire added a dependent revision for D52857: [clang-query] Add non-exclusive output API: D52859: [clang-query] Add option to print matcher expression.
Wed, Oct 3, 7:06 PM
steveire created D52859: [clang-query] Add option to print matcher expression.
Wed, Oct 3, 6:53 PM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Commit message

Wed, Oct 3, 6:53 PM
steveire updated the diff for D52857: [clang-query] Add non-exclusive output API.

Format

Wed, Oct 3, 6:42 PM
steveire created D52857: [clang-query] Add non-exclusive output API.
Wed, Oct 3, 6:17 PM
steveire added inline comments to D52843: Update Clang Windows getting started docs.
Wed, Oct 3, 2:51 PM
steveire accepted D52840: Include Python binding tests in CMake rules.

I didn't run it, but CMake-wise this looks fine. (I trust you did)

Wed, Oct 3, 2:04 PM
steveire committed rL343720: Remove stray character from docs.
Remove stray character from docs
Wed, Oct 3, 1:55 PM
steveire committed rL343719: Update documentation for correctness.
Update documentation for correctness
Wed, Oct 3, 1:55 PM
steveire committed rC343720: Remove stray character from docs.
Remove stray character from docs
Wed, Oct 3, 1:55 PM
steveire committed rC343719: Update documentation for correctness.
Update documentation for correctness
Wed, Oct 3, 1:54 PM
steveire committed rL343717: Add matchers missing from dynamic AST registry.
Add matchers missing from dynamic AST registry
Wed, Oct 3, 1:54 PM
steveire committed rL343716: Sort list of matchers.
Sort list of matchers
Wed, Oct 3, 1:54 PM
steveire committed rC343717: Add matchers missing from dynamic AST registry.
Add matchers missing from dynamic AST registry
Wed, Oct 3, 1:54 PM
steveire committed rC343716: Sort list of matchers.
Sort list of matchers
Wed, Oct 3, 1:54 PM
steveire added a comment to D52819: Support checking out cte to 'extra' only as backward compatibility.

Will do!

Wed, Oct 3, 7:58 AM
steveire added a comment to D52820: Update instructions after change in clang buildsystem.

I use separate git repos. This patch is in LLVM.git, and the other is in clang.git.

Wed, Oct 3, 7:55 AM
steveire added inline comments to D52752: [clang-query] Add comment token handling.
Wed, Oct 3, 1:29 AM
steveire committed rL343666: [clang-query] Add comment token handling.
[clang-query] Add comment token handling
Wed, Oct 3, 1:23 AM
steveire committed rCTE343666: [clang-query] Add comment token handling.
[clang-query] Add comment token handling
Wed, Oct 3, 1:23 AM
steveire closed D52752: [clang-query] Add comment token handling.
Wed, Oct 3, 1:23 AM
steveire added a dependency for D52820: Update instructions after change in clang buildsystem: D52819: Support checking out cte to 'extra' only as backward compatibility.
Wed, Oct 3, 1:10 AM
steveire added a dependent revision for D52819: Support checking out cte to 'extra' only as backward compatibility: D52820: Update instructions after change in clang buildsystem.
Wed, Oct 3, 1:10 AM
steveire committed rC343665: Allow comments with '#' in dynamic AST Matchers.
Allow comments with '#' in dynamic AST Matchers
Wed, Oct 3, 12:58 AM
steveire committed rL343665: Allow comments with '#' in dynamic AST Matchers.
Allow comments with '#' in dynamic AST Matchers
Wed, Oct 3, 12:58 AM
steveire closed D52751: Allow comments with '#' in dynamic AST Matchers.
Wed, Oct 3, 12:58 AM
steveire committed rL343664: [clang-query] Add single-letter 'q' alias for 'quit'.
[clang-query] Add single-letter 'q' alias for 'quit'
Wed, Oct 3, 12:54 AM
steveire committed rCTE343664: [clang-query] Add single-letter 'q' alias for 'quit'.
[clang-query] Add single-letter 'q' alias for 'quit'
Wed, Oct 3, 12:54 AM
steveire closed D52746: [clang-query] Add single-letter 'q' alias for 'quit'.
Wed, Oct 3, 12:54 AM
steveire created D52820: Update instructions after change in clang buildsystem.
Wed, Oct 3, 12:51 AM
steveire created D52819: Support checking out cte to 'extra' only as backward compatibility.
Wed, Oct 3, 12:51 AM

Tue, Oct 2

steveire added inline comments to D52773: clang-cl: Add /showFilenames option (PR31957).
Tue, Oct 2, 11:32 AM
steveire added inline comments to D52751: Allow comments with '#' in dynamic AST Matchers.
Tue, Oct 2, 11:16 AM
steveire updated the diff for D52751: Allow comments with '#' in dynamic AST Matchers.

use cxx_range_for

Tue, Oct 2, 11:15 AM
steveire added a comment to D52746: [clang-query] Add single-letter 'q' alias for 'quit'.

Please update HelpQuery::run() to print out the new mnemonic (it's the *only* form of public documentation we have for clang-query currently).

Tue, Oct 2, 11:09 AM
steveire updated the diff for D52746: [clang-query] Add single-letter 'q' alias for 'quit'.

Add docs

Tue, Oct 2, 11:08 AM
steveire added a comment to D52746: [clang-query] Add single-letter 'q' alias for 'quit'.

@Szelethus You can approve it and then you will get the feature :).

Tue, Oct 2, 6:43 AM
steveire added inline comments to D52773: clang-cl: Add /showFilenames option (PR31957).
Tue, Oct 2, 6:37 AM
steveire added inline comments to D52773: clang-cl: Add /showFilenames option (PR31957).
Tue, Oct 2, 5:38 AM

Mon, Oct 1

steveire updated the diff for D52752: [clang-query] Add comment token handling.

Remove garbage

Mon, Oct 1, 3:53 PM
steveire added a dependency for D52752: [clang-query] Add comment token handling: D52751: Allow comments with '#' in dynamic AST Matchers.
Mon, Oct 1, 3:52 PM
steveire added a dependent revision for D52751: Allow comments with '#' in dynamic AST Matchers: D52752: [clang-query] Add comment token handling.
Mon, Oct 1, 3:52 PM
steveire created D52752: [clang-query] Add comment token handling.
Mon, Oct 1, 3:49 PM
steveire created D52751: Allow comments with '#' in dynamic AST Matchers.
Mon, Oct 1, 3:46 PM
steveire edited reviewers for D52746: [clang-query] Add single-letter 'q' alias for 'quit', added: pcc; removed: alexfh.
Mon, Oct 1, 2:49 PM
steveire committed rL343538: Sort expected test output after previous commit.
Sort expected test output after previous commit
Mon, Oct 1, 2:12 PM
steveire committed rCTE343538: Sort expected test output after previous commit.
Sort expected test output after previous commit
Mon, Oct 1, 2:12 PM
steveire updated the diff for D52746: [clang-query] Add single-letter 'q' alias for 'quit'.

Add test

Mon, Oct 1, 1:57 PM