Page MenuHomePhabricator

steveire (Stephen Kelly)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2013, 6:50 AM (275 w, 1 d)

Recent Activity

Wed, Dec 12

steveire added a comment to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.

Can you say where else it is common in LLVM? I'm curious. Maybe those places could be changed too.

Wed, Dec 12, 6:25 AM · Restricted Project
steveire added a comment to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.

FYI, CMake target property INTERFACE_SOURCES is designed to make this easy.

Wed, Dec 12, 3:18 AM · Restricted Project

Tue, Dec 11

steveire updated the diff for D55337: NFC: Move dumpDeclRef to NodeDumper.

Rebase

Tue, Dec 11, 1:14 AM

Mon, Dec 10

steveire added inline comments to D55488: Add utility for dumping a label with child nodes.
Mon, Dec 10, 1:51 PM
steveire updated the diff for D55488: Add utility for dumping a label with child nodes.

Clean up API a bit.

Mon, Dec 10, 1:50 PM
steveire added a reviewer for D55488: Add utility for dumping a label with child nodes: rsmith.
Mon, Dec 10, 1:45 PM
steveire updated the summary of D55488: Add utility for dumping a label with child nodes.
Mon, Dec 10, 1:44 PM
steveire updated the diff for D55488: Add utility for dumping a label with child nodes.

Update with new approach

Mon, Dec 10, 1:43 PM
steveire committed rC348799: Revert "Change InitListExpr dump to label and pointer".
Revert "Change InitListExpr dump to label and pointer"
Mon, Dec 10, 1:23 PM
steveire committed rL348799: Revert "Change InitListExpr dump to label and pointer".
Revert "Change InitListExpr dump to label and pointer"
Mon, Dec 10, 1:23 PM
steveire committed rC348798: Fix nits.
Fix nits
Mon, Dec 10, 1:07 PM
steveire committed rL348798: Fix nits.
Fix nits
Mon, Dec 10, 1:07 PM
steveire committed rC348797: Re-order content of template parameter dumps.
Re-order content of template parameter dumps
Mon, Dec 10, 1:06 PM
steveire committed rL348797: Re-order content of template parameter dumps.
Re-order content of template parameter dumps
Mon, Dec 10, 1:06 PM
steveire closed D55393: Re-order content of template parameter dumps.
Mon, Dec 10, 1:06 PM
steveire committed rC348795: Re-order content in OMPDeclareReductionDecl dump.
Re-order content in OMPDeclareReductionDecl dump
Mon, Dec 10, 12:57 PM
steveire committed rC348794: Change InitListExpr dump to label and pointer.
Change InitListExpr dump to label and pointer
Mon, Dec 10, 12:56 PM
steveire committed rL348795: Re-order content in OMPDeclareReductionDecl dump.
Re-order content in OMPDeclareReductionDecl dump
Mon, Dec 10, 12:56 PM
steveire committed rL348794: Change InitListExpr dump to label and pointer.
Change InitListExpr dump to label and pointer
Mon, Dec 10, 12:56 PM
steveire closed D55395: Re-order content in OMPDeclareReductionDecl dump.
Mon, Dec 10, 12:56 PM
steveire closed D55495: Change InitListExpr dump to label and pointer.
Mon, Dec 10, 12:56 PM

Sun, Dec 9

steveire added inline comments to D55492: Implement Attr dumping in terms of visitors.
Sun, Dec 9, 10:46 AM
steveire updated the diff for D55395: Re-order content in OMPDeclareReductionDecl dump.

Use pointer approach

Sun, Dec 9, 7:34 AM
steveire added a comment to D55495: Change InitListExpr dump to label and pointer.

My real preference is just to remove the array filler child node entirely and not add a pointer here. However, I'm just looking for something that has a chance of passing review.

Sun, Dec 9, 7:21 AM
steveire added a comment to D55395: Re-order content in OMPDeclareReductionDecl dump.

I would prefer *not* to do what is in this patch. I'm just trying to find a way forward. I like the approach of using the existing precedent of printing the pointers as a compromise between removing such labels entirely and not having things like that at all. I did that for InitListExpr here: https://reviews.llvm.org/D55495

Sun, Dec 9, 7:20 AM
steveire created D55495: Change InitListExpr dump to label and pointer.
Sun, Dec 9, 7:18 AM
steveire added a comment to D55395: Re-order content in OMPDeclareReductionDecl dump.

This is a novel approach that's not used anywhere else in the AST dumper

Sun, Dec 9, 7:10 AM
steveire updated the diff for D55491: Implement TemplateArgument dumping in terms of Visitor.

Update

Sun, Dec 9, 6:41 AM
steveire updated the diff for D55395: Re-order content in OMPDeclareReductionDecl dump.

Use child node labels

Sun, Dec 9, 6:08 AM
steveire updated the diff for D55488: Add utility for dumping a label with child nodes.

Use std::string

Sun, Dec 9, 6:08 AM
steveire created D55492: Implement Attr dumping in terms of visitors.
Sun, Dec 9, 5:50 AM
steveire created D55491: Implement TemplateArgument dumping in terms of Visitor.
Sun, Dec 9, 5:50 AM
steveire created D55490: Add dumpMethodDeclOverrides to NodeDumper.
Sun, Dec 9, 5:45 AM
steveire created D55489: Implement dumpFunctionDeclParameters in NodeDumper.
Sun, Dec 9, 5:44 AM
steveire committed rL348720: NFC: Rename TemplateDecl dump utilities.
NFC: Rename TemplateDecl dump utilities
Sun, Dec 9, 5:37 AM
steveire committed rC348720: NFC: Rename TemplateDecl dump utilities.
NFC: Rename TemplateDecl dump utilities
Sun, Dec 9, 5:37 AM
steveire committed rC348719: NFC: Move dump of individual comment nodes to NodeDumper.
NFC: Move dump of individual comment nodes to NodeDumper
Sun, Dec 9, 5:33 AM
steveire committed rL348719: NFC: Move dump of individual comment nodes to NodeDumper.
NFC: Move dump of individual comment nodes to NodeDumper
Sun, Dec 9, 5:33 AM
steveire closed D55190: Move dump of individual comment nodes to NodeDumper.
Sun, Dec 9, 5:33 AM
steveire created D55488: Add utility for dumping a label with child nodes.
Sun, Dec 9, 5:29 AM
steveire committed rL348718: Revert "Introduce optional labels to dumpStmt".
Revert "Introduce optional labels to dumpStmt"
Sun, Dec 9, 5:29 AM
steveire committed rC348718: Revert "Introduce optional labels to dumpStmt".
Revert "Introduce optional labels to dumpStmt"
Sun, Dec 9, 5:28 AM
steveire committed rC348717: Introduce optional labels to dumpStmt.
Introduce optional labels to dumpStmt
Sun, Dec 9, 5:26 AM
steveire committed rL348717: Introduce optional labels to dumpStmt.
Introduce optional labels to dumpStmt
Sun, Dec 9, 5:26 AM
steveire committed rC348716: Inline hasNodes into only caller.
Inline hasNodes into only caller
Sun, Dec 9, 5:23 AM
steveire committed rL348716: Inline hasNodes into only caller.
Inline hasNodes into only caller
Sun, Dec 9, 5:23 AM
steveire committed rC348715: Inline dumpFullComment into callers.
Inline dumpFullComment into callers
Sun, Dec 9, 5:22 AM
steveire committed rL348715: Inline dumpFullComment into callers.
Inline dumpFullComment into callers
Sun, Dec 9, 5:22 AM
steveire updated the diff for D55393: Re-order content of template parameter dumps.

New approach

Sun, Dec 9, 5:18 AM
steveire committed rC348714: Re-order content from InitListExpr.
Re-order content from InitListExpr
Sun, Dec 9, 5:18 AM
steveire committed rL348714: Re-order content from InitListExpr.
Re-order content from InitListExpr
Sun, Dec 9, 5:18 AM
steveire closed D55398: Re-order content from InitListExpr.
Sun, Dec 9, 5:18 AM
steveire committed rC348713: Fix InitListExpr test.
Fix InitListExpr test
Sun, Dec 9, 5:18 AM
steveire committed rL348713: Fix InitListExpr test.
Fix InitListExpr test
Sun, Dec 9, 5:18 AM

Fri, Dec 7

steveire added a comment to D55410: [clang-tidy] check for flagging using declarations in headers.

Would it make sense to make this a generic non-abseil check?

Fri, Dec 7, 6:22 AM · Restricted Project
steveire added inline comments to D55393: Re-order content of template parameter dumps.
Fri, Dec 7, 5:02 AM

Thu, Dec 6

steveire created D55398: Re-order content from InitListExpr.
Thu, Dec 6, 4:11 PM
steveire committed rL348553: Add test for InitListExpr.
Add test for InitListExpr
Thu, Dec 6, 4:11 PM
steveire committed rC348553: Add test for InitListExpr.
Add test for InitListExpr
Thu, Dec 6, 4:11 PM
steveire committed rL348546: NFC: Move VisitExpr code to dumpStmt.
NFC: Move VisitExpr code to dumpStmt
Thu, Dec 6, 3:37 PM
steveire committed rL348545: NFC: Move VisitStmt code to dumpStmt.
NFC: Move VisitStmt code to dumpStmt
Thu, Dec 6, 3:37 PM
steveire committed rC348546: NFC: Move VisitExpr code to dumpStmt.
NFC: Move VisitExpr code to dumpStmt
Thu, Dec 6, 3:37 PM
steveire closed D55339: NFC: Move VisitExpr code to dumpStmt.
Thu, Dec 6, 3:37 PM
steveire committed rC348545: NFC: Move VisitStmt code to dumpStmt.
NFC: Move VisitStmt code to dumpStmt
Thu, Dec 6, 3:37 PM
steveire closed D55338: NFC: Move VisitStmt code to dumpStmt.
Thu, Dec 6, 3:37 PM
steveire created D55395: Re-order content in OMPDeclareReductionDecl dump.
Thu, Dec 6, 3:32 PM
steveire created D55394: Re-order type param children of ObjC nodes.
Thu, Dec 6, 3:31 PM
steveire created D55393: Re-order content of template parameter dumps.
Thu, Dec 6, 3:31 PM
steveire updated the diff for D55083: Re-arrange content in FunctionDecl dump.

Adjust tests

Thu, Dec 6, 3:31 PM
steveire committed rC348543: Add more expected content to match in test.
Add more expected content to match in test
Thu, Dec 6, 3:26 PM
steveire committed rL348543: Add more expected content to match in test.
Add more expected content to match in test
Thu, Dec 6, 3:26 PM
steveire committed rC348541: Use relative line offsets in test.
Use relative line offsets in test
Thu, Dec 6, 2:54 PM
steveire committed rL348541: Use relative line offsets in test.
Use relative line offsets in test
Thu, Dec 6, 2:54 PM
steveire added inline comments to D55337: NFC: Move dumpDeclRef to NodeDumper.
Thu, Dec 6, 9:50 AM
steveire committed rL348471: Add test for ObjC generics.
Add test for ObjC generics
Thu, Dec 6, 1:27 AM
steveire committed rC348471: Add test for ObjC generics.
Add test for ObjC generics
Thu, Dec 6, 1:27 AM
steveire committed rC348470: Extend OMP test.
Extend OMP test
Thu, Dec 6, 1:27 AM
steveire committed rL348470: Extend OMP test.
Extend OMP test
Thu, Dec 6, 1:27 AM
steveire committed rC348469: Make test resistant to line numbers changing.
Make test resistant to line numbers changing
Thu, Dec 6, 1:25 AM
steveire committed rL348469: Make test resistant to line numbers changing.
Make test resistant to line numbers changing
Thu, Dec 6, 1:25 AM

Wed, Dec 5

steveire committed rL348412: NFC: Extract TextNodeDumper class.
NFC: Extract TextNodeDumper class
Wed, Dec 5, 1:15 PM
steveire committed rC348412: NFC: Extract TextNodeDumper class.
NFC: Extract TextNodeDumper class
Wed, Dec 5, 1:15 PM
steveire closed D55189: Extract TextNodeDumper class.
Wed, Dec 5, 1:15 PM
steveire created D55340: NFC: Move dump of individual Stmts to TextNodeDumper.
Wed, Dec 5, 1:09 PM
steveire created D55339: NFC: Move VisitExpr code to dumpStmt.
Wed, Dec 5, 1:08 PM
steveire created D55338: NFC: Move VisitStmt code to dumpStmt.
Wed, Dec 5, 1:08 PM
steveire created D55337: NFC: Move dumpDeclRef to NodeDumper.
Wed, Dec 5, 1:07 PM
steveire committed rC348410: NFC: Extract TextTreeStructure class.
NFC: Extract TextTreeStructure class
Wed, Dec 5, 12:57 PM
steveire committed rL348410: NFC: Extract TextTreeStructure class.
NFC: Extract TextTreeStructure class
Wed, Dec 5, 12:57 PM
steveire closed D55188: Extract TextChildDumper class.
Wed, Dec 5, 12:57 PM
steveire committed rC348409: NFC: Inline handling of DependentSizedArrayType.
NFC: Inline handling of DependentSizedArrayType
Wed, Dec 5, 12:37 PM
steveire committed rL348409: NFC: Inline handling of DependentSizedArrayType.
NFC: Inline handling of DependentSizedArrayType
Wed, Dec 5, 12:37 PM
steveire closed D55257: Inline handling of DependentSizedArrayType.
Wed, Dec 5, 12:37 PM
steveire committed rL348408: Add dump tests for inherited default template parameters.
Add dump tests for inherited default template parameters
Wed, Dec 5, 12:24 PM
steveire committed rC348408: Add dump tests for inherited default template parameters.
Add dump tests for inherited default template parameters
Wed, Dec 5, 12:24 PM
steveire added inline comments to D55189: Extract TextNodeDumper class.
Wed, Dec 5, 12:23 PM
steveire added inline comments to D55321: Do not check for parameters shadowing fields in function declarations.
Wed, Dec 5, 7:52 AM

Tue, Dec 4

steveire added a comment to D55257: Inline handling of DependentSizedArrayType.

It is necessary to perform all printing before any traversal to child nodes.

This piqued my interest -- is VisitFunctionDecl() then incorrect because it streams output, then dumps parameter children, then dumps more output, then dumps override children? Or do you mean "don't interleave VisitFoo() calls with streaming output"?

Can you relate your question to https://reviews.llvm.org/D55083 ?

Ah, I was looking at code before having fetched those changes, so perhaps my example is poor. Mostly, I'm wondering what you meant by "traversal to child nodes" -- do you mean:

  1. it's bad to output to the stream, then dumpChild(), then output to the stream again
  2. it's bad to output to the stream, then VisitFoo(), then output to the stream again
  3. both #1 and #2
  4. neither #1 nor #2

    (as in: when I'm doing a code review a few months from now, what should I be watching out for in this scenario?)
Tue, Dec 4, 11:24 AM
steveire added a comment to D55257: Inline handling of DependentSizedArrayType.

It is necessary to perform all printing before any traversal to child nodes.

This piqued my interest -- is VisitFunctionDecl() then incorrect because it streams output, then dumps parameter children, then dumps more output, then dumps override children? Or do you mean "don't interleave VisitFoo() calls with streaming output"?

Tue, Dec 4, 5:47 AM
steveire added a reviewer for D55257: Inline handling of DependentSizedArrayType: aaron.ballman.
Tue, Dec 4, 2:01 AM