Page MenuHomePhabricator

steveire (Stephen Kelly)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2013, 6:50 AM (293 w, 4 d)

Recent Activity

Feb 5 2019

steveire accepted D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers..

Sorry, this fell off my radar :). LGTM too.

Feb 5 2019, 1:12 PM · Restricted Project, Restricted Project

Feb 3 2019

steveire accepted D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit.
Feb 3 2019, 9:51 AM · Restricted Project
steveire added a comment to D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit.

I have no objection to this, but I wonder whether all state accessible from all nodes should be part of the AST dump. Where do you think the line is? Is there anything else missing currently from other nodes?

Feb 3 2019, 9:50 AM · Restricted Project
steveire committed rC352989: [AST] Extract ASTNodeTraverser class from ASTDumper.
[AST] Extract ASTNodeTraverser class from ASTDumper
Feb 3 2019, 6:08 AM
steveire committed rL352989: [AST] Extract ASTNodeTraverser class from ASTDumper.
[AST] Extract ASTNodeTraverser class from ASTDumper
Feb 3 2019, 6:08 AM
steveire closed D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.
Feb 3 2019, 6:08 AM · Restricted Project, Restricted Project

Feb 1 2019

steveire added inline comments to D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.
Feb 1 2019, 11:33 AM · Restricted Project, Restricted Project

Jan 31 2019

steveire updated the diff for D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.

Update

Jan 31 2019, 2:41 PM · Restricted Project, Restricted Project
steveire added inline comments to D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.
Jan 31 2019, 2:40 PM · Restricted Project, Restricted Project
steveire committed rC352804: [ASTDump] Make template specialization tests more exact.
[ASTDump] Make template specialization tests more exact
Jan 31 2019, 2:28 PM
steveire committed rL352804: [ASTDump] Make template specialization tests more exact.
[ASTDump] Make template specialization tests more exact
Jan 31 2019, 2:28 PM
steveire closed D57502: [ASTDump] Make template specialization tests more exact.
Jan 31 2019, 2:28 PM
steveire created D57502: [ASTDump] Make template specialization tests more exact.
Jan 31 2019, 2:17 AM

Jan 30 2019

steveire added inline comments to D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.
Jan 30 2019, 1:57 PM · Restricted Project, Restricted Project
steveire updated the diff for D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.

Fix comment

Jan 30 2019, 1:51 PM · Restricted Project, Restricted Project
steveire created D57472: [AST] Extract ASTDumpTraverser class from ASTDumper.
Jan 30 2019, 1:49 PM · Restricted Project, Restricted Project
steveire committed rL352676: [ASTDump] Inline traverse methods into class.
[ASTDump] Inline traverse methods into class
Jan 30 2019, 1:49 PM
steveire committed rC352676: [ASTDump] Inline traverse methods into class.
[ASTDump] Inline traverse methods into class
Jan 30 2019, 1:49 PM
steveire committed rL352663: [ASTDump] Make method definition order matches declaration order.
[ASTDump] Make method definition order matches declaration order
Jan 30 2019, 12:07 PM
steveire committed rC352663: [ASTDump] Make method definition order matches declaration order.
[ASTDump] Make method definition order matches declaration order
Jan 30 2019, 12:07 PM
steveire committed rC352661: [ASTDump] Re-arrange method declarations to group Visit together.
[ASTDump] Re-arrange method declarations to group Visit together
Jan 30 2019, 12:03 PM
steveire committed rL352661: [ASTDump] Re-arrange method declarations to group Visit together.
[ASTDump] Re-arrange method declarations to group Visit together
Jan 30 2019, 12:03 PM
steveire committed rC352657: [ASTDump] Rename methods which are conceptually Visits.
[ASTDump] Rename methods which are conceptually Visits
Jan 30 2019, 11:51 AM
steveire committed rL352657: [ASTDump] Rename methods which are conceptually Visits.
[ASTDump] Rename methods which are conceptually Visits
Jan 30 2019, 11:51 AM
steveire committed rC352656: [ASTDump] NFC: Inline vestigial methods.
[ASTDump] NFC: Inline vestigial methods
Jan 30 2019, 11:41 AM
steveire committed rL352656: [ASTDump] NFC: Inline vestigial methods.
[ASTDump] NFC: Inline vestigial methods
Jan 30 2019, 11:41 AM
steveire added a comment to D57419: [ASTDump] Move Decl node dumping to TextNodeDumper.

Needs rebasing for rL352631.

Jan 30 2019, 11:33 AM
steveire committed rC352655: [ASTDump] Move Decl node dumping to TextNodeDumper.
[ASTDump] Move Decl node dumping to TextNodeDumper
Jan 30 2019, 11:32 AM
steveire committed rL352655: [ASTDump] Move Decl node dumping to TextNodeDumper.
[ASTDump] Move Decl node dumping to TextNodeDumper
Jan 30 2019, 11:32 AM
steveire closed D57419: [ASTDump] Move Decl node dumping to TextNodeDumper.
Jan 30 2019, 11:32 AM

Jan 29 2019

steveire abandoned D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association.

An alternative was written and committed.

Jan 29 2019, 3:24 PM
steveire created D57419: [ASTDump] Move Decl node dumping to TextNodeDumper.
Jan 29 2019, 3:14 PM
steveire committed rL352558: NFC: Move GenericSelectionExpr dump to NodeDumper.
NFC: Move GenericSelectionExpr dump to NodeDumper
Jan 29 2019, 2:58 PM
steveire committed rC352558: NFC: Move GenericSelectionExpr dump to NodeDumper.
NFC: Move GenericSelectionExpr dump to NodeDumper
Jan 29 2019, 2:58 PM
steveire closed D56961: NFC: Move GenericSelectionExpr dump to NodeDumper.
Jan 29 2019, 2:58 PM
steveire committed rL352552: NFC: Implement GenericSelectionExpr::Association dump with Visitor.
NFC: Implement GenericSelectionExpr::Association dump with Visitor
Jan 29 2019, 2:23 PM
steveire committed rC352552: NFC: Implement GenericSelectionExpr::Association dump with Visitor.
NFC: Implement GenericSelectionExpr::Association dump with Visitor
Jan 29 2019, 2:23 PM
steveire closed D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor.
Jan 29 2019, 2:22 PM
steveire added a comment to D57106: [AST] Introduce GenericSelectionExpr::Association.

This was subsequently reverted. Is there a status update? Rebasing and committing D56959 would unblock traverser work and would allow this to progress separately in parallel.

Jan 29 2019, 2:00 AM · Restricted Project

Jan 26 2019

steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

I was just working on this this afternoon to show you the difference when it is split up. Looks like you committed this meanwhile.

Jan 26 2019, 8:09 AM · Restricted Project

Jan 25 2019

steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

Cleanup the patch by factoring out the NFC changes.

@steveire This should be much clearer now.

Jan 25 2019, 6:12 AM · Restricted Project

Jan 24 2019

steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

I highly recommend this 9 minute video if this is new to you or you haven't seen it before: https://youtu.be/qpdYRPL3SVE?t=103

I would like to add an additional meta-comment here, but please don't take this in a bad way. I am wondering
about the usefulness and the productivity of the "if this is new to you" in what I am assuming is a discussion
between professionals. I will be happy to address any further technical comments regarding the code itself.

Jan 24 2019, 2:55 PM · Restricted Project
steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

There's definitely a better possible ordering in two commits:

  1. Introduce ::Create and port to it
  2. Use trailing objects, taking advantage of the fact that ::Create exists.

    That would make it clear in the future to other people because both commits would be cleaner, both commit messages would say what the commit does, and neither commit would have the noise of the other change.

    Not splitting this commit makes it less reviewable to people who are not around today.
Jan 24 2019, 1:18 PM · Restricted Project
steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

There's definitely a better possible ordering in two commits:

Jan 24 2019, 1:11 PM · Restricted Project
steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

Thanks, but I don't see the factored out changes in the repo. Are you going to commit those first?

Jan 24 2019, 11:54 AM · Restricted Project
steveire added inline comments to D57104: [AST] Pack GenericSelectionExpr.
Jan 24 2019, 7:34 AM · Restricted Project

Jan 23 2019

steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

Splitting the introduction of and porting to Create would significantly reduce the number of files touched by the 'real' change in this commit, and therefore reduce noise in the commit (following the idea of "do one thing per commit" to make the code reviewable in the future).

However, if you're opposed to that, it's not a hard requirement.

To be honest I don't really see the point.

Jan 23 2019, 12:37 PM · Restricted Project
steveire added inline comments to D57106: [AST] Introduce GenericSelectionExpr::Association.
Jan 23 2019, 10:27 AM · Restricted Project
steveire added a comment to D57106: [AST] Introduce GenericSelectionExpr::Association.

Just in case you didn't know, you could have (and still can!) just update https://reviews.llvm.org/D57098 instead of creating a new PR.

Jan 23 2019, 10:26 AM · Restricted Project
steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

I haven't done a full review as it's not obvious what parts of the diff relate to which separate change. Perhaps Aaron will review and approve though for you anyway.

Jan 23 2019, 10:24 AM · Restricted Project
steveire added a comment to D57104: [AST] Pack GenericSelectionExpr.

Splitting the introduction of and porting to Create would significantly reduce the number of files touched by the 'real' change in this commit, and therefore reduce noise in the commit (following the idea of "do one thing per commit" to make the code reviewable in the future).

Jan 23 2019, 10:22 AM · Restricted Project
steveire added a comment to D57098: [WIP][AST] NFC: Introduce new class GenericSelectionExpr::Association.

Thanks for doing this!

It would be easier to review (now and in the future!) if you split it into at least 3 commits

  • Refactor use trailing objects without introducing the Association class
  • The change to use bitfields and Stmt.h
  • Introduce new class GenericSelectionExpr::Association

    Thanks,

    Stephen

Is it okay if I split it into:

  1. llvm::TrailingObjects + bit-fields of Stmt
  2. Introduce GenericSelectionExpr::Association

    since using llvm::TrailingObjects and using the bit-fields of Stmt are closely related and come under the title "[AST] Pack GenericSelectionExpr".
Jan 23 2019, 8:14 AM · Restricted Project
steveire added a comment to D57098: [WIP][AST] NFC: Introduce new class GenericSelectionExpr::Association.

Thanks for doing this!

Jan 23 2019, 7:31 AM · Restricted Project

Jan 21 2019

steveire committed rLLDB351760: Fix test after AST dump output change.
Fix test after AST dump output change
Jan 21 2019, 11:18 AM
steveire committed rL351760: Fix test after AST dump output change.
Fix test after AST dump output change
Jan 21 2019, 11:18 AM
steveire added inline comments to D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association.
Jan 21 2019, 7:38 AM
steveire added inline comments to D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association.
Jan 21 2019, 5:51 AM
steveire committed rL351733: Fix test after AST dump output change.
Fix test after AST dump output change
Jan 21 2019, 1:54 AM
steveire committed rLLDB351733: Fix test after AST dump output change.
Fix test after AST dump output change
Jan 21 2019, 1:54 AM

Jan 20 2019

steveire committed rLLDB351707: Fix test after AST dump output change.
Fix test after AST dump output change
Jan 20 2019, 3:47 PM
steveire committed rL351707: Fix test after AST dump output change.
Fix test after AST dump output change
Jan 20 2019, 3:47 PM
steveire committed rLLDB351703: Try to port tests to AST dump changes.
Try to port tests to AST dump changes
Jan 20 2019, 2:57 PM
steveire committed rL351703: Try to port tests to AST dump changes.
Try to port tests to AST dump changes
Jan 20 2019, 2:56 PM

Jan 19 2019

steveire created D56961: NFC: Move GenericSelectionExpr dump to NodeDumper.
Jan 19 2019, 4:12 AM
steveire created D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor.
Jan 19 2019, 4:12 AM
steveire created D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association.
Jan 19 2019, 4:11 AM
steveire committed rL351647: [ASTDump] NFC: Convert iterative loops to cxx_range_for.
[ASTDump] NFC: Convert iterative loops to cxx_range_for
Jan 19 2019, 2:02 AM
steveire committed rC351647: [ASTDump] NFC: Convert iterative loops to cxx_range_for.
[ASTDump] NFC: Convert iterative loops to cxx_range_for
Jan 19 2019, 2:02 AM
steveire committed rC351646: [ASTDump] NFC: Use `const auto` in cxx_range_for loops.
[ASTDump] NFC: Use `const auto` in cxx_range_for loops
Jan 19 2019, 2:02 AM
steveire committed rL351646: [ASTDump] NFC: Use `const auto` in cxx_range_for loops.
[ASTDump] NFC: Use `const auto` in cxx_range_for loops
Jan 19 2019, 2:01 AM
steveire committed rL351637: Move decl context dumping to TextNodeDumper.
Move decl context dumping to TextNodeDumper
Jan 19 2019, 1:15 AM
steveire committed rC351637: Move decl context dumping to TextNodeDumper.
Move decl context dumping to TextNodeDumper
Jan 19 2019, 1:15 AM
steveire closed D56829: Move decl context dumping to TextNodeDumper.
Jan 19 2019, 1:15 AM

Jan 18 2019

steveire updated the diff for D56829: Move decl context dumping to TextNodeDumper.

Update

Jan 18 2019, 2:23 PM
steveire committed rL351606: [ASTDump] Add test for current AST dump behavior.
[ASTDump] Add test for current AST dump behavior
Jan 18 2019, 2:19 PM
steveire committed rC351606: [ASTDump] Add test for current AST dump behavior.
[ASTDump] Add test for current AST dump behavior
Jan 18 2019, 2:19 PM
steveire committed rC351605: [ASTDump] NFC: Move variable into if() statement.
[ASTDump] NFC: Move variable into if() statement
Jan 18 2019, 2:19 PM
steveire committed rC351604: [ASTDump] NFC: Remove redundant condition.
[ASTDump] NFC: Remove redundant condition
Jan 18 2019, 2:19 PM
steveire committed rL351605: [ASTDump] NFC: Move variable into if() statement.
[ASTDump] NFC: Move variable into if() statement
Jan 18 2019, 2:19 PM
steveire committed rL351604: [ASTDump] NFC: Remove redundant condition.
[ASTDump] NFC: Remove redundant condition
Jan 18 2019, 2:19 PM
steveire committed rL351603: [ASTDump] NFC: Remove non-needed braces.
[ASTDump] NFC: Remove non-needed braces
Jan 18 2019, 2:19 PM
steveire committed rC351603: [ASTDump] NFC: Remove non-needed braces.
[ASTDump] NFC: Remove non-needed braces
Jan 18 2019, 2:18 PM
steveire committed rC351601: [ASTDump] Mark null params with a tag rather than a child node.
[ASTDump] Mark null params with a tag rather than a child node
Jan 18 2019, 2:05 PM
steveire committed rL351601: [ASTDump] Mark null params with a tag rather than a child node.
[ASTDump] Mark null params with a tag rather than a child node
Jan 18 2019, 2:05 PM
steveire closed D56753: [ASTDump] Mark null params with a tag rather than a child node.
Jan 18 2019, 2:05 PM
steveire committed rC351600: [ASTDump] Mark BlockDecls which capture this with a tag.
[ASTDump] Mark BlockDecls which capture this with a tag
Jan 18 2019, 1:59 PM
steveire committed rL351600: [ASTDump] Mark BlockDecls which capture this with a tag.
[ASTDump] Mark BlockDecls which capture this with a tag
Jan 18 2019, 1:59 PM
steveire closed D56752: [ASTDump] Mark BlockDecls which capture this with a tag.
Jan 18 2019, 1:59 PM
steveire committed rL351597: [ASTDump] Mark variadic declarations with a tag instead of child node.
[ASTDump] Mark variadic declarations with a tag instead of child node
Jan 18 2019, 1:43 PM
steveire added a comment to D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers..

Thanks, do you need someone to commit this for you?

Jan 18 2019, 1:42 PM · Restricted Project, Restricted Project
steveire committed rC351597: [ASTDump] Mark variadic declarations with a tag instead of child node.
[ASTDump] Mark variadic declarations with a tag instead of child node
Jan 18 2019, 1:42 PM
steveire closed D56751: [ASTDump] Mark variadic declarations with a tag instead of child node.
Jan 18 2019, 1:42 PM
steveire updated the diff for D56829: Move decl context dumping to TextNodeDumper.

Update

Jan 18 2019, 2:11 AM
steveire updated the diff for D56829: Move decl context dumping to TextNodeDumper.

Update

Jan 18 2019, 1:59 AM
steveire updated the diff for D56753: [ASTDump] Mark null params with a tag rather than a child node.

Update

Jan 18 2019, 1:50 AM
steveire updated the diff for D56752: [ASTDump] Mark BlockDecls which capture this with a tag.

Rebase

Jan 18 2019, 1:43 AM

Jan 17 2019

steveire added inline comments to D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers..
Jan 17 2019, 6:49 AM · Restricted Project
steveire added a comment to D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers..

Should this one now be closed? The 'Add Action...' dropdown has an action for that.

Jan 17 2019, 6:32 AM
steveire added inline comments to D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers..
Jan 17 2019, 6:29 AM · Restricted Project, Restricted Project
steveire added a comment to D56829: Move decl context dumping to TextNodeDumper.

I don't know what C++ code results in the undeserialized declarations output. Can you suggest some?

Jan 17 2019, 6:23 AM