Page MenuHomePhabricator

steveire (Stephen Kelly)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2013, 6:50 AM (384 w, 5 d)

Recent Activity

Today

steveire updated the diff for D94865: [ASTMatchers] Add callOrConstruct matcher.

Update

Tue, Jan 19, 3:10 PM · Restricted Project
steveire added inline comments to D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds.
Tue, Jan 19, 3:03 PM · Restricted Project
steveire updated the diff for D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds.

Update

Tue, Jan 19, 3:01 PM · Restricted Project
steveire updated the diff for D94878: Make it possible to store a ASTNodeKind in VariantValue.

Update

Tue, Jan 19, 2:56 PM · Restricted Project
steveire added inline comments to D94865: [ASTMatchers] Add callOrConstruct matcher.
Tue, Jan 19, 1:00 PM · Restricted Project

Sun, Jan 17

steveire added a comment to D94881: WIP: Add a way to define matcher builders in the dynamic registry.

This is WIP because there is still some error handling and code completion handling to do. Pushed the patch though to complete the series : https://github.com/steveire/llvm-project/commits/mapAnyOf

Sun, Jan 17, 10:17 AM · Restricted Project
steveire requested review of D94881: WIP: Add a way to define matcher builders in the dynamic registry.
Sun, Jan 17, 10:13 AM · Restricted Project
steveire requested review of D94880: Add clang-query support for mapAnyOf.
Sun, Jan 17, 10:10 AM · Restricted Project
steveire requested review of D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds.
Sun, Jan 17, 10:08 AM · Restricted Project
steveire requested review of D94878: Make it possible to store a ASTNodeKind in VariantValue.
Sun, Jan 17, 10:08 AM · Restricted Project
steveire requested review of D94877: Add API to retrieve a clade kind from ASTNodeKind.
Sun, Jan 17, 10:08 AM · Restricted Project
steveire requested review of D94876: Remove TypedMatcherOps from VariantValue.
Sun, Jan 17, 10:07 AM · Restricted Project

Sat, Jan 16

steveire updated the diff for D94131: [clang-tidy] Use new mapAnyOf matcher.

Update

Sat, Jan 16, 6:54 AM · Restricted Project
steveire requested review of D94865: [ASTMatchers] Add callOrConstruct matcher.
Sat, Jan 16, 6:54 AM · Restricted Project
steveire requested review of D94864: [ASTMatchers] Re-order the internals to allow another use-case.
Sat, Jan 16, 6:53 AM · Restricted Project

Thu, Jan 14

steveire added inline comments to D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator.
Thu, Jan 14, 3:23 PM · Restricted Project
steveire updated the diff for D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator.

Update

Thu, Jan 14, 12:43 PM · Restricted Project
steveire updated the diff for D94129: [ASTMatchers] Add binaryOperation matcher.

Update

Thu, Jan 14, 12:35 PM · Restricted Project
steveire updated the diff for D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators.

Update

Thu, Jan 14, 12:28 PM · Restricted Project
steveire added inline comments to D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators.
Thu, Jan 14, 12:27 PM · Restricted Project
steveire updated the diff for D94127: [ASTMatchers] Add mapAnyOf matcher.

Changed the implementation a bit to make clang-query integration easier

Thu, Jan 14, 11:18 AM · Restricted Project
steveire abandoned D94126: [ASTMatchers] Make it possible to use empty variadic matchers.
Thu, Jan 14, 8:16 AM · Restricted Project
steveire added inline comments to D94126: [ASTMatchers] Make it possible to use empty variadic matchers.
Thu, Jan 14, 7:46 AM · Restricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:54 AM · Restricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:32 AM · Restricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:22 AM · Restricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 5:38 AM · Restricted Project
steveire added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

I also don't think we need to add unit tests for this, just because we can. The tests would be more complex than the code and wouldn't add much value. https://softwareengineering.stackexchange.com/a/147342 There are lots of resources about this.

Thu, Jan 14, 5:38 AM · Restricted Project
steveire added inline comments to D94126: [ASTMatchers] Make it possible to use empty variadic matchers.
Thu, Jan 14, 5:24 AM · Restricted Project
steveire added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Can we make using color the default too? We already use colors for Decls I think, so this just adds colors for other Node types.

Thu, Jan 14, 5:21 AM · Restricted Project

Tue, Jan 5

steveire updated the diff for D94131: [clang-tidy] Use new mapAnyOf matcher.

Update

Tue, Jan 5, 3:42 PM · Restricted Project
steveire added a comment to D94127: [ASTMatchers] Add mapAnyOf matcher.

This is part of a series of commits. See them in context here: https://github.com/steveire/llvm-project/commits/mapAnyOf

Tue, Jan 5, 3:34 PM · Restricted Project
steveire requested review of D94131: [clang-tidy] Use new mapAnyOf matcher.
Tue, Jan 5, 3:33 PM · Restricted Project
steveire requested review of D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator.
Tue, Jan 5, 3:32 PM · Restricted Project
steveire requested review of D94129: [ASTMatchers] Add binaryOperation matcher.
Tue, Jan 5, 3:32 PM · Restricted Project
steveire requested review of D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators.
Tue, Jan 5, 3:31 PM · Restricted Project
steveire requested review of D94127: [ASTMatchers] Add mapAnyOf matcher.
Tue, Jan 5, 3:31 PM · Restricted Project
steveire requested review of D94126: [ASTMatchers] Make it possible to use empty variadic matchers.
Tue, Jan 5, 3:31 PM · Restricted Project
steveire added inline comments to D94031: [ASTMatchers] Fix child traversal over range-for loops.
Tue, Jan 5, 10:34 AM · Restricted Project
steveire updated the diff for D94031: [ASTMatchers] Fix child traversal over range-for loops.

Update

Tue, Jan 5, 10:34 AM · Restricted Project
steveire added inline comments to D94031: [ASTMatchers] Fix child traversal over range-for loops.
Tue, Jan 5, 9:52 AM · Restricted Project
steveire added inline comments to D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods.
Tue, Jan 5, 7:23 AM · Restricted Project
steveire added inline comments to D93987: [ASTMatchers] Fix build when no targets are enabled.
Tue, Jan 5, 6:43 AM · Restricted Project

Mon, Jan 4

steveire requested review of D94032: [ASTMatchers] Omit methods from explicit template instantations.
Mon, Jan 4, 1:45 PM · Restricted Project
steveire requested review of D94031: [ASTMatchers] Fix child traversal over range-for loops.
Mon, Jan 4, 1:45 PM · Restricted Project
steveire requested review of D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods.
Mon, Jan 4, 1:44 PM · Restricted Project
steveire requested review of D94029: [clang-tidy] Add extra tests.
Mon, Jan 4, 1:42 PM · Restricted Project
steveire added a comment to D93988: [ASTMatchers] Make tests explicit about mode-dependence.

Could you give me a bit more background about why you want to make this change?

Mon, Jan 4, 1:39 PM · Restricted Project
steveire added inline comments to D93987: [ASTMatchers] Fix build when no targets are enabled.
Mon, Jan 4, 1:35 PM · Restricted Project
steveire added inline comments to D93688: [ASTMatchers] Ensure that we can match inside lambdas.
Mon, Jan 4, 1:32 PM · Restricted Project
steveire updated the diff for D93688: [ASTMatchers] Ensure that we can match inside lambdas.

Update

Mon, Jan 4, 1:32 PM · Restricted Project
steveire updated the diff for D93688: [ASTMatchers] Ensure that we can match inside lambdas.

Update

Mon, Jan 4, 1:30 PM · Restricted Project

Sun, Jan 3

steveire requested review of D93988: [ASTMatchers] Make tests explicit about mode-dependence.
Sun, Jan 3, 5:53 AM · Restricted Project
steveire requested review of D93987: [ASTMatchers] Fix build when no targets are enabled.
Sun, Jan 3, 5:52 AM · Restricted Project

Tue, Dec 22

steveire added a comment to D91302: Handle template instantiations better in clang-tidy check.

Looks like this breaks tests on windows: http://45.33.8.238/win/30322/step_8.txt

Ptal, and revert for now if it takes a while to fix. (In particular, prefer reverting over disabling the test on win.)

Tue, Dec 22, 12:11 PM · Restricted Project
steveire added inline comments to D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers.
Tue, Dec 22, 10:23 AM · Restricted Project
steveire updated the diff for D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers.

Update

Tue, Dec 22, 10:22 AM · Restricted Project
steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Tue, Dec 22, 10:16 AM · Restricted Project
steveire updated the diff for D91303: [clang-tidy] readability-container-size-empty: simplify implementation.

Update

Tue, Dec 22, 10:06 AM · Restricted Project
steveire updated the diff for D91303: [clang-tidy] readability-container-size-empty: simplify implementation.

Update

Tue, Dec 22, 9:21 AM · Restricted Project
steveire added inline comments to D91303: [clang-tidy] readability-container-size-empty: simplify implementation.
Tue, Dec 22, 9:21 AM · Restricted Project
steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Tue, Dec 22, 8:58 AM · Restricted Project
steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Tue, Dec 22, 8:52 AM · Restricted Project
steveire added inline comments to D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers.
Tue, Dec 22, 8:25 AM · Restricted Project
steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Tue, Dec 22, 8:23 AM · Restricted Project
steveire added inline comments to D91302: Handle template instantiations better in clang-tidy check.
Tue, Dec 22, 7:33 AM · Restricted Project
steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Tue, Dec 22, 7:31 AM · Restricted Project
steveire updated the diff for D93688: [ASTMatchers] Ensure that we can match inside lambdas.

Update

Tue, Dec 22, 4:39 AM · Restricted Project
steveire requested review of D93688: [ASTMatchers] Ensure that we can match inside lambdas.
Tue, Dec 22, 4:24 AM · Restricted Project

Mon, Dec 21

steveire updated the diff for D93596: [ASTMatchers] Traverse-ignore range-for implementation details.

Update

Mon, Dec 21, 3:14 PM · Restricted Project

Dec 20 2020

steveire requested review of D93596: [ASTMatchers] Traverse-ignore range-for implementation details.
Dec 20 2020, 5:38 AM · Restricted Project

Dec 15 2020

steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Dec 15 2020, 4:36 PM · Restricted Project
steveire added inline comments to D91302: Handle template instantiations better in clang-tidy check.
Dec 15 2020, 3:47 PM · Restricted Project
steveire added a reviewer for D91302: Handle template instantiations better in clang-tidy check: aaron.ballman.
Dec 15 2020, 3:44 PM · Restricted Project
steveire updated the diff for D91302: Handle template instantiations better in clang-tidy check.

Update

Dec 15 2020, 3:44 PM · Restricted Project
steveire added a reviewer for D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers: aaron.ballman.
Dec 15 2020, 3:38 PM · Restricted Project
steveire updated the diff for D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers.

Update

Dec 15 2020, 3:38 PM · Restricted Project
steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 15 2020, 2:50 PM · Restricted Project
steveire updated subscribers of D93164: [AST] Add generator for source location introspection.

@thakis FYI - I think the GN build would need to be adapted to this.

Dec 15 2020, 2:41 PM · Restricted Project
steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 15 2020, 2:38 PM · Restricted Project
steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 15 2020, 2:24 PM · Restricted Project
steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 15 2020, 2:23 PM · Restricted Project
steveire added inline comments to D93164: [AST] Add generator for source location introspection.
Dec 15 2020, 2:08 PM · Restricted Project
steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 15 2020, 2:08 PM · Restricted Project
steveire added a comment to D93164: [AST] Add generator for source location introspection.

Do I understand correctly that the workflow is to use the new dumping tool to generate the needed JSON file that then gets used as input to generate_cxx_src_locs.py which creates NodeLocationIntrospection.cpp/.h that then gets used by clang-query (eventually)?

Dec 15 2020, 2:04 PM · Restricted Project
steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 15 2020, 2:01 PM · Restricted Project
steveire requested review of D93325: Add srcloc output to clang-query.
Dec 15 2020, 11:20 AM · Restricted Project
steveire requested review of D93324: Avoid isImplicit call on object which could be nullptr.
Dec 15 2020, 11:17 AM · Restricted Project

Dec 14 2020

steveire accepted D93244: Remove the ast_type_traits namespace..

LGTM

Dec 14 2020, 2:16 PM · Restricted Project

Dec 12 2020

steveire updated the diff for D93164: [AST] Add generator for source location introspection.

Update

Dec 12 2020, 10:33 AM · Restricted Project
steveire requested review of D93164: [AST] Add generator for source location introspection.
Dec 12 2020, 10:24 AM · Restricted Project

Nov 21 2020

steveire requested review of D91918: Remove the IgnoreImplicitCastsAndParentheses traversal kind.
Nov 21 2020, 10:55 AM · Restricted Project
steveire updated the diff for D91916: Remove automatic traversal from forEach matcher.

Update

Nov 21 2020, 10:52 AM · Restricted Project
steveire requested review of D91917: Update mode used in traverse() examples.
Nov 21 2020, 10:51 AM · Restricted Project
steveire requested review of D91916: Remove automatic traversal from forEach matcher.
Nov 21 2020, 10:43 AM · Restricted Project

Nov 20 2020

steveire updated the diff for D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.

Update

Nov 20 2020, 2:35 AM · Restricted Project
steveire added inline comments to D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.
Nov 20 2020, 2:35 AM · Restricted Project

Nov 19 2020

steveire added inline comments to D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.
Nov 19 2020, 11:45 AM · Restricted Project
steveire updated the diff for D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.

Update

Nov 19 2020, 11:42 AM · Restricted Project

Nov 18 2020

steveire requested changes to D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved.
Nov 18 2020, 7:38 AM · Restricted Project