- User Since
- Sep 5 2013, 6:50 AM (267 w, 4 d)
I prefer the API from Peter. I think it's a good additional step from where Aaron and I reached in IRC discussion (this patch currently).
This is already not the case with set output diag etc.
This seems confusing to me because I would expect set foo bar to set the value of a variable foo to bar,
Sat, Oct 20
Don't deprecate existing API
Perhaps the best solution is to introduce this new API, but not deprecate the existing 'exclusive' API.
Rename dump-output to ast-output.
Thu, Oct 11
Wed, Oct 10
I don't see this functionality being so critical that we need to deprecate the existing spelling when there are backwards compatible options available, which is why I'm opposed to this patch going in with the proposed syntax.
you have to find the right place to stick the `set dump-output true` in order to enable it.
Tue, Oct 9
What's more, given that clang-output has no real documentation to speak of, how will users even *know* to update their scripts?
- The scripts will continue to work at least until set output is removed, which is not going to happen soon.
- A comma-delimited list of options means that if I have foo, bar, bat enabled and want to add bang, I need to set output foo, bar, bat, bang. Or alternatively if I want to remove bat, I need to write out all the others. I don't think that's suitable.
Mon, Oct 8
Can I convince someone to be interested enough in this to approve it?
Thu, Oct 4
Wed, Oct 3
I didn't run it, but CMake-wise this looks fine. (I trust you did)
I use separate git repos. This patch is in LLVM.git, and the other is in clang.git.
Tue, Oct 2
@Szelethus You can approve it and then you will get the feature :).
Mon, Oct 1