This is an archive of the discontinued LLVM Phabricator instance.

Add flag to enable profile remapping to external interfaces to LLVM.
ClosedPublic

Authored by rsmith on Aug 24 2018, 6:30 PM.

Diff Detail

Event Timeline

rsmith created this revision.Aug 24 2018, 6:30 PM
davidxl added inline comments.Aug 26 2018, 8:38 PM
lib/Transforms/IPO/SampleProfile.cpp
99

add some brief description on what the remapping file is for.

1533

Add a comment on what the Remapper does here. In particular, comment on the API name 'ItaniumRemapper' -- which will look very strange for maintainers without knowing the background.

rsmith updated this revision to Diff 162728.Aug 27 2018, 12:41 PM
rsmith marked 2 inline comments as done.

Update comments as requested.

davidxl accepted this revision.Sep 4 2018, 10:25 AM

lgtm

This revision is now accepted and ready to land.Sep 4 2018, 10:25 AM
This revision was automatically updated to reflect the committed changes.