Page MenuHomePhabricator

dlj (David L. Jones)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2016, 10:48 AM (183 w, 4 d)
Roles
Administrator

Recent Activity

Mon, Aug 19

dlj committed rGcedd0d9a6e4b: Revert [Attributor] Fix: Make sure we set the changed flag (authored by dlj).
Revert [Attributor] Fix: Make sure we set the changed flag
Mon, Aug 19, 1:06 AM
dlj committed rL369241: Revert [Attributor] Fix: Make sure we set the changed flag.
Revert [Attributor] Fix: Make sure we set the changed flag
Mon, Aug 19, 12:59 AM
dlj committed rGb1752f670f3d: Revert [Attributor] Fix: Do not partially resolve returned calls. (authored by dlj).
Revert [Attributor] Fix: Do not partially resolve returned calls.
Mon, Aug 19, 12:17 AM
dlj committed rL369236: Revert [Attributor] Fix: Do not partially resolve returned calls..
Revert [Attributor] Fix: Do not partially resolve returned calls.
Mon, Aug 19, 12:15 AM

Thu, Aug 15

dlj committed rG27954c36443d: [NewPM][PassInstrumentation] Fix test added in r369024. (authored by dlj).
[NewPM][PassInstrumentation] Fix test added in r369024.
Thu, Aug 15, 4:26 PM
dlj committed rL369066: [NewPM][PassInstrumentation] Fix test added in r369024..
[NewPM][PassInstrumentation] Fix test added in r369024.
Thu, Aug 15, 4:26 PM

Wed, Aug 14

dlj committed rG4ed5521cad79: [Tooling] Add a hack to work around issues with matcher binding in r368681. (authored by dlj).
[Tooling] Add a hack to work around issues with matcher binding in r368681.
Wed, Aug 14, 9:13 PM
dlj committed rL368958: [Tooling] Add a hack to work around issues with matcher binding in r368681..
[Tooling] Add a hack to work around issues with matcher binding in r368681.
Wed, Aug 14, 9:13 PM
dlj closed D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681..
Wed, Aug 14, 9:12 PM · Restricted Project, Restricted Project
dlj created D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681..
Wed, Aug 14, 9:04 PM · Restricted Project, Restricted Project

Tue, Aug 13

dlj committed rGd4edd9d97e4e: Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM' (authored by dlj).
Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM'
Tue, Aug 13, 9:54 PM
dlj added a comment to rL368542: Fix pass dependency for LICM.

FYI: reverted in r368800.

Tue, Aug 13, 9:54 PM
dlj added a comment to rL368526: [LICM] Make Loop ICM profile aware.

FYI: reverted in r368800.

Tue, Aug 13, 9:49 PM
dlj added a comment to D65060: [LICM] Make Loop ICM profile aware.

FYI: reverted in r368800.

Tue, Aug 13, 9:49 PM · Restricted Project
dlj committed rL368800: Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM'.
Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM'
Tue, Aug 13, 9:49 PM
dlj added a comment to rL368526: [LICM] Make Loop ICM profile aware.

This change (along with the subsequent fixes) seems to cause a stage3 clang to miscompile itself when using an FDO profile and Thin LTO (i.e., using stage2 Clang built with FDO and ThinLTO to rebuild itself yields non-deterministic output). The failure is still present past r368596, so that revision did not fix whatever issue I'm seeing.

Tue, Aug 13, 9:34 PM

Mon, Aug 12

dlj added inline comments to D64939: Add a proposal for a libc project under the LLVM umbrella..
Mon, Aug 12, 12:41 PM · Restricted Project

Thu, Aug 8

dlj added a comment to D64939: Add a proposal for a libc project under the LLVM umbrella..

(Wall of text warning... sorry!)

Thu, Aug 8, 5:44 PM · Restricted Project

Jun 12 2019

dlj committed rGc73fadaa8439: Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG… (authored by dlj).
Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG…
Jun 12 2019, 7:02 PM
dlj committed rL363220: Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG….
Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG…
Jun 12 2019, 7:01 PM

May 26 2019

dlj committed rG0ff41b8a5afb: Revert r361356: "[MIR] Add simple PRE pass to MachineCSE" (authored by dlj).
Revert r361356: "[MIR] Add simple PRE pass to MachineCSE"
May 26 2019, 10:59 PM
dlj committed rL361746: Revert r361356: "[MIR] Add simple PRE pass to MachineCSE".
Revert r361356: "[MIR] Add simple PRE pass to MachineCSE"
May 26 2019, 10:57 PM

May 16 2019

dlj committed rG4a5e01faa493: [X86][AsmParser] Add mnemonics missed in r360954. (authored by dlj).
[X86][AsmParser] Add mnemonics missed in r360954.
May 16 2019, 5:18 PM
dlj committed rL360960: [X86][AsmParser] Add mnemonics missed in r360954..
[X86][AsmParser] Add mnemonics missed in r360954.
May 16 2019, 5:18 PM
dlj committed rGadd7ed228162: [X86][AsmParser] Ignore "short" even harder in Intel syntax ASM. (authored by dlj).
[X86][AsmParser] Ignore "short" even harder in Intel syntax ASM.
May 16 2019, 4:27 PM
dlj committed rG11305984d054: [X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate". (authored by dlj).
[X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate".
May 16 2019, 4:27 PM
dlj committed rL360954: [X86][AsmParser] Ignore "short" even harder in Intel syntax ASM..
[X86][AsmParser] Ignore "short" even harder in Intel syntax ASM.
May 16 2019, 4:26 PM
dlj closed D61990: [X86] Ignore "short" even harder in Intel ASM..
May 16 2019, 4:26 PM · Restricted Project
dlj committed rL360953: [X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate"..
[X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate".
May 16 2019, 4:26 PM
dlj committed rG9adabefdcee6: [clang/test] Add missing dependency on llvm-cxxfilt. (authored by dlj).
[clang/test] Add missing dependency on llvm-cxxfilt.
May 16 2019, 2:12 PM
dlj committed rL360939: [clang/test] Add missing dependency on llvm-cxxfilt..
[clang/test] Add missing dependency on llvm-cxxfilt.
May 16 2019, 2:11 PM
dlj committed rC360939: [clang/test] Add missing dependency on llvm-cxxfilt..
[clang/test] Add missing dependency on llvm-cxxfilt.
May 16 2019, 2:11 PM

May 15 2019

dlj created D61990: [X86] Ignore "short" even harder in Intel ASM..
May 15 2019, 9:10 PM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.

Run gn format

May 15 2019, 6:56 AM · Restricted Project

May 14 2019

dlj added inline comments to D61821: gn build: add RISCV target.
May 14 2019, 8:19 AM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.
May 14 2019, 8:19 AM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.
May 14 2019, 8:18 AM · Restricted Project

May 13 2019

dlj added inline comments to D61821: gn build: add RISCV target.
May 13 2019, 9:24 PM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.
May 13 2019, 9:21 PM · Restricted Project
dlj committed rGfe1aec0dbb16: gn build: add Hexagon target (authored by dlj).
gn build: add Hexagon target
May 13 2019, 9:13 PM
dlj committed rL360647: gn build: add Hexagon target.
gn build: add Hexagon target
May 13 2019, 9:11 PM
dlj closed D61819: gn build: add Hexagon target.
May 13 2019, 9:11 PM · Restricted Project
dlj updated the diff for D61819: gn build: add Hexagon target.
May 13 2019, 9:11 PM · Restricted Project
dlj added a comment to D61819: gn build: add Hexagon target.

Like with the Lanai target: lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;

May 13 2019, 9:11 PM · Restricted Project
dlj added an edge to rG4fb6fcacf496: gn build: add Sparc target: D61820: gn build: add Sparc target.
May 13 2019, 9:05 PM
dlj closed D61820: gn build: add Sparc target.
May 13 2019, 9:05 PM · Restricted Project
dlj added an edge to rL360645: gn build: add Sparc target: D61820: gn build: add Sparc target.
May 13 2019, 9:05 PM
dlj added an edge to rG500a6db47951: gn build: add Lanai target: D61818: gn build: add Lanai target.
May 13 2019, 9:05 PM
dlj added 2 commit(s) for D61820: gn build: add Sparc target: rG4fb6fcacf496: gn build: add Sparc target, rL360645: gn build: add Sparc target.
May 13 2019, 9:05 PM · Restricted Project
dlj added 2 commit(s) for D61818: gn build: add Lanai target: rG500a6db47951: gn build: add Lanai target, rL360644: gn build: add Lanai target.
May 13 2019, 9:05 PM · Restricted Project
dlj added an edge to rL360644: gn build: add Lanai target: D61818: gn build: add Lanai target.
May 13 2019, 9:05 PM
dlj closed D61818: gn build: add Lanai target.

https://reviews.llvm.org/rG500a6db47951521cbe4b3d23976aa4b790085019

May 13 2019, 9:05 PM · Restricted Project
dlj committed rG4fb6fcacf496: gn build: add Sparc target (authored by dlj).
gn build: add Sparc target
May 13 2019, 9:03 PM
dlj committed rL360645: gn build: add Sparc target.
gn build: add Sparc target
May 13 2019, 9:02 PM
dlj added inline comments to D61820: gn build: add Sparc target.
May 13 2019, 9:02 PM · Restricted Project
dlj updated the diff for D61820: gn build: add Sparc target.
May 13 2019, 9:02 PM · Restricted Project
dlj committed rG500a6db47951: gn build: add Lanai target (authored by dlj).
gn build: add Lanai target
May 13 2019, 8:52 PM
dlj committed rL360644: gn build: add Lanai target.
gn build: add Lanai target
May 13 2019, 8:52 PM
dlj added a comment to D61818: gn build: add Lanai target.

lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;

May 13 2019, 8:49 PM · Restricted Project
dlj updated the diff for D61818: gn build: add Lanai target.
May 13 2019, 8:49 PM · Restricted Project
dlj committed rG3cce23746edf: [Support] Ensure redirected outputs don't contain output from previous tests. (authored by dlj).
[Support] Ensure redirected outputs don't contain output from previous tests.
May 13 2019, 1:33 PM
dlj committed rL360617: [Support] Ensure redirected outputs don't contain output from previous tests..
[Support] Ensure redirected outputs don't contain output from previous tests.
May 13 2019, 1:33 PM
dlj accepted D61859: gn build: Fewer dependencies in llvm/lib/Target.

Ah, this makes sense. I had missed the distinction on the :tablegen targets.

May 13 2019, 9:53 AM · Restricted Project

May 12 2019

dlj added a comment to rGf9180b5abe40: gn build: support host build on ppc64 (a.k.a. powerpc64le).

Yup, that's why I worded the message the way I did.

May 12 2019, 10:18 PM
dlj committed rGf9180b5abe40: gn build: support host build on ppc64 (a.k.a. powerpc64le) (authored by dlj).
gn build: support host build on ppc64 (a.k.a. powerpc64le)
May 12 2019, 9:06 PM
dlj committed rL360553: gn build: support host build on ppc64 (a.k.a. powerpc64le).
gn build: support host build on ppc64 (a.k.a. powerpc64le)
May 12 2019, 9:06 PM
dlj committed rG3e6d69063d71: gn build: merge r360550 (authored by dlj).
gn build: merge r360550
May 12 2019, 8:42 PM
dlj committed rL360551: gn build: merge r360550.
gn build: merge r360550
May 12 2019, 8:42 PM
dlj committed rGa263aa25e1f8: [WebAssembly] Move InstPrinter files to MCTargetDesc. NFC (authored by dlj).
[WebAssembly] Move InstPrinter files to MCTargetDesc. NFC
May 12 2019, 8:33 PM
dlj committed rL360550: [WebAssembly] Move InstPrinter files to MCTargetDesc. NFC.
[WebAssembly] Move InstPrinter files to MCTargetDesc. NFC
May 12 2019, 8:30 PM

May 10 2019

dlj created D61821: gn build: add RISCV target.
May 10 2019, 10:21 PM · Restricted Project
dlj created D61820: gn build: add Sparc target.
May 10 2019, 9:44 PM · Restricted Project
dlj created D61819: gn build: add Hexagon target.
May 10 2019, 9:24 PM · Restricted Project
dlj created D61818: gn build: add Lanai target.
May 10 2019, 8:51 PM · Restricted Project
dlj committed rG3814d6003568: gn build: sort tablegen rules for X86 and AArch64 (authored by dlj).
gn build: sort tablegen rules for X86 and AArch64
May 10 2019, 8:22 PM
dlj committed rL360508: gn build: sort tablegen rules for X86 and AArch64.
gn build: sort tablegen rules for X86 and AArch64
May 10 2019, 8:22 PM
dlj committed rGb8cfb1b165b8: gn build: merge r360494 and r360502 (authored by dlj).
gn build: merge r360494 and r360502
May 10 2019, 8:18 PM
dlj committed rL360507: gn build: merge r360494 and r360502.
gn build: merge r360494 and r360502
May 10 2019, 8:18 PM
dlj committed rGed355330a375: gn build: merge r360490 (authored by dlj).
gn build: merge r360490
May 10 2019, 5:44 PM
dlj committed rL360492: gn build: merge r360490.
gn build: merge r360490
May 10 2019, 5:44 PM
dlj committed rG55120b23455e: gn build: merge r360484 and r360486 (authored by dlj).
gn build: merge r360484 and r360486
May 10 2019, 5:34 PM
dlj committed rL360491: gn build: merge r360484 and r360486.
gn build: merge r360484 and r360486
May 10 2019, 5:34 PM
dlj committed rGd387fd0f75fc: gn build: merge r360345 (authored by dlj).
gn build: merge r360345
May 10 2019, 5:22 PM
dlj committed rL360489: gn build: merge r360345.
gn build: merge r360345
May 10 2019, 5:17 PM

Apr 30 2019

dlj committed rGfccb505f0f59: Revert "[llvm] r359313 - [PowerPC] Update P9 vector costs for insert/extract… (authored by dlj).
Revert "[llvm] r359313 - [PowerPC] Update P9 vector costs for insert/extract…
Apr 30 2019, 10:03 PM
dlj committed rL359648: Revert "[llvm] r359313 - [PowerPC] Update P9 vector costs for insert/extract….
Revert "[llvm] r359313 - [PowerPC] Update P9 vector costs for insert/extract…
Apr 30 2019, 9:58 PM

Apr 8 2019

dlj accepted D60430: Add a reduced copy of the llvm .gitignore as a start for the monorepo .gitignore.
Apr 8 2019, 5:49 PM · Restricted Project

Apr 3 2019

dlj committed rG8b8a02175a46: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink… (authored by dlj).
Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Apr 3 2019, 7:27 PM
dlj committed rL357667: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink….
Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Apr 3 2019, 7:27 PM
dlj committed rC357667: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink….
Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Apr 3 2019, 7:27 PM
dlj added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

This revision causes tests to fail under ASAN. After some investigation (with Chandler's help), it looks like the safest course of action is to revert. We're following up with Hans separately.

Apr 3 2019, 7:27 PM · Restricted Project
dlj added a comment to rL357256: [DAGCombine] Improve Lifetime node chains..

@niravd I'm not certain but I think this is causing the EXPENSIVE_CHECKS failures: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/16678

Apr 3 2019, 3:47 PM

Feb 8 2019

dlj committed rGc5cb2ce905cd: [LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the… (authored by dlj).
[LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the…
Feb 8 2019, 9:03 PM
dlj committed rLLD353602: [LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the….
[LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the…
Feb 8 2019, 9:03 PM
dlj committed rL353602: [LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the….
[LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the…
Feb 8 2019, 9:02 PM
dlj committed rG191ba3cc03d2: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC] (authored by dlj).
[StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]
Feb 8 2019, 6:43 PM
dlj committed rC353599: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC].
[StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]
Feb 8 2019, 6:43 PM
dlj committed rL353599: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC].
[StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]
Feb 8 2019, 6:43 PM
dlj committed rG6218b8e783eb: [Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC] (authored by dlj).
[Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC]
Feb 8 2019, 5:47 PM
dlj committed rL353596: [Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC].
[Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC]
Feb 8 2019, 5:47 PM