Page MenuHomePhabricator

dlj (David L. Jones)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2016, 10:48 AM (165 w, 4 d)
Roles
Administrator

Recent Activity

Mon, Apr 8

dlj accepted D60430: Add a reduced copy of the llvm .gitignore as a start for the monorepo .gitignore.
Mon, Apr 8, 5:49 PM · Restricted Project

Wed, Apr 3

dlj committed rG8b8a02175a46: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink… (authored by dlj).
Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Wed, Apr 3, 7:27 PM
dlj committed rL357667: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink….
Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Wed, Apr 3, 7:27 PM
dlj committed rC357667: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink….
Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Wed, Apr 3, 7:27 PM
dlj added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

This revision causes tests to fail under ASAN. After some investigation (with Chandler's help), it looks like the safest course of action is to revert. We're following up with Hans separately.

Wed, Apr 3, 7:27 PM · Restricted Project
dlj added a comment to rL357256: [DAGCombine] Improve Lifetime node chains..

@niravd I'm not certain but I think this is causing the EXPENSIVE_CHECKS failures: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/16678

Wed, Apr 3, 3:47 PM

Feb 8 2019

dlj committed rGc5cb2ce905cd: [LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the… (authored by dlj).
[LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the…
Feb 8 2019, 9:03 PM
dlj committed rLLD353602: [LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the….
[LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the…
Feb 8 2019, 9:03 PM
dlj committed rL353602: [LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the….
[LLD][ELF] Ensure tests use -o /dev/null instead of attempting to write to the…
Feb 8 2019, 9:02 PM
dlj committed rG191ba3cc03d2: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC] (authored by dlj).
[StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]
Feb 8 2019, 6:43 PM
dlj committed rC353599: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC].
[StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]
Feb 8 2019, 6:43 PM
dlj committed rL353599: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC].
[StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]
Feb 8 2019, 6:43 PM
dlj committed rG6218b8e783eb: [Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC] (authored by dlj).
[Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC]
Feb 8 2019, 5:47 PM
dlj committed rL353596: [Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC].
[Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC]
Feb 8 2019, 5:47 PM
dlj committed rCRT353596: [Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC].
[Fuzzer] Fix function prototype in fuzzer::ExternalFunctions. [NFC]
Feb 8 2019, 5:47 PM

Feb 5 2019

dlj committed rG4c3ba38429f4: [wasm-ld] Fix wasm trace test to use %t for temporary files. (authored by dlj).
[wasm-ld] Fix wasm trace test to use %t for temporary files.
Feb 5 2019, 8:50 PM
dlj committed rL353272: [wasm-ld] Fix wasm trace test to use %t for temporary files..
[wasm-ld] Fix wasm trace test to use %t for temporary files.
Feb 5 2019, 8:49 PM
dlj committed rLLD353272: [wasm-ld] Fix wasm trace test to use %t for temporary files..
[wasm-ld] Fix wasm trace test to use %t for temporary files.
Feb 5 2019, 8:49 PM

Jan 30 2019

dlj committed rL352722: Revert "Reapply "[CGP] Check for existing inttotpr before creating new one"".
Revert "Reapply "[CGP] Check for existing inttotpr before creating new one""
Jan 30 2019, 7:29 PM

Jan 28 2019

dlj accepted D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes.

Given that this path changes with every clang release, so you're effectively making a hard dependency on the clang version used to build the program, I dare say some systems may either decide not to support shared runtimes at all or use ld.so.conf or equivalent that can be dynamically changed.

Jan 28 2019, 5:35 PM

Jan 14 2019

dlj committed rL351158: [LLDB] Remove the unused variable oso_dwarf..
[LLDB] Remove the unused variable oso_dwarf.
Jan 14 2019, 7:32 PM
dlj committed rLLDB351158: [LLDB] Remove the unused variable oso_dwarf..
[LLDB] Remove the unused variable oso_dwarf.
Jan 14 2019, 7:31 PM

Dec 12 2018

dlj committed rL349002: Revert r348645 - "[MemCpyOpt] memset->memcpy forwarding with undef tail".
Revert r348645 - "[MemCpyOpt] memset->memcpy forwarding with undef tail"
Dec 12 2018, 7:18 PM

Dec 5 2018

dlj committed rL348426: Revert r347934 "[SCEV] Guard movement of insertion point for loop-invariants".
Revert r347934 "[SCEV] Guard movement of insertion point for loop-invariants"
Dec 5 2018, 3:18 PM

Nov 16 2018

dlj committed rC347133: Fix unused variable warning..
Fix unused variable warning.
Nov 16 2018, 8:51 PM
dlj committed rL347133: Fix unused variable warning..
Fix unused variable warning.
Nov 16 2018, 8:51 PM

Aug 17 2018

dlj accepted D50930: Move Itanium demangler implementation into a header file and add visitation support..

Looks fine for my comments.

Aug 17 2018, 5:57 PM
dlj added inline comments to D50930: Move Itanium demangler implementation into a header file and add visitation support..
Aug 17 2018, 5:20 PM

Aug 2 2018

dlj committed rL338772: [lldb] Remove unused variable..
[lldb] Remove unused variable.
Aug 2 2018, 2:45 PM
dlj committed rLLDB338772: [lldb] Remove unused variable..
[lldb] Remove unused variable.
Aug 2 2018, 2:45 PM

Jul 31 2018

dlj committed rL338448: [WebAssembly] Fix debug info tests after r338437..
[WebAssembly] Fix debug info tests after r338437.
Jul 31 2018, 3:24 PM
dlj committed rLLD338440: [lld] Fix test RUN commands so they don't fail when run in a read-only….
[lld] Fix test RUN commands so they don't fail when run in a read-only…
Jul 31 2018, 2:16 PM
dlj committed rL338440: [lld] Fix test RUN commands so they don't fail when run in a read-only….
[lld] Fix test RUN commands so they don't fail when run in a read-only…
Jul 31 2018, 2:16 PM

Jun 21 2018

dlj added an edge to rC335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.: D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates..
Jun 21 2018, 5:21 PM
dlj added an edge to rL335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.: D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates..
Jun 21 2018, 5:21 PM
dlj added 2 commit(s) for D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.: rL335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates., rC335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates..
Jun 21 2018, 5:21 PM

Jun 20 2018

dlj closed D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 20 2018, 12:06 AM · Restricted Project
dlj added 1 commit(s) for D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc().: rC334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 20 2018, 12:06 AM · Restricted Project
dlj added an edge to rC334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc().: D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 20 2018, 12:06 AM

Jun 18 2018

dlj committed rC334930: [ASTMatchers] Add support for matching the type of a friend decl..
[ASTMatchers] Add support for matching the type of a friend decl.
Jun 18 2018, 2:27 AM
dlj committed rL334930: [ASTMatchers] Add support for matching the type of a friend decl..
[ASTMatchers] Add support for matching the type of a friend decl.
Jun 18 2018, 2:27 AM
dlj closed D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 18 2018, 2:27 AM · Restricted Project
dlj committed rC334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
[ASTMatchers] Don't assert-fail in specifiesTypeLoc().
Jun 18 2018, 2:07 AM
dlj added a comment to D48242: [ASTMatchers] Add support for matching the type of a friend decl..

Ping for Manuel...

Jun 18 2018, 2:04 AM · Restricted Project
dlj committed rL334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
[ASTMatchers] Don't assert-fail in specifiesTypeLoc().
Jun 18 2018, 2:03 AM
dlj created D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 18 2018, 1:42 AM · Restricted Project

Jun 15 2018

dlj added inline comments to D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 15 2018, 5:21 PM · Restricted Project
dlj updated the diff for D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 15 2018, 5:21 PM · Restricted Project
dlj created D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 15 2018, 3:14 PM · Restricted Project

Jun 14 2018

dlj committed rC334801: [Format] Do not use a global static value for EOF within ScopedMacroState..
[Format] Do not use a global static value for EOF within ScopedMacroState.
Jun 14 2018, 11:13 PM
dlj committed rL334801: [Format] Do not use a global static value for EOF within ScopedMacroState..
[Format] Do not use a global static value for EOF within ScopedMacroState.
Jun 14 2018, 11:13 PM
dlj closed D47759: [Format] Do not use a global static value for EOF within ScopedMacroState..
Jun 14 2018, 11:13 PM · Restricted Project
dlj added a comment to D47759: [Format] Do not use a global static value for EOF within ScopedMacroState..

Ping...

Jun 14 2018, 3:32 PM · Restricted Project

Jun 11 2018

dlj accepted rLLD334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance..

This was reviewed by ruiu in https://reviews.llvm.org/D47975.

Jun 11 2018, 1:34 PM
dlj accepted rL334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance..

This was reviewed by ruiu in https://reviews.llvm.org/D47975.

Jun 11 2018, 1:34 PM
dlj added 2 commit(s) for D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance.: rLLD334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance., rL334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 1:30 PM
dlj added an edge to rL334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance.: D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 1:30 PM
dlj added an edge to rLLD334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance.: D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 1:30 PM

Jun 4 2018

dlj created D47759: [Format] Do not use a global static value for EOF within ScopedMacroState..
Jun 4 2018, 8:42 PM · Restricted Project

May 7 2018

dlj committed rL331733: Tag release branches/google/stable as tags/google/stable/2018-04-24.
Tag release branches/google/stable as tags/google/stable/2018-04-24
May 7 2018, 9:17 PM
dlj committed rL331732: Cherry-pick @=r331237 to google/stable for 2018-04-24.
Cherry-pick @=r331237 to google/stable for 2018-04-24
May 7 2018, 9:17 PM
dlj committed rL331731: Cherry-pick @=r331041 to google/stable for 2018-04-24.
Cherry-pick @=r331041 to google/stable for 2018-04-24
May 7 2018, 9:16 PM
dlj committed rL331730: Cherry-pick @=r330997 to google/stable for 2018-04-24.
Cherry-pick @=r330997 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331729: Cherry-pick @=r330951 to google/stable for 2018-04-24.
Cherry-pick @=r330951 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331728: Cherry-pick @=r330950 to google/stable for 2018-04-24.
Cherry-pick @=r330950 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331727: Cherry-pick @=r330947 to google/stable for 2018-04-24.
Cherry-pick @=r330947 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331726: Cherry-pick @=r330893 to google/stable for 2018-04-24.
Cherry-pick @=r330893 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331725: Release 2018-04-24 for google/stable @r330764.
Release 2018-04-24 for google/stable @r330764
May 7 2018, 9:14 PM
dlj committed rL331720: Release 2018-04-24 for google/stable @r330864.
Release 2018-04-24 for google/stable @r330864
May 7 2018, 8:41 PM
dlj committed rL331724: Tag release branches/google/stable as tags/google/stable/2018-04-24.
Tag release branches/google/stable as tags/google/stable/2018-04-24
May 7 2018, 8:30 PM
dlj committed rL331723: Release 2018-04-24 for google/stable @r330764.
Release 2018-04-24 for google/stable @r330764
May 7 2018, 8:29 PM

May 1 2018

dlj committed rT331314: [test-suite] Fix UB in initialization code for stepanov_container..
[test-suite] Fix UB in initialization code for stepanov_container.
May 1 2018, 3:30 PM
dlj committed rL331314: [test-suite] Fix UB in initialization code for stepanov_container..
[test-suite] Fix UB in initialization code for stepanov_container.
May 1 2018, 3:29 PM

Mar 5 2018

dlj added a parent revision for D44123: [AST] Enhance comment accessing interface. (NFC): D44122: [AST] Factor out RawComment lookup and caching. (NFC).
Mar 5 2018, 3:41 PM · Restricted Project
dlj added a child revision for D44122: [AST] Factor out RawComment lookup and caching. (NFC): D44123: [AST] Enhance comment accessing interface. (NFC).
Mar 5 2018, 3:41 PM · Restricted Project
dlj created D44123: [AST] Enhance comment accessing interface. (NFC).
Mar 5 2018, 3:40 PM · Restricted Project
dlj updated the summary of D44122: [AST] Factor out RawComment lookup and caching. (NFC).
Mar 5 2018, 3:38 PM · Restricted Project
dlj created D44122: [AST] Factor out RawComment lookup and caching. (NFC).
Mar 5 2018, 3:37 PM · Restricted Project

Mar 1 2018

dlj committed rL326512: [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying….
[NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying…
Mar 1 2018, 4:11 PM
dlj committed rC326512: [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying….
[NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying…
Mar 1 2018, 4:11 PM
dlj added a comment to rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it..

This was re-committed:
https://reviews.llvm.org/rL326512

Mar 1 2018, 4:11 PM
dlj added a comment to rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it..

For the curious, this was reverted:
https://reviews.llvm.org/rL326508

Mar 1 2018, 3:20 PM
dlj committed rC326508: Revert r326501 due to buildbot breakage..
Revert r326501 due to buildbot breakage.
Mar 1 2018, 3:16 PM
dlj committed rL326508: Revert r326501 due to buildbot breakage..
Revert r326501 due to buildbot breakage.
Mar 1 2018, 3:16 PM
dlj committed rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it..
[NFC] Move CommentOpts checks to the call sites that depend on it.
Mar 1 2018, 2:46 PM
dlj committed rC326501: [NFC] Move CommentOpts checks to the call sites that depend on it..
[NFC] Move CommentOpts checks to the call sites that depend on it.
Mar 1 2018, 2:46 PM
dlj closed D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Mar 1 2018, 2:46 PM

Feb 26 2018

dlj created D43800: [ASTMatchers] Allow file-based narrowing matches to work with NestedNameSpecifierLocs..
Feb 26 2018, 6:59 PM

Feb 22 2018

dlj updated the summary of D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Feb 22 2018, 5:35 PM
dlj updated the summary of D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Feb 22 2018, 5:35 PM
dlj created D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Feb 22 2018, 5:31 PM

Jan 11 2018

dlj committed rL322335: Revert r322279 due to Skylake miscompile..
Revert r322279 due to Skylake miscompile.
Jan 11 2018, 4:19 PM
dlj closed D41972: Revert r322279 due to Skylake miscompile..
Jan 11 2018, 4:19 PM
dlj created D41972: Revert r322279 due to Skylake miscompile..
Jan 11 2018, 4:16 PM

Nov 14 2017

dlj committed rL318249: Creating branches/google/stable and tags/google/stable/ from r317716.
Creating branches/google/stable and tags/google/stable/ from r317716
Nov 14 2017, 5:46 PM

Nov 9 2017

dlj committed rL317856: Creating branches/google/testing and tags/google/testing/ from r317203.
Creating branches/google/testing and tags/google/testing/ from r317203
Nov 9 2017, 5:52 PM
dlj committed rL317857: Cherry-pick r317444 to google/testing..
Cherry-pick r317444 to google/testing.
Nov 9 2017, 5:16 PM

Nov 8 2017

dlj committed rL317716: Add a missing "REQUIRES: system-windows" to a Windows-only test..
Add a missing "REQUIRES: system-windows" to a Windows-only test.
Nov 8 2017, 12:03 PM

Nov 6 2017

dlj created P8045 ASAN and -fdebug-pass-manager for PR35210.
Nov 6 2017, 6:11 PM

Nov 5 2017

dlj committed rL317444: [PassManager, SimplifyCFG] Revert r316908 and r316869..
[PassManager, SimplifyCFG] Revert r316908 and r316869.
Nov 5 2017, 4:32 PM