Page MenuHomePhabricator

dlj (David L. Jones)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2016, 10:48 AM (147 w, 6 d)
Roles
Administrator

Recent Activity

Wed, Dec 12

dlj committed rL349002: Revert r348645 - "[MemCpyOpt] memset->memcpy forwarding with undef tail".
Revert r348645 - "[MemCpyOpt] memset->memcpy forwarding with undef tail"
Wed, Dec 12, 7:18 PM

Wed, Dec 5

dlj committed rL348426: Revert r347934 "[SCEV] Guard movement of insertion point for loop-invariants".
Revert r347934 "[SCEV] Guard movement of insertion point for loop-invariants"
Wed, Dec 5, 3:18 PM

Nov 16 2018

dlj committed rC347133: Fix unused variable warning..
Fix unused variable warning.
Nov 16 2018, 8:51 PM
dlj committed rL347133: Fix unused variable warning..
Fix unused variable warning.
Nov 16 2018, 8:51 PM

Aug 17 2018

dlj accepted D50930: Move Itanium demangler implementation into a header file and add visitation support..

Looks fine for my comments.

Aug 17 2018, 5:57 PM
dlj added inline comments to D50930: Move Itanium demangler implementation into a header file and add visitation support..
Aug 17 2018, 5:20 PM

Aug 2 2018

dlj committed rL338772: [lldb] Remove unused variable..
[lldb] Remove unused variable.
Aug 2 2018, 2:45 PM
dlj committed rLLDB338772: [lldb] Remove unused variable..
[lldb] Remove unused variable.
Aug 2 2018, 2:45 PM

Jul 31 2018

dlj committed rL338448: [WebAssembly] Fix debug info tests after r338437..
[WebAssembly] Fix debug info tests after r338437.
Jul 31 2018, 3:24 PM
dlj committed rLLD338440: [lld] Fix test RUN commands so they don't fail when run in a read-only….
[lld] Fix test RUN commands so they don't fail when run in a read-only…
Jul 31 2018, 2:16 PM
dlj committed rL338440: [lld] Fix test RUN commands so they don't fail when run in a read-only….
[lld] Fix test RUN commands so they don't fail when run in a read-only…
Jul 31 2018, 2:16 PM

Jun 21 2018

dlj added an edge to rC335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.: D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates..
Jun 21 2018, 5:21 PM
dlj added an edge to rL335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.: D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates..
Jun 21 2018, 5:21 PM
dlj added 2 commit(s) for D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.: rL335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates., rC335308: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates..
Jun 21 2018, 5:21 PM

Jun 20 2018

dlj closed D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 20 2018, 12:06 AM · Restricted Project
dlj added 1 commit(s) for D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc().: rC334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 20 2018, 12:06 AM · Restricted Project
dlj added an edge to rC334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc().: D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 20 2018, 12:06 AM

Jun 18 2018

dlj committed rC334930: [ASTMatchers] Add support for matching the type of a friend decl..
[ASTMatchers] Add support for matching the type of a friend decl.
Jun 18 2018, 2:27 AM
dlj committed rL334930: [ASTMatchers] Add support for matching the type of a friend decl..
[ASTMatchers] Add support for matching the type of a friend decl.
Jun 18 2018, 2:27 AM
dlj closed D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 18 2018, 2:27 AM · Restricted Project
dlj committed rC334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
[ASTMatchers] Don't assert-fail in specifiesTypeLoc().
Jun 18 2018, 2:07 AM
dlj added a comment to D48242: [ASTMatchers] Add support for matching the type of a friend decl..

Ping for Manuel...

Jun 18 2018, 2:04 AM · Restricted Project
dlj committed rL334929: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
[ASTMatchers] Don't assert-fail in specifiesTypeLoc().
Jun 18 2018, 2:03 AM
dlj created D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc()..
Jun 18 2018, 1:42 AM · Restricted Project

Jun 15 2018

dlj added inline comments to D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 15 2018, 5:21 PM · Restricted Project
dlj updated the diff for D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 15 2018, 5:21 PM · Restricted Project
dlj created D48242: [ASTMatchers] Add support for matching the type of a friend decl..
Jun 15 2018, 3:14 PM · Restricted Project

Jun 14 2018

dlj committed rC334801: [Format] Do not use a global static value for EOF within ScopedMacroState..
[Format] Do not use a global static value for EOF within ScopedMacroState.
Jun 14 2018, 11:13 PM
dlj committed rL334801: [Format] Do not use a global static value for EOF within ScopedMacroState..
[Format] Do not use a global static value for EOF within ScopedMacroState.
Jun 14 2018, 11:13 PM
dlj closed D47759: [Format] Do not use a global static value for EOF within ScopedMacroState..
Jun 14 2018, 11:13 PM · Restricted Project
dlj added a comment to D47759: [Format] Do not use a global static value for EOF within ScopedMacroState..

Ping...

Jun 14 2018, 3:32 PM · Restricted Project

Jun 11 2018

dlj accepted rLLD334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance..

This was reviewed by ruiu in https://reviews.llvm.org/D47975.

Jun 11 2018, 1:34 PM
dlj accepted rL334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance..

This was reviewed by ruiu in https://reviews.llvm.org/D47975.

Jun 11 2018, 1:34 PM
dlj added 2 commit(s) for D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance.: rLLD334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance., rL334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 1:30 PM
dlj added an edge to rL334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance.: D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 1:30 PM
dlj added an edge to rLLD334432: [ELF] Fix copy relocation when two symbols share the same Symbol instance.: D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 1:30 PM

Jun 4 2018

dlj created D47759: [Format] Do not use a global static value for EOF within ScopedMacroState..
Jun 4 2018, 8:42 PM · Restricted Project

May 7 2018

dlj committed rL331733: Tag release branches/google/stable as tags/google/stable/2018-04-24.
Tag release branches/google/stable as tags/google/stable/2018-04-24
May 7 2018, 9:17 PM
dlj committed rL331732: Cherry-pick @=r331237 to google/stable for 2018-04-24.
Cherry-pick @=r331237 to google/stable for 2018-04-24
May 7 2018, 9:17 PM
dlj committed rL331731: Cherry-pick @=r331041 to google/stable for 2018-04-24.
Cherry-pick @=r331041 to google/stable for 2018-04-24
May 7 2018, 9:16 PM
dlj committed rL331730: Cherry-pick @=r330997 to google/stable for 2018-04-24.
Cherry-pick @=r330997 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331729: Cherry-pick @=r330951 to google/stable for 2018-04-24.
Cherry-pick @=r330951 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331728: Cherry-pick @=r330950 to google/stable for 2018-04-24.
Cherry-pick @=r330950 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331727: Cherry-pick @=r330947 to google/stable for 2018-04-24.
Cherry-pick @=r330947 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331726: Cherry-pick @=r330893 to google/stable for 2018-04-24.
Cherry-pick @=r330893 to google/stable for 2018-04-24
May 7 2018, 9:15 PM
dlj committed rL331725: Release 2018-04-24 for google/stable @r330764.
Release 2018-04-24 for google/stable @r330764
May 7 2018, 9:14 PM
dlj committed rL331720: Release 2018-04-24 for google/stable @r330864.
Release 2018-04-24 for google/stable @r330864
May 7 2018, 8:41 PM
dlj committed rL331724: Tag release branches/google/stable as tags/google/stable/2018-04-24.
Tag release branches/google/stable as tags/google/stable/2018-04-24
May 7 2018, 8:30 PM
dlj committed rL331723: Release 2018-04-24 for google/stable @r330764.
Release 2018-04-24 for google/stable @r330764
May 7 2018, 8:29 PM

May 1 2018

dlj committed rT331314: [test-suite] Fix UB in initialization code for stepanov_container..
[test-suite] Fix UB in initialization code for stepanov_container.
May 1 2018, 3:30 PM
dlj committed rL331314: [test-suite] Fix UB in initialization code for stepanov_container..
[test-suite] Fix UB in initialization code for stepanov_container.
May 1 2018, 3:29 PM

Mar 5 2018

dlj added a parent revision for D44123: [AST] Enhance comment accessing interface. (NFC): D44122: [AST] Factor out RawComment lookup and caching. (NFC).
Mar 5 2018, 3:41 PM · Restricted Project
dlj added a child revision for D44122: [AST] Factor out RawComment lookup and caching. (NFC): D44123: [AST] Enhance comment accessing interface. (NFC).
Mar 5 2018, 3:41 PM · Restricted Project
dlj created D44123: [AST] Enhance comment accessing interface. (NFC).
Mar 5 2018, 3:40 PM · Restricted Project
dlj updated the summary of D44122: [AST] Factor out RawComment lookup and caching. (NFC).
Mar 5 2018, 3:38 PM · Restricted Project
dlj created D44122: [AST] Factor out RawComment lookup and caching. (NFC).
Mar 5 2018, 3:37 PM · Restricted Project

Mar 1 2018

dlj committed rL326512: [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying….
[NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying…
Mar 1 2018, 4:11 PM
dlj committed rC326512: [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying….
[NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying…
Mar 1 2018, 4:11 PM
dlj added a comment to rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it..

This was re-committed:
https://reviews.llvm.org/rL326512

Mar 1 2018, 4:11 PM
dlj added a comment to rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it..

For the curious, this was reverted:
https://reviews.llvm.org/rL326508

Mar 1 2018, 3:20 PM
dlj committed rC326508: Revert r326501 due to buildbot breakage..
Revert r326501 due to buildbot breakage.
Mar 1 2018, 3:16 PM
dlj committed rL326508: Revert r326501 due to buildbot breakage..
Revert r326501 due to buildbot breakage.
Mar 1 2018, 3:16 PM
dlj committed rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it..
[NFC] Move CommentOpts checks to the call sites that depend on it.
Mar 1 2018, 2:46 PM
dlj committed rC326501: [NFC] Move CommentOpts checks to the call sites that depend on it..
[NFC] Move CommentOpts checks to the call sites that depend on it.
Mar 1 2018, 2:46 PM
dlj closed D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Mar 1 2018, 2:46 PM

Feb 26 2018

dlj created D43800: [ASTMatchers] Allow file-based narrowing matches to work with NestedNameSpecifierLocs..
Feb 26 2018, 6:59 PM

Feb 22 2018

dlj updated the summary of D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Feb 22 2018, 5:35 PM
dlj updated the summary of D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Feb 22 2018, 5:35 PM
dlj created D43663: [NFC] Move CommentOpts checks to the call sites that depend on it..
Feb 22 2018, 5:31 PM

Jan 11 2018

dlj committed rL322335: Revert r322279 due to Skylake miscompile..
Revert r322279 due to Skylake miscompile.
Jan 11 2018, 4:19 PM
dlj closed D41972: Revert r322279 due to Skylake miscompile..
Jan 11 2018, 4:19 PM
dlj created D41972: Revert r322279 due to Skylake miscompile..
Jan 11 2018, 4:16 PM

Nov 14 2017

dlj committed rL318249: Creating branches/google/stable and tags/google/stable/ from r317716.
Creating branches/google/stable and tags/google/stable/ from r317716
Nov 14 2017, 5:46 PM

Nov 9 2017

dlj committed rL317856: Creating branches/google/testing and tags/google/testing/ from r317203.
Creating branches/google/testing and tags/google/testing/ from r317203
Nov 9 2017, 5:52 PM
dlj committed rL317857: Cherry-pick r317444 to google/testing..
Cherry-pick r317444 to google/testing.
Nov 9 2017, 5:16 PM

Nov 8 2017

dlj committed rL317716: Add a missing "REQUIRES: system-windows" to a Windows-only test..
Add a missing "REQUIRES: system-windows" to a Windows-only test.
Nov 8 2017, 12:03 PM

Nov 6 2017

dlj created P8045 ASAN and -fdebug-pass-manager for PR35210.
Nov 6 2017, 6:11 PM

Nov 5 2017

dlj committed rL317444: [PassManager, SimplifyCFG] Revert r316908 and r316869..
[PassManager, SimplifyCFG] Revert r316908 and r316869.
Nov 5 2017, 4:32 PM
dlj edited P8043 Crasher - r316869.
Nov 5 2017, 1:43 PM
dlj created P8043 Crasher - r316869.
Nov 5 2017, 1:41 PM

Oct 13 2017

dlj requested changes to D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..

Hmm, looking more at this change... while it does make the behaviour consistent for Forward and Input iterators, I think it's just making them both do the wrong thing.

Oct 13 2017, 5:06 PM

Oct 12 2017

dlj accepted D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back..
Oct 12 2017, 9:49 AM

Sep 20 2017

dlj committed rL313854: [lit/Win] Check if a path was found before attempting to use it..
[lit/Win] Check if a path was found before attempting to use it.
Sep 20 2017, 6:28 PM
dlj closed D38115: [lit/Win] Check if a path was found before attempting to use it. by committing rL313854: [lit/Win] Check if a path was found before attempting to use it..
Sep 20 2017, 6:27 PM
dlj created D38115: [lit/Win] Check if a path was found before attempting to use it..
Sep 20 2017, 6:26 PM

Sep 19 2017

dlj created D38059: Rename list::base to list::__base..
Sep 19 2017, 4:16 PM

Sep 18 2017

dlj added inline comments to D37944: [lit] Move some of LLD and Clang's configuration code into LLVM shared configuration.
Sep 18 2017, 10:20 PM
dlj added a comment to D38016: [lit] Make lit stop writing .pyc files.
In D38016#874699, @dlj wrote:

Would it make more sense to set this as an SVN property?

http://svnbook.red-bean.com/nightly/en/svn.advanced.props.special.ignore.html

svn propset svn:global-ignores . '*.pyc'

(Or as svn:ignore on the lit directories)

I actually did set svn:ignore on the lit directory and it didn't work. It's kind of hard diagnosing this kind of thing because I can't physically see it reproducing so all I can do is hit it with as big of a hammer as possible. I guess I can wait and see if it happens again on another bot the next time I check something in, and if so I can try to get one of the bot owners to help me investigate.

Sep 18 2017, 8:51 PM
dlj accepted D38016: [lit] Make lit stop writing .pyc files.
Sep 18 2017, 8:51 PM
dlj accepted D37946: [lit] Fix some Python 3 compatibility issues..
Sep 18 2017, 8:17 PM
dlj added a comment to D38016: [lit] Make lit stop writing .pyc files.

Would it make more sense to set this as an SVN property?

Sep 18 2017, 8:10 PM
dlj added a comment to D38015: [lit] Use inodes instead of realpaths in the config map.

I think the previous logic should have yielded a fairly stable identifier... do you have an example off-hand of a case that fails?

Sep 18 2017, 8:03 PM
dlj added inline comments to D37946: [lit] Fix some Python 3 compatibility issues..
Sep 18 2017, 4:17 PM

Sep 14 2017

dlj added a comment to D37538: [libc++] Remove problematic ADL in container implementations..

@dlj I went ahead and committed the fixes to std::allocator_traits in r313324, because I think we agree those are bugs, and I didn't want this discussion to hold up that fix. I hope you don't mind.

Sep 14 2017, 6:26 PM
dlj accepted D37778: [lit] Add a shared llvm configuration library, and use it in llvm.
Sep 14 2017, 5:34 PM
dlj accepted D37838: [lit] Allow lit config files to have a .py extension.
In D37838#870412, @rnk wrote:
In D37838#870368, @rnk wrote:

lit.cfg.py still isn't a valid name for a python module. I had this idea that in the future we'd import the config module directly to simplify custom test formats defined in lit configuration files, which interact badly with multiprocessing.Pool. I guess that won't work well anyway since all the config files will have the same name, so we still have to move custom test formats out into well-named python modules.

Could we work around this by using __import__ or something or searching for a module loader with a given path, and just assigning a dynamically generated name to the module? Not trying to do anything like that with this patch by the way.

I think we could do something crazy like that.

If it makes things simpler, I could call it lit_cfg.py?

It probably won't make the import stuff simpler, so leaving it as lit.cfg.py seems more consistent with our current lit.site.cfg naming.

Sep 14 2017, 2:46 PM

Sep 13 2017

dlj updated the diff for D37538: [libc++] Remove problematic ADL in container implementations..
  • Remove deque from the test for now.
Sep 13 2017, 10:12 PM
dlj updated the diff for D37538: [libc++] Remove problematic ADL in container implementations..
  • Remove deque from the test for now.
Sep 13 2017, 10:11 PM
dlj added inline comments to D37538: [libc++] Remove problematic ADL in container implementations..
Sep 13 2017, 10:08 PM
dlj accepted D37756: [lit] Force site configs to be run before source-tree configs.

I did have a couple of remaining formatting suggestions:
https://reviews.llvm.org/D37756#868958

Sep 13 2017, 2:58 PM