Page MenuHomePhabricator

dlj (David L. Jones)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2016, 10:48 AM (199 w, 4 d)
Roles
Administrator

Recent Activity

Wed, Dec 4

dlj committed rG93cc9dddd82f: Revert "Properly convert all declaration non-type template arguments when" (authored by dlj).
Revert "Properly convert all declaration non-type template arguments when"
Wed, Dec 4, 10:35 PM
dlj added a reverting change for rG11d10527852b: Properly convert all declaration non-type template arguments when forming non…: rG93cc9dddd82f: Revert "Properly convert all declaration non-type template arguments when".
Wed, Dec 4, 10:35 PM

Oct 31 2019

dlj accepted D69020: Illustrate a redirector using the example of round function from math.h..
Oct 31 2019, 1:10 PM · Restricted Project

Oct 15 2019

dlj committed rGa3378063ff6c: Fix an unused variable introduced in rL374955 / rG21703543. (authored by dlj).
Fix an unused variable introduced in rL374955 / rG21703543.
Oct 15 2019, 5:54 PM
dlj committed rL374961: Fix an unused variable introduced in rL374955 / rG21703543..
Fix an unused variable introduced in rL374955 / rG21703543.
Oct 15 2019, 5:54 PM

Oct 14 2019

dlj committed rG6bfdebb412d8: Revert [SROA] Reuse existing lifetime markers if possible (authored by dlj).
Revert [SROA] Reuse existing lifetime markers if possible
Oct 14 2019, 9:36 PM
dlj committed rL374859: Revert [SROA] Reuse existing lifetime markers if possible.
Revert [SROA] Reuse existing lifetime markers if possible
Oct 14 2019, 9:36 PM

Sep 26 2019

dlj accepted D67867: [libc] Add few docs and implementation of strcpy and strcat..

Looks good for my comments.

Sep 26 2019, 4:21 PM · Restricted Project, Restricted Project
dlj added a comment to D67867: [libc] Add few docs and implementation of strcpy and strcat..

I think one directory per function is going to be annoying, not helpful. Most libc functions are expressible as a single function of less than 100 LOC. I'd suggest, instead, to have e.g. src/stdlib/strcpy.cc, implementing the strcpy function. It seems like a good rule that every file implements one public function. If additional files are needed for implementation clarity, I'd suggest to put such helper code into something like src/stdlib/internal/strcpy_internal.cpp (obviously not _actually_ for strcpy)

My choice here is driven by my preference to keep tests co-located with the implementation. Since we are in general going to have different kinds of testing like unit-testing, differential testing, fuzz-testing, I have chosen to put implementations of individual functions in their own directories. This way, the tests (which will span multiple files) will all be in a single directory and avoid clutter in the higher level directory. In the rare occasion that implementation also spans multiple files, all the implementation files will also live together.

Some tests will involve several functions from a header, e.g. flockfile+ftrylock+funlockfile. Where will you place the test, under flockfile/, or funlockfile/ ?

I prefer jyknight's proposed hierarchy.

Sep 26 2019, 11:52 AM · Restricted Project, Restricted Project

Sep 24 2019

dlj updated the diff for D67747: [utils] Add a script to upload to Phabricator..

Remove superfluous SSL context, add retries on closed connection, and attach a comment to revision updates.

Sep 24 2019, 7:34 PM · Restricted Project
dlj added a comment to D67747: [utils] Add a script to upload to Phabricator..

Alright, here's what's changed:

Sep 24 2019, 6:05 PM · Restricted Project
dlj updated the diff for D67747: [utils] Add a script to upload to Phabricator..
Sep 24 2019, 5:33 PM · Restricted Project
dlj updated the diff for D67747: [utils] Add a script to upload to Phabricator..
Sep 24 2019, 5:33 PM · Restricted Project

Sep 20 2019

dlj added a comment to D67867: [libc] Add few docs and implementation of strcpy and strcat..

After a quick once-over, I do have a few nit-picky comments. I plan to do another pass, but these are some things that were a little bit surprising up front.

Sep 20 2019, 4:41 PM · Restricted Project, Restricted Project

Sep 19 2019

dlj added a comment to D67747: [utils] Add a script to upload to Phabricator..

Why reimplement the wheel?
Does arc diff --update not work with git monorepo?

Sep 19 2019, 2:34 PM · Restricted Project

Sep 18 2019

dlj updated the diff for D67747: [utils] Add a script to upload to Phabricator..
Sep 18 2019, 9:45 PM · Restricted Project
dlj added a reviewer for D67747: [utils] Add a script to upload to Phabricator.: thakis.

A basic start! This managed to upload itself and create the differential revision.

Sep 18 2019, 9:37 PM · Restricted Project
dlj created D67747: [utils] Add a script to upload to Phabricator..
Sep 18 2019, 9:37 PM · Restricted Project
dlj retitled D67746: This is a new subcommand to git-llvm. However, almost all of it is implementedexternally. Since this will probably be useful after Subversion is turned down,it is kept mostly independent of the git/svn logic. This does mean there isslight... from This is a new subcommand to git-llvm. However, almost all of it is implemented externally. Since this will probably be useful after Subversion is turned down, it is kept mostly independent of the git/svn logic. This does mean there is slight... to This is a new subcommand to git-llvm. However, almost all of it is implementedexternally. Since this will probably be useful after Subversion is turned down,it is kept mostly independent of the git/svn logic. This does mean there isslight....
Sep 18 2019, 9:34 PM · Restricted Project
dlj abandoned D67746: This is a new subcommand to git-llvm. However, almost all of it is implementedexternally. Since this will probably be useful after Subversion is turned down,it is kept mostly independent of the git/svn logic. This does mean there isslight....
Sep 18 2019, 9:34 PM · Restricted Project
dlj created D67746: This is a new subcommand to git-llvm. However, almost all of it is implementedexternally. Since this will probably be useful after Subversion is turned down,it is kept mostly independent of the git/svn logic. This does mean there isslight....
Sep 18 2019, 9:33 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 9:13 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 9:10 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 9:10 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 9:09 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 9:09 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 9:04 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 8:56 PM · Restricted Project
dlj updated the diff for D67691: Revision title.
Sep 18 2019, 8:55 PM · Restricted Project
dlj updated the diff for D67692: No-op change..

No-op update

Sep 18 2019, 11:49 AM · Restricted Project

Sep 17 2019

dlj updated subscribers of D67692: No-op change..
Sep 17 2019, 10:11 PM · Restricted Project
dlj created D67692: No-op change..
Sep 17 2019, 10:11 PM · Restricted Project
dlj updated the summary of D67691: Revision title.
Sep 17 2019, 9:21 PM · Restricted Project
dlj updated subscribers of D67691: Revision title.
Sep 17 2019, 9:06 PM · Restricted Project
dlj created D67691: Revision title.
Sep 17 2019, 9:06 PM · Restricted Project

Sep 16 2019

dlj committed rG4a249553fe9c: Add libc to path mappings in git-llvm. (authored by dlj).
Add libc to path mappings in git-llvm.
Sep 16 2019, 4:37 PM
dlj committed rL372048: Add libc to path mappings in git-llvm..
Add libc to path mappings in git-llvm.
Sep 16 2019, 4:36 PM
dlj committed rGec80f531ca45: Add a director, along with README.txt and LICENSE.txt, for libc. (authored by dlj).
Add a director, along with README.txt and LICENSE.txt, for libc.
Sep 16 2019, 2:41 PM
dlj committed rL372036: Add a director, along with README.txt and LICENSE.txt, for libc..
Add a director, along with README.txt and LICENSE.txt, for libc.
Sep 16 2019, 2:37 PM

Aug 19 2019

dlj committed rGcedd0d9a6e4b: Revert [Attributor] Fix: Make sure we set the changed flag (authored by dlj).
Revert [Attributor] Fix: Make sure we set the changed flag
Aug 19 2019, 1:06 AM
dlj committed rL369241: Revert [Attributor] Fix: Make sure we set the changed flag.
Revert [Attributor] Fix: Make sure we set the changed flag
Aug 19 2019, 12:59 AM
dlj committed rGb1752f670f3d: Revert [Attributor] Fix: Do not partially resolve returned calls. (authored by dlj).
Revert [Attributor] Fix: Do not partially resolve returned calls.
Aug 19 2019, 12:17 AM
dlj committed rL369236: Revert [Attributor] Fix: Do not partially resolve returned calls..
Revert [Attributor] Fix: Do not partially resolve returned calls.
Aug 19 2019, 12:15 AM

Aug 15 2019

dlj committed rG27954c36443d: [NewPM][PassInstrumentation] Fix test added in r369024. (authored by dlj).
[NewPM][PassInstrumentation] Fix test added in r369024.
Aug 15 2019, 4:26 PM
dlj committed rL369066: [NewPM][PassInstrumentation] Fix test added in r369024..
[NewPM][PassInstrumentation] Fix test added in r369024.
Aug 15 2019, 4:26 PM

Aug 14 2019

dlj committed rG4ed5521cad79: [Tooling] Add a hack to work around issues with matcher binding in r368681. (authored by dlj).
[Tooling] Add a hack to work around issues with matcher binding in r368681.
Aug 14 2019, 9:13 PM
dlj committed rL368958: [Tooling] Add a hack to work around issues with matcher binding in r368681..
[Tooling] Add a hack to work around issues with matcher binding in r368681.
Aug 14 2019, 9:13 PM
dlj closed D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681..
Aug 14 2019, 9:12 PM · Restricted Project, Restricted Project
dlj created D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681..
Aug 14 2019, 9:04 PM · Restricted Project, Restricted Project

Aug 13 2019

dlj committed rGd4edd9d97e4e: Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM' (authored by dlj).
Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM'
Aug 13 2019, 9:54 PM
dlj added a comment to rL368542: Fix pass dependency for LICM.

FYI: reverted in r368800.

Aug 13 2019, 9:54 PM
dlj added a comment to rL368526: [LICM] Make Loop ICM profile aware.

FYI: reverted in r368800.

Aug 13 2019, 9:49 PM
dlj added a comment to D65060: [LICM] Make Loop ICM profile aware.

FYI: reverted in r368800.

Aug 13 2019, 9:49 PM · Restricted Project
dlj committed rL368800: Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM'.
Revert '[LICM] Make Loop ICM profile aware' and 'Fix pass dependency for LICM'
Aug 13 2019, 9:49 PM
dlj added a comment to rL368526: [LICM] Make Loop ICM profile aware.

This change (along with the subsequent fixes) seems to cause a stage3 clang to miscompile itself when using an FDO profile and Thin LTO (i.e., using stage2 Clang built with FDO and ThinLTO to rebuild itself yields non-deterministic output). The failure is still present past r368596, so that revision did not fix whatever issue I'm seeing.

Aug 13 2019, 9:34 PM

Aug 12 2019

dlj added inline comments to D64939: Add a proposal for a libc project under the LLVM umbrella..
Aug 12 2019, 12:41 PM · Restricted Project

Aug 8 2019

dlj added a comment to D64939: Add a proposal for a libc project under the LLVM umbrella..

(Wall of text warning... sorry!)

Aug 8 2019, 5:44 PM · Restricted Project

Jun 12 2019

dlj committed rGc73fadaa8439: Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG… (authored by dlj).
Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG…
Jun 12 2019, 7:02 PM
dlj committed rL363220: Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG….
Revert r361811: 'Re-commit r357452 (take 2): "SimplifyCFG…
Jun 12 2019, 7:01 PM

May 26 2019

dlj committed rG0ff41b8a5afb: Revert r361356: "[MIR] Add simple PRE pass to MachineCSE" (authored by dlj).
Revert r361356: "[MIR] Add simple PRE pass to MachineCSE"
May 26 2019, 10:59 PM
dlj committed rL361746: Revert r361356: "[MIR] Add simple PRE pass to MachineCSE".
Revert r361356: "[MIR] Add simple PRE pass to MachineCSE"
May 26 2019, 10:57 PM

May 16 2019

dlj committed rG4a5e01faa493: [X86][AsmParser] Add mnemonics missed in r360954. (authored by dlj).
[X86][AsmParser] Add mnemonics missed in r360954.
May 16 2019, 5:18 PM
dlj committed rL360960: [X86][AsmParser] Add mnemonics missed in r360954..
[X86][AsmParser] Add mnemonics missed in r360954.
May 16 2019, 5:18 PM
dlj committed rGadd7ed228162: [X86][AsmParser] Ignore "short" even harder in Intel syntax ASM. (authored by dlj).
[X86][AsmParser] Ignore "short" even harder in Intel syntax ASM.
May 16 2019, 4:27 PM
dlj committed rG11305984d054: [X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate". (authored by dlj).
[X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate".
May 16 2019, 4:27 PM
dlj committed rL360954: [X86][AsmParser] Ignore "short" even harder in Intel syntax ASM..
[X86][AsmParser] Ignore "short" even harder in Intel syntax ASM.
May 16 2019, 4:26 PM
dlj closed D61990: [X86] Ignore "short" even harder in Intel ASM..
May 16 2019, 4:26 PM · Restricted Project
dlj committed rL360953: [X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate"..
[X86][AsmParser] Rename "ConditionCode" variable to "ConditionPredicate".
May 16 2019, 4:26 PM
dlj committed rG9adabefdcee6: [clang/test] Add missing dependency on llvm-cxxfilt. (authored by dlj).
[clang/test] Add missing dependency on llvm-cxxfilt.
May 16 2019, 2:12 PM
dlj committed rL360939: [clang/test] Add missing dependency on llvm-cxxfilt..
[clang/test] Add missing dependency on llvm-cxxfilt.
May 16 2019, 2:11 PM
dlj committed rC360939: [clang/test] Add missing dependency on llvm-cxxfilt..
[clang/test] Add missing dependency on llvm-cxxfilt.
May 16 2019, 2:11 PM

May 15 2019

dlj created D61990: [X86] Ignore "short" even harder in Intel ASM..
May 15 2019, 9:10 PM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.

Run gn format

May 15 2019, 6:56 AM · Restricted Project

May 14 2019

dlj added inline comments to D61821: gn build: add RISCV target.
May 14 2019, 8:19 AM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.
May 14 2019, 8:19 AM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.
May 14 2019, 8:18 AM · Restricted Project

May 13 2019

dlj added inline comments to D61821: gn build: add RISCV target.
May 13 2019, 9:24 PM · Restricted Project
dlj updated the diff for D61821: gn build: add RISCV target.
May 13 2019, 9:21 PM · Restricted Project
dlj committed rGfe1aec0dbb16: gn build: add Hexagon target (authored by dlj).
gn build: add Hexagon target
May 13 2019, 9:13 PM
dlj committed rL360647: gn build: add Hexagon target.
gn build: add Hexagon target
May 13 2019, 9:11 PM
dlj closed D61819: gn build: add Hexagon target.
May 13 2019, 9:11 PM · Restricted Project
dlj updated the diff for D61819: gn build: add Hexagon target.
May 13 2019, 9:11 PM · Restricted Project
dlj added a comment to D61819: gn build: add Hexagon target.

Like with the Lanai target: lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;

May 13 2019, 9:11 PM · Restricted Project
dlj added an edge to rG4fb6fcacf496: gn build: add Sparc target: D61820: gn build: add Sparc target.
May 13 2019, 9:05 PM
dlj closed D61820: gn build: add Sparc target.
May 13 2019, 9:05 PM · Restricted Project
dlj added an edge to rL360645: gn build: add Sparc target: D61820: gn build: add Sparc target.
May 13 2019, 9:05 PM
dlj added an edge to rG500a6db47951: gn build: add Lanai target: D61818: gn build: add Lanai target.
May 13 2019, 9:05 PM
dlj added 2 commit(s) for D61820: gn build: add Sparc target: rG4fb6fcacf496: gn build: add Sparc target, rL360645: gn build: add Sparc target.
May 13 2019, 9:05 PM · Restricted Project
dlj added 2 commit(s) for D61818: gn build: add Lanai target: rG500a6db47951: gn build: add Lanai target, rL360644: gn build: add Lanai target.
May 13 2019, 9:05 PM · Restricted Project
dlj added an edge to rL360644: gn build: add Lanai target: D61818: gn build: add Lanai target.
May 13 2019, 9:05 PM
dlj closed D61818: gn build: add Lanai target.

https://reviews.llvm.org/rG500a6db47951521cbe4b3d23976aa4b790085019

May 13 2019, 9:05 PM · Restricted Project
dlj committed rG4fb6fcacf496: gn build: add Sparc target (authored by dlj).
gn build: add Sparc target
May 13 2019, 9:03 PM
dlj committed rL360645: gn build: add Sparc target.
gn build: add Sparc target
May 13 2019, 9:02 PM
dlj added inline comments to D61820: gn build: add Sparc target.
May 13 2019, 9:02 PM · Restricted Project
dlj updated the diff for D61820: gn build: add Sparc target.
May 13 2019, 9:02 PM · Restricted Project
dlj committed rG500a6db47951: gn build: add Lanai target (authored by dlj).
gn build: add Lanai target
May 13 2019, 8:52 PM
dlj committed rL360644: gn build: add Lanai target.
gn build: add Lanai target
May 13 2019, 8:52 PM
dlj added a comment to D61818: gn build: add Lanai target.

lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;

May 13 2019, 8:49 PM · Restricted Project
dlj updated the diff for D61818: gn build: add Lanai target.
May 13 2019, 8:49 PM · Restricted Project
dlj committed rG3cce23746edf: [Support] Ensure redirected outputs don't contain output from previous tests. (authored by dlj).
[Support] Ensure redirected outputs don't contain output from previous tests.
May 13 2019, 1:33 PM