Page MenuHomePhabricator

[TableGen] Add Logical operands info emission
AbandonedPublic

Authored by m4yers on Aug 16 2018, 11:22 AM.

Details

Reviewers
javed.absar
Summary

This patch is part of a bigger one D50314. It adds a possibility to emit a
logical operands info.

This feature can be used to simplify CISC machine code emission as it done in
M68K D50314 patch. You can check out M680x0MCCodeEmitter.cpp to see how it is
used. In short, it gives a "logical view" onto machine instruction operands
list, as it was defined in the tablegen files.

The main changes are in MCInstrDesc.h and InstrInfoEmitter.cpp, the rest of the
diff is just renaming for consistency sake.

Diff Detail

Event Timeline

m4yers created this revision.Aug 16 2018, 11:22 AM

The main changes are in MCInstrDesc.h and InstrInfoEmitter.cpp,
the rest of the diff is just renaming for consistency sake.

Which results in a *lot* of noise.
It would be best to further split this into the actual changes, and a follow-up "just renaming for consistency sake."

The main changes are in MCInstrDesc.h and InstrInfoEmitter.cpp,
the rest of the diff is just renaming for consistency sake.

Which results in a *lot* of noise.
It would be best to further split this into the actual changes, and a follow-up "just renaming for consistency sake."

Will do, thanks!

m4yers updated this revision to Diff 161781.Aug 21 2018, 11:38 AM

Remove noise changes

When(if?) this diff lands another will follow, renaming:

  • NumOperands -> NumMCOperands
  • OpInfo -> MCOpInfo

for consistency

@m4yers Abandon this now that the m68k target has landed?

Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2021, 10:08 AM
m4yers abandoned this revision.Mar 16 2021, 1:36 AM