Add dump() method for SourceRange

[hamzasood]

This seems like a reasonable addition. Maybe it could also provide print and printToString to more closely match the SourceLocation API?

[steveire]

Add dump() and supporting methods to SourceRange

[steveire]

Thanks, I've done that now.

[a_sidorin]

Hello Stephen,
These methods will be really useful.

lib/Basic/SourceLocation.cpp

90

I think we should print both locations on the same line, without adding a newline after the start SLoc.

92

print() shouldn't add a newline, it is up to dump() methods.

[rsmith]

lib/Basic/SourceLocation.cpp

89–93

It would seem somewhat more natural to dump SourceRanges the same way we dump them in -ast-dump. (That is: use angle brackets, no newline, and omit the file name / line number / column number on the end location if it's the same as on the start location.)

[steveire]

Add dump() and supporting methods to SourceRange

[steveire]

Add dump() and supporting methods to SourceRange

[steveire]

unittests/Basic/SourceManagerTest.cpp

189 ↗

(On Diff #162282)

I don't know how to resolve this TODO, and somehow test a range between two files.

include/clang/Basic/SourceLocation.h

public:
 
   bool operator==(const SourceRange &X) const {
     return B == X.B && E == X.E;
   }
 
   bool operator!=(const SourceRange &X) const {
     return B != X.B || E != X.E;
   }
+
+  void dump(const SourceManager &SM) const;
 };
 
 /// Represents a character-granular source range.
 ///
 /// The underlying SourceRange can either specify the starting/ending character
 /// of the range, or it can specify the start of the range and the start of the
 /// last token of the range (a "token range").  In the token range case, the
 /// size of the last token must be measured to determine the actual end of the

lib/Basic/SourceLocation.cpp

SourceLocation::printToString(const SourceManager &SM) const {
   return OS.str();
 }
 
 LLVM_DUMP_METHOD void SourceLocation::dump(const SourceManager &SM) const {
   print(llvm::errs(), SM);
   llvm::errs() << '\n';
 }
 
+LLVM_DUMP_METHOD void SourceRange::dump(const SourceManager &SM) const {
+  llvm::errs() << '[';
+  B.print(llvm::errs(), SM);
+  llvm::errs() << ",\n ";
+  E.print(llvm::errs(), SM);
+  llvm::errs() << "]\n";
+}
+
 //===----------------------------------------------------------------------===//
 // FullSourceLoc
 //===----------------------------------------------------------------------===//
 
 FileID FullSourceLoc::getFileID() const {
   assert(isValid());
   return SrcMgr->getFileID(*this);
 }
 
 FullSourceLoc FullSourceLoc::getExpansionLoc() const {
   assert(isValid());