This is an archive of the discontinued LLVM Phabricator instance.

Differential D50635

Fix lint tests for D50449
ClosedPublic

Authored by kadircet on Aug 13 2018, 7:09 AM.

Details

Reviewers
ilya-biryukov
hokein
Commits
rGd4218dcd7985: Fix lint tests for D50449
rCTE339572: Fix lint tests for D50449
rL339572: Fix lint tests for D50449

Diff Detail

Event Timeline

kadircet created this revision.Aug 13 2018, 7:09 AM
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric. · View Herald TranscriptAug 13 2018, 7:09 AM
Harbormaster completed remote builds in B21388: Diff 160350.Aug 13 2018, 7:09 AM
hokein accepted this revision.Aug 13 2018, 7:30 AM
hokein added a subscriber: hokein.

LGTM.

This revision is now accepted and ready to land.Aug 13 2018, 7:30 AM
Closed by commit rL339572: Fix lint tests for D50449 (authored by kadircet). · Explain WhyAug 13 2018, 7:32 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 13 2018, 7:32 AM

Revision Contents

PathSize
test/
clangd/
13 lines
26 lines

Diff 160350

test/clangd/completion-snippets.test

Show All 28 Lines
# CHECK-NEXT: "isIncomplete": {{.*}} # CHECK-NEXT: "isIncomplete": {{.*}}
# CHECK-NEXT: "items": [ # CHECK-NEXT: "items": [
# CHECK: "filterText": "func_with_args", # CHECK: "filterText": "func_with_args",
# CHECK-NEXT: "insertText": "func_with_args(${1:int a}, ${2:int b})", # CHECK-NEXT: "insertText": "func_with_args(${1:int a}, ${2:int b})",
# CHECK-NEXT: "insertTextFormat": 2, # CHECK-NEXT: "insertTextFormat": 2,
# CHECK-NEXT: "kind": 3, # CHECK-NEXT: "kind": 3,
# CHECK-NEXT: "label": " func_with_args(int a, int b)", # CHECK-NEXT: "label": " func_with_args(int a, int b)",
# CHECK-NEXT: "sortText": "{{.*}}func_with_args" # CHECK-NEXT: "sortText": "{{.*}}func_with_args"
# CHECK-NEXT: "textEdit": {
# CHECK-NEXT: "newText": "func_with_args(${1:int a}, ${2:int b})",
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
# CHECK-NEXT: "character": 7,
# CHECK-NEXT: "line": 2
# CHECK-NEXT: }
# CHECK-NEXT: "start": {
# CHECK-NEXT: "character": 0,
# CHECK-NEXT: "line": 2
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: ] # CHECK-NEXT: ]
# CHECK-NEXT: } # CHECK-NEXT: }
--- ---
{"jsonrpc":"2.0","id":4,"method":"shutdown"} {"jsonrpc":"2.0","id":4,"method":"shutdown"}

test/clangd/completion.test

Show All 12 Lines
# CHECK-NEXT: { # CHECK-NEXT: {
# CHECK-NEXT: "detail": "int", # CHECK-NEXT: "detail": "int",
# CHECK-NEXT: "filterText": "a", # CHECK-NEXT: "filterText": "a",
# CHECK-NEXT: "insertText": "a", # CHECK-NEXT: "insertText": "a",
# CHECK-NEXT: "insertTextFormat": 1, # CHECK-NEXT: "insertTextFormat": 1,
# CHECK-NEXT: "kind": 5, # CHECK-NEXT: "kind": 5,
# CHECK-NEXT: "label": " a", # CHECK-NEXT: "label": " a",
# CHECK-NEXT: "sortText": "{{.*}}a" # CHECK-NEXT: "sortText": "{{.*}}a"
# CHECK-NEXT: "textEdit": {
# CHECK-NEXT: "newText": "a",
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
# CHECK-NEXT: "character": 4,
# CHECK-NEXT: "line": 2
# CHECK-NEXT: }
# CHECK-NEXT: "start": {
# CHECK-NEXT: "character": 4,
# CHECK-NEXT: "line": 2
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: ] # CHECK-NEXT: ]
--- ---
# Update the source file and check for completions again. # Update the source file and check for completions again.
{"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"test:///main.cpp","version":2},"contentChanges":[{"text":"struct S { int b; };\nint main() {\nS().\n}"}]}} {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"test:///main.cpp","version":2},"contentChanges":[{"text":"struct S { int b; };\nint main() {\nS().\n}"}]}}
--- ---
{"jsonrpc":"2.0","id":3,"method":"textDocument/completion","params":{"textDocument":{"uri":"test:///main.cpp"},"position":{"line":2,"character":4}}} {"jsonrpc":"2.0","id":3,"method":"textDocument/completion","params":{"textDocument":{"uri":"test:///main.cpp"},"position":{"line":2,"character":4}}}
# CHECK: "id": 3, # CHECK: "id": 3,
# CHECK-NEXT: "jsonrpc": "2.0", # CHECK-NEXT: "jsonrpc": "2.0",
# CHECK-NEXT: "result": { # CHECK-NEXT: "result": {
# CHECK-NEXT: "isIncomplete": false, # CHECK-NEXT: "isIncomplete": false,
# CHECK-NEXT: "items": [ # CHECK-NEXT: "items": [
# CHECK-NEXT: { # CHECK-NEXT: {
# CHECK-NEXT: "detail": "int", # CHECK-NEXT: "detail": "int",
# CHECK-NEXT: "filterText": "b", # CHECK-NEXT: "filterText": "b",
# CHECK-NEXT: "insertText": "b", # CHECK-NEXT: "insertText": "b",
# CHECK-NEXT: "insertTextFormat": 1, # CHECK-NEXT: "insertTextFormat": 1,
# CHECK-NEXT: "kind": 5, # CHECK-NEXT: "kind": 5,
# CHECK-NEXT: "label": " b", # CHECK-NEXT: "label": " b",
# CHECK-NEXT: "sortText": "{{.*}}b" # CHECK-NEXT: "sortText": "{{.*}}b"
# CHECK-NEXT: "textEdit": {
# CHECK-NEXT: "newText": "b",
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
# CHECK-NEXT: "character": 4,
# CHECK-NEXT: "line": 2
# CHECK-NEXT: }
# CHECK-NEXT: "start": {
# CHECK-NEXT: "character": 4,
# CHECK-NEXT: "line": 2
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: ] # CHECK-NEXT: ]
--- ---
{"jsonrpc":"2.0","id":4,"method":"shutdown"} {"jsonrpc":"2.0","id":4,"method":"shutdown"}