Page MenuHomePhabricator

[MIPS GlobalISel] Select global address
ClosedPublic

Authored by Petar.Avramovic on Jul 25 2018, 8:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

atanasyan accepted this revision.Jul 31 2018, 6:41 AM

LGTM with a nit.

lib/Target/Mips/MipsInstructionSelector.cpp
170 ↗(On Diff #157281)

I suggest to use an early-return:

if (MF.getTarget().isPositionIndependent())
  return false;
This revision is now accepted and ready to land.Jul 31 2018, 6:41 AM

Addressed review comments.

Petar.Avramovic marked an inline comment as done.Jul 31 2018, 8:46 AM
This revision was automatically updated to reflect the committed changes.