Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- rC Clang
Event Timeline
This comment was removed by kallisti5.
Comment Actions
It seems to miss most of the interesting checks, i.e. crt files. Compare with any of the entries on netbsd.c for example.
Comment Actions
I've reworked these tests to be a lot more in-depth. Both c and c++ are passing. I plan on trying to get more of our clang / llvm patches upstream.. so this is the first step.
./bin/llvm-lit -asvv ../clang/test/Driver/haiku.c llvm-lit: /home/kallisti5/Code/llvm-project/llvm/utils/lit/lit/llvm/config.py:436: note: using clang: /home/kallisti5/Code/llvm-project/build/bin/clang PASS: Clang :: Driver/haiku.c (1 of 1) Script: -- : 'RUN: at line 1'; /home/kallisti5/Code/llvm-project/build/bin/clang -no-canonical-prefixes -target x86_64-unknown-haiku --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -### 2>&1 | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86_64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c : 'RUN: at line 4'; /home/kallisti5/Code/llvm-project/build/bin/clang -no-canonical-prefixes -target i586-pc-haiku --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -### 2>&1 | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c : 'RUN: at line 7'; /home/kallisti5/Code/llvm-project/build/bin/clang -no-canonical-prefixes -target riscv64-unknown-haiku --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -### 2>&1 | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-RV64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -- Exit Code: 0 ******************** Testing Time: 0.07s Passed: 1
./bin/llvm-lit -asvv ../clang/test/Driver/haiku.cpp llvm-lit: /home/kallisti5/Code/llvm-project/llvm/utils/lit/lit/llvm/config.py:436: note: using clang: /home/kallisti5/Code/llvm-project/build/bin/clang PASS: Clang :: Driver/haiku.cpp (1 of 1) Script: -- : 'RUN: at line 1'; /home/kallisti5/Code/llvm-project/build/bin/clang --driver-mode=g++ -no-canonical-prefixes -target i586-pc-haiku --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -### -stdlib=platform 2>&1 | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp : 'RUN: at line 4'; /home/kallisti5/Code/llvm-project/build/bin/clang --driver-mode=g++ -no-canonical-prefixes -target x86_64-unknown-haiku --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -### -stdlib=platform 2>&1 | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86_64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp : 'RUN: at line 7'; /home/kallisti5/Code/llvm-project/build/bin/clang --driver-mode=g++ -no-canonical-prefixes -target riscv64-unknown-haiku --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -### -stdlib=platform 2>&1 | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-RV64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -- Exit Code: 0 ******************** Testing Time: 0.06s Passed: 1
Comment Actions
I should mention that there are no crt checks since the Haiku toolchain driver doesn't actually look for our crt's yet.
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Haiku.cpp
vs
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/NetBSD.cpp#L239
With the change above though (adding basic_haiku_tree) i'm preparing for that in a future commit after our port is better up-streamed.