This is an archive of the discontinued LLVM Phabricator instance.

Differential D49482

Haiku: add a test for haiku driver
Needs ReviewPublic

Authored by kallisti5 on Jul 18 2018, 6:57 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Unit TestsFailed

TimeTest
80 msx64 debian > LLVM.Bindings/Go::go.test
510 msx64 debian > XRay-x86_64-linux.TestCases/Posix::basic-filtering.cpp

Event Timeline

kallisti5 created this revision.Jul 18 2018, 6:57 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptJul 18 2018, 6:57 AM
kallisti5 added a comment.Jul 18 2018, 6:58 AM
This comment was removed by kallisti5.
joerg added a subscriber: joerg.Jul 18 2018, 7:35 AM

It seems to miss most of the interesting checks, i.e. crt files. Compare with any of the entries on netbsd.c for example.

kallisti5 updated this revision to Diff 396674.Dec 30 2021, 7:43 AM

I've reworked these tests to be a lot more in-depth. Both c and c++ are passing. I plan on trying to get more of our clang / llvm patches upstream.. so this is the first step.

./bin/llvm-lit -asvv ../clang/test/Driver/haiku.c
llvm-lit: /home/kallisti5/Code/llvm-project/llvm/utils/lit/lit/llvm/config.py:436: note: using clang: /home/kallisti5/Code/llvm-project/build/bin/clang
PASS: Clang :: Driver/haiku.c (1 of 1)
Script:
--
: 'RUN: at line 1';   /home/kallisti5/Code/llvm-project/build/bin/clang -no-canonical-prefixes -target x86_64-unknown-haiku  --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -### 2>&1  | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86_64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c
: 'RUN: at line 4';   /home/kallisti5/Code/llvm-project/build/bin/clang -no-canonical-prefixes -target i586-pc-haiku  --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -### 2>&1  | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c
: 'RUN: at line 7';   /home/kallisti5/Code/llvm-project/build/bin/clang -no-canonical-prefixes -target riscv64-unknown-haiku  --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c -### 2>&1  | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-RV64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.c
--
Exit Code: 0


********************

Testing Time: 0.07s
  Passed: 1
./bin/llvm-lit -asvv ../clang/test/Driver/haiku.cpp
llvm-lit: /home/kallisti5/Code/llvm-project/llvm/utils/lit/lit/llvm/config.py:436: note: using clang: /home/kallisti5/Code/llvm-project/build/bin/clang
PASS: Clang :: Driver/haiku.cpp (1 of 1)
Script:
--
: 'RUN: at line 1';   /home/kallisti5/Code/llvm-project/build/bin/clang --driver-mode=g++ -no-canonical-prefixes -target i586-pc-haiku  --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -### -stdlib=platform 2>&1  | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp
: 'RUN: at line 4';   /home/kallisti5/Code/llvm-project/build/bin/clang --driver-mode=g++ -no-canonical-prefixes -target x86_64-unknown-haiku  --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -### -stdlib=platform 2>&1  | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-X86_64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp
: 'RUN: at line 7';   /home/kallisti5/Code/llvm-project/build/bin/clang --driver-mode=g++ -no-canonical-prefixes -target riscv64-unknown-haiku  --sysroot=/home/kallisti5/Code/llvm-project/clang/test/Driver/Inputs/basic_haiku_tree /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp -### -stdlib=platform 2>&1  | /home/kallisti5/Code/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-RV64 /home/kallisti5/Code/llvm-project/clang/test/Driver/haiku.cpp
--
Exit Code: 0


********************

Testing Time: 0.06s
  Passed: 1
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2021, 7:43 AM
Herald added subscribers: luke957, s.egerton, simoncook. · View Herald Transcript
kallisti5 added a comment.Dec 30 2021, 7:58 AM

I should mention that there are no crt checks since the Haiku toolchain driver doesn't actually look for our crt's yet.

https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Haiku.cpp
vs
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/NetBSD.cpp#L239

With the change above though (adding basic_haiku_tree) i'm preparing for that in a future commit after our port is better up-streamed.

Harbormaster completed remote builds in B141019: Diff 396674.Dec 30 2021, 8:27 AM
brad added a subscriber: brad.Mon, Nov 27, 12:57 PM

This can be closed.

Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 27, 12:57 PM
Herald added subscribers: wangpc, asb. · View Herald Transcript

Revision Contents

PathSize
clang/
test/
Driver/
Inputs/
basic_haiku_tree/
boot/
system/
develop/
headers/
lib/
lib/
18 lines
19 lines

Diff 396674

clang/test/Driver/Inputs/basic_haiku_tree/boot/system/develop/headers/.keep

  • This file was added.
This is an empty file.

clang/test/Driver/Inputs/basic_haiku_tree/boot/system/develop/lib/crti.o

  • This file was added.
This is an empty file.

clang/test/Driver/Inputs/basic_haiku_tree/boot/system/develop/lib/crtn.o

  • This file was added.
This is an empty file.

clang/test/Driver/Inputs/basic_haiku_tree/boot/system/lib/.keep

  • This file was added.
This is an empty file.

clang/test/Driver/haiku.c

  • This file was added.
// RUN: %clang -no-canonical-prefixes -target x86_64-unknown-haiku \
// RUN: --sysroot=%S/Inputs/basic_haiku_tree %s -### 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK,CHECK-X86_64 %s
// RUN: %clang -no-canonical-prefixes -target i586-pc-haiku \
// RUN: --sysroot=%S/Inputs/basic_haiku_tree %s -### 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK,CHECK-X86 %s
// RUN: %clang -no-canonical-prefixes -target riscv64-unknown-haiku \
// RUN: --sysroot=%S/Inputs/basic_haiku_tree %s -### 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK,CHECK-RV64 %s
// CHECK: {{.*}}clang{{[a-zA-Z\-]*}}" "-cc1"
// CHECK-X86: "-triple" "i586-pc-haiku"
// CHECK-X86_64: "-triple" "x86_64-unknown-haiku"
// CHECK-RV64: "-triple" "riscv64-unknown-haiku"
// CHECK: {{.*}}gcc{{[a-zA-Z\-]*}}"
// CHECK-X86: "-m32"
// CHECK-X86_64: "-m64"

clang/test/Driver/haiku.cpp

  • This file was added.
// RUN: %clangxx -no-canonical-prefixes -target i586-pc-haiku \
// RUN: --sysroot=%S/Inputs/basic_haiku_tree %s -### -stdlib=platform 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK,CHECK-X86 %s
// RUN: %clangxx -no-canonical-prefixes -target x86_64-unknown-haiku \
// RUN: --sysroot=%S/Inputs/basic_haiku_tree %s -### -stdlib=platform 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK,CHECK-X86_64 %s
// RUN: %clangxx -no-canonical-prefixes -target riscv64-unknown-haiku \
// RUN: --sysroot=%S/Inputs/basic_haiku_tree %s -### -stdlib=platform 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK,CHECK-RV64 %s
// CHECK: {{.*}}clang{{[a-zA-Z\-]*}}" "-cc1"
// CHECK-X86: "-triple" "i586-pc-haiku"
// CHECK-X86_64: "-triple" "x86_64-unknown-haiku"
// CHECK-RV64: "-triple" "riscv64-unknown-haiku"
// CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK: {{.*}}g++{{[a-zA-Z\-]*}}"
// CHECK-X86: "-m32"
// CHECK-X86_64: "-m64"