This is an archive of the discontinued LLVM Phabricator instance.

DAG: Add calling convention argument to calling convention funcs
ClosedPublic

Authored by arsenm on Jul 12 2018, 1:41 AM.

Details

Summary

This seems like a pretty glaring omission, and AMDGPU
wants to treat kernels differently from other calling
convention.

Diff Detail

Event Timeline

arsenm created this revision.Jul 12 2018, 1:41 AM
nhaehnle accepted this revision.Jul 27 2018, 6:11 AM

This makes sense to me. One nit-pick, apart from that LGTM.

lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
96–97

This looks like clang-format would complain about it. Probably in some other places as well.

This revision is now accepted and ready to land.Jul 27 2018, 6:11 AM
arsenm closed this revision.Jul 28 2018, 6:25 AM

r338194