This seems like a pretty glaring omission, and AMDGPU
wants to treat kernels differently from other calling
convention.
Details
Details
- Reviewers
bogner sdardis javed.absar nhaehnle
Diff Detail
Diff Detail
Event Timeline
Comment Actions
This makes sense to me. One nit-pick, apart from that LGTM.
lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp | ||
---|---|---|
96–97 | This looks like clang-format would complain about it. Probably in some other places as well. |
This looks like clang-format would complain about it. Probably in some other places as well.