Page MenuHomePhabricator

[LoopInfo] Port loop exit interfaces from Loop to LoopBase

Authored by dcaballe on Jul 1 2018, 10:29 PM.



This patch ports hasDedicatedExits, getUniqueExitBlocks and
getUniqueExitBlock in Loop to LoopBase so that they can be used
from other LoopBase sub-classes. GraphTraits are used to replace the
BasicBlock specific code in the original implementation. These
three interfaces are needed in VPLoop (VPlan).

Diff Detail


Event Timeline

dcaballe created this revision.Jul 1 2018, 10:29 PM
chandlerc requested changes to this revision.Jul 6 2018, 6:50 PM

Minor cleanups, and then this should be good.

BTW, do you have commit access?

85–86 ↗(On Diff #153669)

Delete - this is a stale doxygen commment, and the API is documented in the header.

101–104 ↗(On Diff #153669)

Delete, same as above.

150–151 ↗(On Diff #153669)

Delete, same as above.

This revision now requires changes to proceed.Jul 6 2018, 6:50 PM
dcaballe updated this revision to Diff 154478.Jul 6 2018, 7:11 PM

Addressing Chandler's comments. Thanks, Chandler!
Yes, I have commit access.

This revision is now accepted and ready to land.Jul 6 2018, 7:13 PM
This revision was automatically updated to reflect the committed changes.