Page MenuHomePhabricator

sguggill (Satish K Guggilla)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2017, 4:44 PM (99 w, 5 d)

Recent Activity

Mar 28 2019

sguggill added inline comments to D59952: [VPLAN] Minor improvement to testing and debug messages..
Mar 28 2019, 12:51 PM · Restricted Project

Jan 18 2019

sguggill added a comment to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Thanks Florian. I will request Hideki Saito to commit the change.

Jan 18 2019, 2:53 PM
sguggill updated the diff for D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Added checks for the operands of OR in the predicator test.

Jan 18 2019, 2:51 PM

Jan 11 2019

sguggill updated the diff for D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Removed default case when checking for edge type and added a test checking generation of not and or during predication.

Jan 11 2019, 6:56 PM

Dec 14 2018

sguggill added inline comments to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Dec 14 2018, 6:37 PM
sguggill updated the diff for D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Dec 14 2018, 6:37 PM
sguggill added inline comments to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Dec 14 2018, 5:40 PM
sguggill updated the diff for D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Thanks for the review Florian. I am addressing your comments.

Dec 14 2018, 5:40 PM

Dec 13 2018

sguggill added a comment to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Right, I'm happy with the patch and will let @fhahn do the final review and approval. Thanks!

Dec 13 2018, 10:24 AM

Dec 12 2018

sguggill added inline comments to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Dec 12 2018, 5:46 PM
sguggill updated the diff for D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Address Renato's comments.

Dec 12 2018, 5:43 PM

Dec 11 2018

sguggill added a comment to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

ping

Dec 11 2018, 9:50 PM

Nov 14 2018

sguggill added a comment to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

ping

Nov 14 2018, 11:49 AM

Oct 19 2018

sguggill updated the diff for D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..

Address Florian's review comments.

Oct 19 2018, 5:34 PM
sguggill added inline comments to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Oct 19 2018, 2:49 PM
sguggill added inline comments to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Oct 19 2018, 2:00 PM

Oct 16 2018

sguggill added inline comments to D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Oct 16 2018, 4:25 PM
sguggill created D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path..
Oct 16 2018, 4:21 PM

Sep 11 2018

sguggill added a comment to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

I have requested Hideki Saito to submit this change on my behalf.

Sep 11 2018, 3:49 PM
sguggill added inline comments to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Sep 11 2018, 3:47 PM
sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Addressing Robin's comment.

Sep 11 2018, 3:46 PM

Sep 6 2018

sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Florian, I have made the suggested test case changes and uploaded the same. Please take a look.

Sep 6 2018, 5:08 PM

Sep 5 2018

sguggill added a comment to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

LGTM with some more nits to the test cases. The EnableVPlanNativePath sprinkled around are not ideal, but I don't think there is a better alternative and we should be able to get rid of them as we go along. Please wait a few days with submitting this, to give other people a change to raise any additional concerns.

Sep 5 2018, 10:01 AM

Sep 4 2018

sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Rebased my changes.

Sep 4 2018, 4:20 PM

Aug 30 2018

sguggill added inline comments to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Aug 30 2018, 5:22 PM
sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Aug 30 2018, 5:20 PM
sguggill added inline comments to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Aug 30 2018, 4:48 PM
sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Addressing latest comments from Florian.

Aug 30 2018, 4:33 PM

Aug 27 2018

sguggill added a comment to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Ping.

Aug 27 2018, 10:13 AM

Aug 17 2018

sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Minor formatting changes.

Aug 17 2018, 9:25 AM

Aug 16 2018

sguggill updated the diff for D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Addressed initial comments from Florian.

Aug 16 2018, 11:16 PM
sguggill added inline comments to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Aug 16 2018, 10:33 PM
sguggill added a comment to D50820: [VPlan] Implement initial vector code generation support for simple outer loops..

Great to see this. I've left a few small comments after a first pass and will take a closer look in the next few days!

Aug 16 2018, 10:28 PM

Aug 15 2018

sguggill updated the summary of D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Aug 15 2018, 4:54 PM
sguggill created D50820: [VPlan] Implement initial vector code generation support for simple outer loops..
Aug 15 2018, 4:42 PM

Jun 15 2018

sguggill added a comment to D46827: [VPlan] Add VPInstruction to VPRecipe transformation..

The changes look good to me. I have also verified that my outer loop vector code generation changes work with these changes after some minor modifications.

Jun 15 2018, 10:11 AM

Jun 14 2018

sguggill added inline comments to D46827: [VPlan] Add VPInstruction to VPRecipe transformation..
Jun 14 2018, 6:03 PM

Jun 4 2018

sguggill added a comment to D46827: [VPlan] Add VPInstruction to VPRecipe transformation..

Yep that sounds good. It sounds like I could update this patch to use a simplified recipe creation as Diego mentioned?

Jun 4 2018, 3:49 PM
sguggill added a comment to D46827: [VPlan] Add VPInstruction to VPRecipe transformation..

Sure, we can start with just creating the basic recipes. Should we only support widening for a start and not relying on the cost model at all? I suppose that would make things easier for outer loop code gen.

Jun 4 2018, 1:05 PM