Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 20242 Build 20242: arc lint + arc unit
Event Timeline
Comment Actions
So much red, so pretty!
lib/MC/MCParser/AsmParser.cpp | ||
---|---|---|
700 | This one should be renamed, since there is now only one MCAsmParserExtension for wasm, and its implementation is actually kinda ELF-y, but it is wha we'll use for wasm mode going forward. | |
lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp | ||
188 | does it make sense to keep an empty function here for wasm functionality? | |
test/CodeGen/WebAssembly/negative-base-reg.ll | ||
13 ↗ | (On Diff #153401) | this I don't understand, how does your change affect it being written to a local or the stack? |
lib/MC/MCParser/AsmParser.cpp | ||
---|---|---|
700 | Maybe a separate change? |
lib/MC/MCParser/AsmParser.cpp | ||
---|---|---|
700 | that's fine with me. |
This one should be renamed, since there is now only one MCAsmParserExtension for wasm, and its implementation is actually kinda ELF-y, but it is wha we'll use for wasm mode going forward.