This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove ELF file support.
ClosedPublic

Authored by sbc100 on Jun 28 2018, 2:36 PM.

Diff Detail

Event Timeline

sbc100 created this revision.Jun 28 2018, 2:36 PM
sbc100 updated this revision to Diff 153401.Jun 28 2018, 2:36 PM
  • fix warning

I decided to split out just the test updates: https://reviews.llvm.org/D48748

So much red, so pretty!

lib/MC/MCParser/AsmParser.cpp
700

This one should be renamed, since there is now only one MCAsmParserExtension for wasm, and its implementation is actually kinda ELF-y, but it is wha we'll use for wasm mode going forward.

lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
188

does it make sense to keep an empty function here for wasm functionality?

test/CodeGen/WebAssembly/negative-base-reg.ll
13 ↗(On Diff #153401)

this I don't understand, how does your change affect it being written to a local or the stack?

sbc100 updated this revision to Diff 153729.Jul 2 2018, 9:09 AM
  • rebase
sbc100 added inline comments.Jul 2 2018, 9:10 AM
lib/MC/MCParser/AsmParser.cpp
700

Maybe a separate change?

aardappel added inline comments.Jul 2 2018, 10:16 AM
lib/MC/MCParser/AsmParser.cpp
700

that's fine with me.

@sunfish what do you think?

sbc100 updated this revision to Diff 154923.Jul 10 2018, 8:22 PM
  • clagn-format

Anybody feeling LG'ing this?

aardappel accepted this revision.Jul 16 2018, 4:00 PM
This revision is now accepted and ready to land.Jul 16 2018, 4:00 PM
This revision was automatically updated to reflect the committed changes.
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp