This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Convert remaining tests from elf to wasm output
ClosedPublic

Authored by sbc100 on Jun 28 2018, 2:55 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 28 2018, 2:55 PM

Please take a close look. I'm not sure about negative-base-reg.ll in particular

aardappel added inline comments.Jun 28 2018, 4:16 PM
test/CodeGen/WebAssembly/negative-base-reg.ll
13 ↗(On Diff #153410)

ah, what probably happens is that this is followed by a "get_local 0" now, which this test ignores. Maybe make it into 2 CHECK-NEXT instead?

13 ↗(On Diff #153410)

I meant "set_local 0, $pop"

test/CodeGen/WebAssembly/offset-fastisel.ll
19 ↗(On Diff #153410)

same here, makes these CHECK-NEXT to ensure we're not missing things.

sbc100 updated this revision to Diff 153428.Jun 28 2018, 5:10 PM
sbc100 marked 2 inline comments as done.
  • feedback
test/CodeGen/WebAssembly/offset-fastisel.ll
19 ↗(On Diff #153410)

But don't the register names mean that even if there are instructions inbetween we are still OK? Maybe with the change you are proposing we will require more NEXTs? but i'm not sure if I should add them here are part of this change.

aardappel added inline comments.Jul 2 2018, 8:12 AM
test/CodeGen/WebAssembly/offset-fastisel.ll
19 ↗(On Diff #153410)

Yes, fine either way, as I'll have to go thru these anyway.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 2 2018, 9:08 AM
This revision was automatically updated to reflect the committed changes.