This is an archive of the discontinued LLVM Phabricator instance.

Differential D48184

[Power9] [CLANG] Add __float128 exponent GET and SET builtins
ClosedPublic

Authored by stefanp on Jun 14 2018, 11:56 AM.

Details

Reviewers
nemanjai
kbarton
hfinkel
syzaara
sfertile
lei
Commits
rG9177cf411e75: [Power9] [CLANG] Add __float128 exponent GET and SET builtins
rL342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins
rC342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins
Summary

Added

__builtin_vsx_scalar_extract_expq
__builtin_vsx_scalar_insert_exp_qp

Builtins should behave the same way as in GCC.

Diff Detail

Repository
rC Clang

Event Timeline

stefanp created this revision.Jun 14 2018, 11:56 AM
stefanp added a parent revision: D47550: [Power9] Add __float128 builtins for Round To Odd.Jun 14 2018, 12:01 PM
lei added inline comments.Jun 19 2018, 12:13 PM
include/clang/Basic/BuiltinsPPC.def
426

I think this should be Float128

nemanjai added a comment.Jul 4 2018, 6:19 AM

Perhaps my comment about the GCC documentation really belongs in this patch rather than in D48185.

nemanjai accepted this revision.Aug 13 2018, 7:28 AM

LGTM

This revision is now accepted and ready to land.Aug 13 2018, 7:28 AM
Closed by commit rC342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins (authored by stefanp). · Explain WhySep 24 2018, 11:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: cfe-commits, jsji, kristina. · View Herald TranscriptSep 24 2018, 11:16 AM

Revision Contents

PathSize
include/
clang/
Basic/
2 lines
test/
CodeGen/
12 lines

Diff 166721

include/clang/Basic/BuiltinsPPC.def

Show First 20 Lines • Show All 417 Lines • ▼ Show 20 Lines
BUILTIN(__builtin_vsx_xvtstdcsp, "V4UiV4fIi", "") BUILTIN(__builtin_vsx_xvtstdcsp, "V4UiV4fIi", "")
BUILTIN(__builtin_vsx_insertword, "V16UcV4UiV16UcIi", "") BUILTIN(__builtin_vsx_insertword, "V16UcV4UiV16UcIi", "")
BUILTIN(__builtin_vsx_extractuword, "V2ULLiV16UcIi", "") BUILTIN(__builtin_vsx_extractuword, "V2ULLiV16UcIi", "")
BUILTIN(__builtin_vsx_xxpermdi, "v.", "t") BUILTIN(__builtin_vsx_xxpermdi, "v.", "t")
BUILTIN(__builtin_vsx_xxsldwi, "v.", "t") BUILTIN(__builtin_vsx_xxsldwi, "v.", "t")
// Float 128 built-ins // Float 128 built-ins
leiUnsubmitted
Not Done
ReplyInline Actions

I think this should be Float128

lei: I think this should be `Float128`
BUILTIN(__builtin_sqrtf128_round_to_odd, "LLdLLd", "") BUILTIN(__builtin_sqrtf128_round_to_odd, "LLdLLd", "")
BUILTIN(__builtin_addf128_round_to_odd, "LLdLLdLLd", "") BUILTIN(__builtin_addf128_round_to_odd, "LLdLLdLLd", "")
BUILTIN(__builtin_subf128_round_to_odd, "LLdLLdLLd", "") BUILTIN(__builtin_subf128_round_to_odd, "LLdLLdLLd", "")
BUILTIN(__builtin_mulf128_round_to_odd, "LLdLLdLLd", "") BUILTIN(__builtin_mulf128_round_to_odd, "LLdLLdLLd", "")
BUILTIN(__builtin_divf128_round_to_odd, "LLdLLdLLd", "") BUILTIN(__builtin_divf128_round_to_odd, "LLdLLdLLd", "")
BUILTIN(__builtin_fmaf128_round_to_odd, "LLdLLdLLdLLd", "") BUILTIN(__builtin_fmaf128_round_to_odd, "LLdLLdLLdLLd", "")
BUILTIN(__builtin_truncf128_round_to_odd, "dLLd", "") BUILTIN(__builtin_truncf128_round_to_odd, "dLLd", "")
BUILTIN(__builtin_vsx_scalar_extract_expq, "ULLiLLd", "")
BUILTIN(__builtin_vsx_scalar_insert_exp_qp, "LLdLLdULLi", "")
// HTM builtins // HTM builtins
BUILTIN(__builtin_tbegin, "UiUIi", "") BUILTIN(__builtin_tbegin, "UiUIi", "")
BUILTIN(__builtin_tend, "UiUIi", "") BUILTIN(__builtin_tend, "UiUIi", "")
BUILTIN(__builtin_tabort, "UiUi", "") BUILTIN(__builtin_tabort, "UiUi", "")
BUILTIN(__builtin_tabortdc, "UiUiUiUi", "") BUILTIN(__builtin_tabortdc, "UiUiUiUi", "")
BUILTIN(__builtin_tabortdci, "UiUiUii", "") BUILTIN(__builtin_tabortdci, "UiUiUii", "")
Show All 38 Lines

test/CodeGen/builtins-ppc-p9-f128.c

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
} }
double testTruncOdd() { double testTruncOdd() {
return __builtin_truncf128_round_to_odd(A); return __builtin_truncf128_round_to_odd(A);
// CHECK: @llvm.ppc.truncf128.round.to.odd(fp128 // CHECK: @llvm.ppc.truncf128.round.to.odd(fp128
// CHECK-NEXT: ret double // CHECK-NEXT: ret double
} }
__float128 insert_exp_qp(unsigned long long int b) {
return __builtin_vsx_scalar_insert_exp_qp(A, b);
// CHECK: @llvm.ppc.scalar.insert.exp.qp(fp128 %{{.+}}, i64
// CHECK-NEXT: ret fp128
}
unsigned long long int extract_exp() {
return __builtin_vsx_scalar_extract_expq(A);
// CHECK: @llvm.ppc.scalar.extract.expq(fp128
// CHECK-NEXT: ret i64
}