This is an archive of the discontinued LLVM Phabricator instance.

[tools] Updating PPCallbacks::InclusionDirective calls
ClosedPublic

Authored by juliehockett on May 8 2018, 5:24 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

juliehockett created this revision.May 8 2018, 5:24 PM
aaron.ballman accepted this revision.May 9 2018, 10:50 AM

Aside from a minor nit, LGTM (no need for more review, you can fix the nit and commit).

clang-move/ClangMove.cpp
135 ↗(On Diff #145823)

Put FileType into comments so the parameter is unnamed like the other unused ones.

This revision is now accepted and ready to land.May 9 2018, 10:50 AM
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.