juliehockett (Julie Hockett)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2017, 3:56 PM (44 w, 1 d)

Recent Activity

Yesterday

juliehockett created D52313: [clang-doc] Avoid parsing undefined base classes.
Thu, Sep 20, 10:03 AM · Restricted Project

Wed, Sep 12

juliehockett committed rL342065: [objcopy] make objcopy follow program header standards.
[objcopy] make objcopy follow program header standards
Wed, Sep 12, 10:57 AM
juliehockett closed D51961: [objcopy] make objcopy follow program header standards.
Wed, Sep 12, 10:57 AM

Tue, Sep 11

juliehockett committed rL341955: Reland "Implement a (simple) Markdown generator".
Reland "Implement a (simple) Markdown generator"
Tue, Sep 11, 9:03 AM
juliehockett committed rCTE341955: Reland "Implement a (simple) Markdown generator".
Reland "Implement a (simple) Markdown generator"
Tue, Sep 11, 9:03 AM
juliehockett closed D43424: [clang-doc] Implement a (simple) Markdown generator.
Tue, Sep 11, 9:03 AM · Restricted Project
juliehockett closed D43424: [clang-doc] Implement a (simple) Markdown generator.
Tue, Sep 11, 9:03 AM · Restricted Project

Fri, Aug 24

juliehockett committed rCTE340620: [clang-doc] Fix memory leaks.
[clang-doc] Fix memory leaks
Fri, Aug 24, 9:44 AM
juliehockett committed rL340620: [clang-doc] Fix memory leaks.
[clang-doc] Fix memory leaks
Fri, Aug 24, 9:44 AM
juliehockett closed D51137: [clang-doc] Fix memory leaks.
Fri, Aug 24, 9:44 AM

Wed, Aug 22

juliehockett created D51137: [clang-doc] Fix memory leaks.
Wed, Aug 22, 3:48 PM

Aug 21 2018

juliehockett reopened D43424: [clang-doc] Implement a (simple) Markdown generator.

Reopening because it was reverted and I haven't had time to look into it yet

Aug 21 2018, 3:28 PM · Restricted Project

Aug 16 2018

juliehockett committed rL339966: Revert "Implement a (simple) Markdown generator".
Revert "Implement a (simple) Markdown generator"
Aug 16 2018, 4:51 PM
juliehockett committed rCTE339966: Revert "Implement a (simple) Markdown generator".
Revert "Implement a (simple) Markdown generator"
Aug 16 2018, 4:51 PM
juliehockett committed rL339948: Implement a (simple) Markdown generator.
Implement a (simple) Markdown generator
Aug 16 2018, 2:55 PM
juliehockett committed rCTE339948: Implement a (simple) Markdown generator.
Implement a (simple) Markdown generator
Aug 16 2018, 2:55 PM
juliehockett closed D43424: [clang-doc] Implement a (simple) Markdown generator.
Aug 16 2018, 2:55 PM · Restricted Project

Aug 15 2018

juliehockett committed rL339785: [clang-doc] Explicitly cast to unique_ptr.
[clang-doc] Explicitly cast to unique_ptr
Aug 15 2018, 9:19 AM
juliehockett committed rCTE339785: [clang-doc] Explicitly cast to unique_ptr.
[clang-doc] Explicitly cast to unique_ptr
Aug 15 2018, 9:19 AM
juliehockett committed rCTE339783: Reland "[clang-doc] Updating BitcodeReader to use llvm::Error"".
Reland "[clang-doc] Updating BitcodeReader to use llvm::Error""
Aug 15 2018, 9:03 AM
juliehockett committed rL339783: Reland "[clang-doc] Updating BitcodeReader to use llvm::Error"".
Reland "[clang-doc] Updating BitcodeReader to use llvm::Error""
Aug 15 2018, 9:03 AM

Aug 14 2018

juliehockett committed rCTE339685: [clang-doc] Fix unused variable.
[clang-doc] Fix unused variable
Aug 14 2018, 8:39 AM
juliehockett committed rL339685: [clang-doc] Fix unused variable.
[clang-doc] Fix unused variable
Aug 14 2018, 8:39 AM
juliehockett closed D50709: [clang-doc] Fix unused var.
Aug 14 2018, 8:39 AM · Restricted Project
juliehockett created D50709: [clang-doc] Fix unused var.
Aug 14 2018, 8:28 AM · Restricted Project

Aug 13 2018

juliehockett committed rL339620: Revert "[clang-doc] Updating BitcodeReader to use llvm::Error".
Revert "[clang-doc] Updating BitcodeReader to use llvm::Error"
Aug 13 2018, 2:52 PM
juliehockett committed rCTE339620: Revert "[clang-doc] Updating BitcodeReader to use llvm::Error".
Revert "[clang-doc] Updating BitcodeReader to use llvm::Error"
Aug 13 2018, 2:52 PM
juliehockett closed D48909: [clang-doc] Update BitcodeReader to use llvm::Error.

Closed in rL339617.

Aug 13 2018, 2:41 PM · Restricted Project
juliehockett committed rCTE339617: [clang-doc] Updating BitcodeReader to use llvm::Error.
[clang-doc] Updating BitcodeReader to use llvm::Error
Aug 13 2018, 2:39 PM
juliehockett committed rL339617: [clang-doc] Updating BitcodeReader to use llvm::Error.
[clang-doc] Updating BitcodeReader to use llvm::Error
Aug 13 2018, 2:39 PM
juliehockett closed D48908: [clang-doc] Pass over function-internal declarations.

Closed in rL339592.

Aug 13 2018, 11:08 AM · Restricted Project
juliehockett committed rL339592: [clang-doc] Pass over function-internal declarations.
[clang-doc] Pass over function-internal declarations
Aug 13 2018, 11:06 AM
juliehockett committed rCTE339592: [clang-doc] Pass over function-internal declarations.
[clang-doc] Pass over function-internal declarations
Aug 13 2018, 11:06 AM

Aug 9 2018

juliehockett added a comment to D48909: [clang-doc] Update BitcodeReader to use llvm::Error.

Should there be any tests associated with these changes?

Aug 9 2018, 2:39 PM · Restricted Project
juliehockett added inline comments to D48909: [clang-doc] Update BitcodeReader to use llvm::Error.
Aug 9 2018, 2:37 PM · Restricted Project

Aug 3 2018

juliehockett added a reviewer for D43424: [clang-doc] Implement a (simple) Markdown generator: leonardchan.
Aug 3 2018, 2:20 PM · Restricted Project
juliehockett updated the diff for D43424: [clang-doc] Implement a (simple) Markdown generator.

Updating based on recent landed patches & updated tests

Aug 3 2018, 2:20 PM · Restricted Project
juliehockett updated the diff for D48909: [clang-doc] Update BitcodeReader to use llvm::Error.
Aug 3 2018, 12:48 PM · Restricted Project
juliehockett updated the diff for D48909: [clang-doc] Update BitcodeReader to use llvm::Error.
Aug 3 2018, 12:45 PM · Restricted Project
juliehockett updated the diff for D48908: [clang-doc] Pass over function-internal declarations.

Updating tests

Aug 3 2018, 11:50 AM · Restricted Project

Aug 2 2018

juliehockett committed rL338796: [clang-doc] Fix unique_ptr error on bots.
[clang-doc] Fix unique_ptr error on bots
Aug 2 2018, 5:40 PM
juliehockett committed rCTE338796: [clang-doc] Fix unique_ptr error on bots.
[clang-doc] Fix unique_ptr error on bots
Aug 2 2018, 5:40 PM
juliehockett closed D50208: [clang-doc] Fix unique_ptr error on bots.
Aug 2 2018, 5:40 PM · Restricted Project
juliehockett updated the diff for D50208: [clang-doc] Fix unique_ptr error on bots.
Aug 2 2018, 5:27 PM · Restricted Project
juliehockett created D50208: [clang-doc] Fix unique_ptr error on bots.
Aug 2 2018, 5:01 PM · Restricted Project
juliehockett added reviewers for D48908: [clang-doc] Pass over function-internal declarations: leonardchan, jakehehrlich.
Aug 2 2018, 1:44 PM · Restricted Project
juliehockett added reviewers for D48909: [clang-doc] Update BitcodeReader to use llvm::Error: leonardchan, jakehehrlich.
Aug 2 2018, 1:44 PM · Restricted Project
juliehockett committed rL338763: Reland "[clang-doc] Refactoring mapper to map by scope".
Reland "[clang-doc] Refactoring mapper to map by scope"
Aug 2 2018, 1:11 PM
juliehockett committed rCTE338763: Reland "[clang-doc] Refactoring mapper to map by scope".
Reland "[clang-doc] Refactoring mapper to map by scope"
Aug 2 2018, 1:11 PM
juliehockett closed D48341: [clang-doc] Refactoring mapper to map by scope.
Aug 2 2018, 1:10 PM · Restricted Project
juliehockett committed rCTE338748: Revert "[clang-doc] Refactoring mapper to map by scope".
Revert "[clang-doc] Refactoring mapper to map by scope"
Aug 2 2018, 11:02 AM
juliehockett committed rL338748: Revert "[clang-doc] Refactoring mapper to map by scope".
Revert "[clang-doc] Refactoring mapper to map by scope"
Aug 2 2018, 11:02 AM
juliehockett committed rL338738: [clang-doc] Refactoring mapper to map by scope.
[clang-doc] Refactoring mapper to map by scope
Aug 2 2018, 10:18 AM
juliehockett committed rCTE338738: [clang-doc] Refactoring mapper to map by scope.
[clang-doc] Refactoring mapper to map by scope
Aug 2 2018, 10:17 AM
juliehockett added inline comments to D48341: [clang-doc] Refactoring mapper to map by scope.
Aug 2 2018, 10:02 AM · Restricted Project

Jul 31 2018

juliehockett added inline comments to D48341: [clang-doc] Refactoring mapper to map by scope.
Jul 31 2018, 5:29 PM · Restricted Project
juliehockett updated the diff for D48341: [clang-doc] Refactoring mapper to map by scope.

Removing explicit USRs from tests & addressing comments

Jul 31 2018, 5:29 PM · Restricted Project

Jul 27 2018

juliehockett added a comment to D48341: [clang-doc] Refactoring mapper to map by scope.

any further thoughts on this?

Jul 27 2018, 11:09 AM · Restricted Project
juliehockett abandoned D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo.
Jul 27 2018, 9:18 AM · Restricted Project

Jul 25 2018

juliehockett added a comment to D48341: [clang-doc] Refactoring mapper to map by scope.

ping

Jul 25 2018, 3:16 PM · Restricted Project

Jul 23 2018

juliehockett added a comment to D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo.

Is there a way to add a test, that would trigger the old segfault and show that it does not happen anymore with this fix?

+1, we should have a minimal test case for this fix, https://bugs.llvm.org/show_bug.cgi?id=36150 provides a case, but we need to reduce it (getting rid of the STD header).

Jul 23 2018, 11:54 AM · Restricted Project
juliehockett updated the diff for D48341: [clang-doc] Refactoring mapper to map by scope.

Updating tests

Jul 23 2018, 11:47 AM · Restricted Project

Jul 20 2018

juliehockett committed rL337632: [clang-doc] Create a script to generate tests.
[clang-doc] Create a script to generate tests
Jul 20 2018, 4:06 PM
juliehockett committed rCTE337632: [clang-doc] Create a script to generate tests.
[clang-doc] Create a script to generate tests
Jul 20 2018, 4:06 PM
juliehockett closed D49268: [clang-doc] Create a script to generate tests.
Jul 20 2018, 4:05 PM · Restricted Project
juliehockett committed rL337602: [clang-doc] Adding PublicOnly flag.
[clang-doc] Adding PublicOnly flag
Jul 20 2018, 11:55 AM
juliehockett committed rCTE337602: [clang-doc] Adding PublicOnly flag.
[clang-doc] Adding PublicOnly flag
Jul 20 2018, 11:55 AM
juliehockett closed D48395: Added PublicOnly flag.
Jul 20 2018, 11:55 AM

Jul 19 2018

juliehockett added inline comments to D48341: [clang-doc] Refactoring mapper to map by scope.
Jul 19 2018, 7:28 AM · Restricted Project

Jul 17 2018

juliehockett added a comment to D48341: [clang-doc] Refactoring mapper to map by scope.

ping

Jul 17 2018, 3:51 PM · Restricted Project

Jul 16 2018

juliehockett added inline comments to D48395: Added PublicOnly flag.
Jul 16 2018, 2:55 PM

Jul 13 2018

juliehockett added a comment to D49268: [clang-doc] Create a script to generate tests.

Did you meant to commit clang-tools-extra/clang-doc/test_cases/ ?
I can't tell whether it is a temporary directory or not.

Jul 13 2018, 9:19 AM · Restricted Project
juliehockett updated the diff for D49268: [clang-doc] Create a script to generate tests.

Addressing comments

Jul 13 2018, 9:19 AM · Restricted Project

Jul 12 2018

juliehockett updated the diff for D48341: [clang-doc] Refactoring mapper to map by scope.

Refactoring the map-by-scope into the initial mapping phase.

Jul 12 2018, 2:44 PM · Restricted Project
juliehockett created D49268: [clang-doc] Create a script to generate tests.
Jul 12 2018, 2:18 PM · Restricted Project

Jul 11 2018

juliehockett accepted D48395: Added PublicOnly flag.

Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric has any concerns.

Jul 11 2018, 8:55 AM

Jul 10 2018

juliehockett created D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo.
Jul 10 2018, 3:06 PM · Restricted Project

Jul 3 2018

juliehockett created D48909: [clang-doc] Update BitcodeReader to use llvm::Error.
Jul 3 2018, 5:45 PM · Restricted Project
juliehockett created D48908: [clang-doc] Pass over function-internal declarations.
Jul 3 2018, 5:44 PM · Restricted Project
juliehockett added inline comments to D48395: Added PublicOnly flag.
Jul 3 2018, 2:43 PM

Jul 2 2018

juliehockett added a comment to D48395: Added PublicOnly flag.

Please run clang-format and clang-tidy on the patch.

Jul 2 2018, 6:36 PM
juliehockett added a reviewer for D48395: Added PublicOnly flag: ioeric.
Jul 2 2018, 2:37 PM
juliehockett added inline comments to D48341: [clang-doc] Refactoring mapper to map by scope.
Jul 2 2018, 2:15 PM · Restricted Project
juliehockett updated the diff for D48341: [clang-doc] Refactoring mapper to map by scope.

Refactoring second reduce code into the library, and adding bitcode reader/writer support

Jul 2 2018, 2:07 PM · Restricted Project

Jun 28 2018

juliehockett accepted D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain.

LGTM

Jun 28 2018, 1:22 PM

Jun 27 2018

juliehockett accepted D48671: [sanitizer] zx_cprng_draw no longer returns any value.
Jun 27 2018, 2:28 PM

Jun 21 2018

juliehockett added a comment to D48395: Added PublicOnly flag.

So on seeing this, all of the plumbing needed to get that particular value where you need it is a bit ugly. I'm inclined to suggest wrapping it in a ClangDocContext, containing it and the ExecutionContext in the ClangDoc.h file:

Jun 21 2018, 3:15 PM

Jun 20 2018

juliehockett added a comment to D48395: Added PublicOnly flag.

Can you re-upload the patch with context? (i.e. use -U999999 or similar)

Jun 20 2018, 3:19 PM
juliehockett updated the diff for D43424: [clang-doc] Implement a (simple) Markdown generator.

Updating to reflect changes to the framework (and make it work).

Jun 20 2018, 12:52 PM · Restricted Project

Jun 19 2018

juliehockett created D48341: [clang-doc] Refactoring mapper to map by scope.
Jun 19 2018, 4:54 PM · Restricted Project
juliehockett abandoned D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging.
Jun 19 2018, 4:52 PM · Restricted Project

Jun 7 2018

juliehockett accepted D47866: [Fuzzer] Update the header path for fdio/spawn.h on Fuchsia.
Jun 7 2018, 9:04 AM

Jun 6 2018

juliehockett closed D43667: [clang-doc] Implement a YAML generator.

Closed in r334103 .

Jun 6 2018, 9:18 AM · Restricted Project
juliehockett committed rL334103: [clang-doc] Implement a YAML generator.
[clang-doc] Implement a YAML generator
Jun 6 2018, 9:18 AM
juliehockett committed rCTE334103: [clang-doc] Implement a YAML generator.
[clang-doc] Implement a YAML generator
Jun 6 2018, 9:18 AM

Jun 5 2018

juliehockett added inline comments to D43667: [clang-doc] Implement a YAML generator.
Jun 5 2018, 12:06 PM · Restricted Project
juliehockett updated the diff for D43667: [clang-doc] Implement a YAML generator.

Fixing comments

Jun 5 2018, 9:23 AM · Restricted Project

Jun 4 2018

juliehockett updated the diff for D43667: [clang-doc] Implement a YAML generator.

Addressing comments

Jun 4 2018, 2:36 PM · Restricted Project
juliehockett added a comment to D47732: [clang-doc] Add BitReader to LLVM_LINK_COMPONENTS.

Already fixed in rL333936, sorry!

Jun 4 2018, 11:24 AM
juliehockett committed rL333936: [clang-doc] Adding missing dependencies to fix linker error on bot.
[clang-doc] Adding missing dependencies to fix linker error on bot
Jun 4 2018, 11:22 AM