Page MenuHomePhabricator

juliehockett (Julie Hockett)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2017, 3:56 PM (83 w, 6 d)

Recent Activity

Today

juliehockett added a comment to D63734: Update CODE_OWNERS.txt for clang-doc.

ping

Wed, Jun 26, 11:08 AM · Restricted Project
juliehockett accepted D62970: [clang-doc] De-duplicate comments and locations.
Wed, Jun 26, 10:19 AM · Restricted Project

Mon, Jun 24

juliehockett added inline comments to D63663: [clang-doc] Add html links to references.
Mon, Jun 24, 5:00 PM · Restricted Project
juliehockett committed rGb1f01e27ec0c: [clang-doc] Add basic support for templates and typedef (authored by juliehockett).
[clang-doc] Add basic support for templates and typedef
Mon, Jun 24, 12:33 PM
juliehockett committed rL364222: [clang-doc] Add basic support for templates and typedef.
[clang-doc] Add basic support for templates and typedef
Mon, Jun 24, 12:32 PM
juliehockett closed D63367: [clang-doc] Add basic support for templates and typedef.
Mon, Jun 24, 12:32 PM · Restricted Project, Restricted Project
juliehockett created D63734: Update CODE_OWNERS.txt for clang-doc.
Mon, Jun 24, 12:24 PM · Restricted Project

Fri, Jun 21

juliehockett added inline comments to D63666: [clang-doc] Add templates to HTML generator.
Fri, Jun 21, 2:00 PM · Restricted Project
juliehockett added a comment to D63663: [clang-doc] Add html links to references.

General design thought: could we move the path name construction to Serialize.cpp? Essentially, move the logic that builds the path name from the namespaces and name to the serialize step (you'll have to add the OutDirectory to the ClangDocContext so that you can access it in the mapper), and then the GetInfoOuputFile() function in ClangDocMain.cpp would take the Info.Path string as a parameter and do the directory construction and whatnot.

Fri, Jun 21, 12:40 PM · Restricted Project
juliehockett accepted D63367: [clang-doc] Add basic support for templates and typedef.
Fri, Jun 21, 10:09 AM · Restricted Project, Restricted Project
juliehockett added inline comments to D63180: [clang-doc] Adds HTML generator.
Fri, Jun 21, 10:05 AM · Restricted Project

Tue, Jun 18

juliehockett committed rGd9b3d08a9a63: [clang-tidy] Split fuchsia-default-arguments (authored by juliehockett).
[clang-tidy] Split fuchsia-default-arguments
Tue, Jun 18, 11:08 AM
juliehockett committed rL363712: [clang-tidy] Split fuchsia-default-arguments.
[clang-tidy] Split fuchsia-default-arguments
Tue, Jun 18, 11:08 AM
juliehockett closed D62437: [clang-tidy] Splits fuchsia-default-arguments.
Tue, Jun 18, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 17

juliehockett added inline comments to D63367: [clang-doc] Add basic support for templates and typedef.
Mon, Jun 17, 12:24 PM · Restricted Project, Restricted Project

Tue, Jun 11

juliehockett accepted D62437: [clang-tidy] Splits fuchsia-default-arguments.
Tue, Jun 11, 2:55 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 6

juliehockett added a comment to D62970: [clang-doc] De-duplicate comments and locations.

Actually if we can make Description a hash set that would be best. I think using std::set would require an awkward < operator to be defined. There should be standard ways of getting hashes out of all the string and vector types and you can use hash_combine to combine all of these into a single hash.

Thu, Jun 6, 3:25 PM · Restricted Project
juliehockett added a comment to D62970: [clang-doc] De-duplicate comments and locations.

Please add a test case to unittests/clang-doc/MergeTest.cpp.

Thu, Jun 6, 11:46 AM · Restricted Project
juliehockett added a comment to D62437: [clang-tidy] Splits fuchsia-default-arguments.

Sorry for the delay!

Thu, Jun 6, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

May 20 2019

juliehockett abandoned D62157: Remove explicit header-filter in run_clang_tidy.py.

@hintonda Aha so it is :)

May 20 2019, 4:00 PM · Restricted Project
juliehockett created D62157: Remove explicit header-filter in run_clang_tidy.py.
May 20 2019, 12:53 PM · Restricted Project

May 9 2019

juliehockett accepted D61768: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
May 9 2019, 4:13 PM · Restricted Project, Restricted Project

May 2 2019

juliehockett accepted D61450: [compiler-rt] Set the ZX_VMO_RESIZABLE option for zx_vmo_create.
May 2 2019, 10:10 AM · Restricted Project, Restricted Project

May 1 2019

juliehockett accepted D61383: [Driver] Explicitly request platform rtlib in the Driver pic test.
May 1 2019, 9:12 AM · Restricted Project, Restricted Project

Apr 29 2019

juliehockett accepted D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

It's building on my machine now with our configuration -- and made me properly set up my mac again for development, so many positives here. Thanks for the fix!

Apr 29 2019, 12:31 PM · Restricted Project, Restricted Project
juliehockett accepted D61271: [clangd][xpc] Fix XPC unittests.

This fixes the broken configure step on our bots now -- thanks for the quick patch!

Apr 29 2019, 12:04 PM · Restricted Project
juliehockett added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

This is also making our Mac builders fail on configuration, and looks like a directory wasn't included properly when a test moved to a subdirectory -- would you mind taking a look? The CMake command we're running is at the top of the attached log.

CMake Error at /b/s/w/ir/k/llvm-project/clang-tools-extra/clangd/unittests/xpc/CMakeLists.txt:11 (add_extra_unittest):
  Unknown CMake command "add_extra_unittest".

Full Log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8914851701929934272/+/steps/clang/0/steps/configure/0/stdout

Apr 29 2019, 10:03 AM · Restricted Project, Restricted Project

Apr 26 2019

juliehockett added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

This patch has broken our bots -- when it's building the osx host runtime, it's now triggering an assert on the tsan arm64 test case that wasn't being triggered before. Would you be able to take a look?

Error:

CMake Error at /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:177 (message):
  Unsupported architecture: arm64
Call Stack (most recent call first):
  /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:216 (get_target_flags_for_arch)
  /b/s/w/ir/k/llvm-project/compiler-rt/test/tsan/CMakeLists.txt:78 (get_test_cflags_for_apple_platform)

Full log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8915104112618242800/+/steps/clang/0/steps/build/0/stdout

Sorry about this. I'll revert the patch now and I'll take a look at re-landing it when time permits.

Could you clarify what you mean by "assert on the tsan arm64 test case", all I see in the log is a CMake error, relating to arm64. I don't see any lit tests being executed.

Apr 26 2019, 10:53 AM · Restricted Project, Restricted Project
juliehockett added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

This patch has broken our bots -- when it's building the osx host runtime, it's now triggering an assert on the tsan arm64 test case that wasn't being triggered before. Would you be able to take a look?

Apr 26 2019, 10:36 AM · Restricted Project, Restricted Project

Mar 29 2019

juliehockett closed D59975: [fuchsia] Add clang-doc to Fuchsia distribution.

Closed and submitted in r357275

Mar 29 2019, 10:05 AM · Restricted Project
juliehockett committed rGdd0c7d88c6c5: [fuchsia] Add clang-doc to Fuchsia distribution (authored by juliehockett).
[fuchsia] Add clang-doc to Fuchsia distribution
Mar 29 2019, 9:56 AM
juliehockett committed rGf64d4ec9be45: [clang-doc] Build as clang_tool (authored by juliehockett).
[clang-doc] Build as clang_tool
Mar 29 2019, 9:56 AM
juliehockett committed rCTE357274: [clang-doc] Build as clang_tool.
[clang-doc] Build as clang_tool
Mar 29 2019, 9:56 AM
juliehockett committed rC357275: [fuchsia] Add clang-doc to Fuchsia distribution.
[fuchsia] Add clang-doc to Fuchsia distribution
Mar 29 2019, 9:56 AM
juliehockett committed rL357275: [fuchsia] Add clang-doc to Fuchsia distribution.
[fuchsia] Add clang-doc to Fuchsia distribution
Mar 29 2019, 9:56 AM
juliehockett committed rL357274: [clang-doc] Build as clang_tool.
[clang-doc] Build as clang_tool
Mar 29 2019, 9:56 AM
juliehockett closed D59974: [clang-doc] Build as clang_tool.
Mar 29 2019, 9:56 AM · Restricted Project, Restricted Project

Mar 28 2019

juliehockett added reviewers for D59975: [fuchsia] Add clang-doc to Fuchsia distribution: phosek, leonardchan.
Mar 28 2019, 6:35 PM · Restricted Project
juliehockett created D59974: [clang-doc] Build as clang_tool.
Mar 28 2019, 6:35 PM · Restricted Project, Restricted Project
juliehockett created D59975: [fuchsia] Add clang-doc to Fuchsia distribution.
Mar 28 2019, 6:35 PM · Restricted Project

Mar 25 2019

juliehockett accepted D59803: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin.
Mar 25 2019, 4:56 PM · Restricted Project

Jan 16 2019

juliehockett accepted D56825: [CMake][Fuchsia] Disable modules for the second stage build.

lgtm

Jan 16 2019, 7:42 PM

Jan 3 2019

juliehockett updated the diff for D52847: [clang-doc] Handle anonymous namespaces.
Jan 3 2019, 5:16 PM · Restricted Project

Dec 21 2018

juliehockett committed rCTE349930: [clang-tidy] Add export-fixes flag to clang-tidy-diff.
[clang-tidy] Add export-fixes flag to clang-tidy-diff
Dec 21 2018, 9:28 AM
juliehockett committed rL349930: [clang-tidy] Add export-fixes flag to clang-tidy-diff.
[clang-tidy] Add export-fixes flag to clang-tidy-diff
Dec 21 2018, 9:28 AM
juliehockett closed D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff.
Dec 21 2018, 9:28 AM · Restricted Project

Dec 18 2018

juliehockett created D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff.
Dec 18 2018, 12:22 PM · Restricted Project

Nov 16 2018

juliehockett accepted D54655: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia.
Nov 16 2018, 3:06 PM

Nov 13 2018

juliehockett accepted D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
Nov 13 2018, 7:53 PM

Nov 12 2018

juliehockett abandoned D54168: [clang-tidy] Zircon fbl::move -> std::move.

After a lot of discussion, we'll do this migration internally. Thanks for your comments!

Nov 12 2018, 10:27 AM · Restricted Project
juliehockett abandoned D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>.

After a lot of discussion, we'll do this migration internally. Thanks for your comments!

Nov 12 2018, 10:27 AM · Restricted Project

Nov 7 2018

juliehockett added inline comments to D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>.
Nov 7 2018, 8:22 AM · Restricted Project

Nov 6 2018

juliehockett added inline comments to D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>.
Nov 6 2018, 6:54 PM · Restricted Project
juliehockett added inline comments to D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>.
Nov 6 2018, 6:47 PM · Restricted Project
juliehockett updated the diff for D54168: [clang-tidy] Zircon fbl::move -> std::move.
Nov 6 2018, 6:47 PM · Restricted Project
juliehockett updated the diff for D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>.
Nov 6 2018, 6:47 PM · Restricted Project
juliehockett updated the diff for D54168: [clang-tidy] Zircon fbl::move -> std::move.
Nov 6 2018, 6:18 PM · Restricted Project
juliehockett added a comment to D54168: [clang-tidy] Zircon fbl::move -> std::move.

I think this check is ok in the current form, but does it really need to be in upstream clang-tidy? You said its for migration only, so it is not valuable for you for a long time either?

Nov 6 2018, 2:48 PM · Restricted Project
juliehockett updated subscribers of D54168: [clang-tidy] Zircon fbl::move -> std::move.
Nov 6 2018, 11:30 AM · Restricted Project
juliehockett created D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>.
Nov 6 2018, 11:30 AM · Restricted Project
juliehockett created D54168: [clang-tidy] Zircon fbl::move -> std::move.
Nov 6 2018, 11:26 AM · Restricted Project

Nov 2 2018

juliehockett planned changes to D53882: [clang-tidy] Adding Zircon checker for std namespace.

I am a bit confused by what this check is trying to accomplish. It seems like this is intended to catch use of anything declared within the standard library, but that includes library support things that are needed to write useful code. For instance, it seems this means users cannot use initializer lists or type traits. I'm not even certain users can overload operator new() because that uses std::size_t as an argument.

Can you expound on the requirements in a bit more detail? Is it truly "no standard library functionality at all, including things required to be supported in freestanding implementations"?

Nov 2 2018, 12:53 PM · Restricted Project

Oct 30 2018

juliehockett added inline comments to D53882: [clang-tidy] Adding Zircon checker for std namespace.
Oct 30 2018, 2:58 PM · Restricted Project
juliehockett updated the diff for D53882: [clang-tidy] Adding Zircon checker for std namespace.
Oct 30 2018, 2:58 PM · Restricted Project
juliehockett updated subscribers of D53882: [clang-tidy] Adding Zircon checker for std namespace.
Oct 30 2018, 12:30 PM · Restricted Project
juliehockett created D53882: [clang-tidy] Adding Zircon checker for std namespace.
Oct 30 2018, 12:30 PM · Restricted Project

Oct 29 2018

juliehockett accepted D53833: [Driver] Include missing touch files for sanitized library paths.
Oct 29 2018, 2:07 PM

Oct 26 2018

juliehockett committed rL345418: [clang-doc] Switch to default to all-TUs executor.
[clang-doc] Switch to default to all-TUs executor
Oct 26 2018, 12:15 PM
juliehockett committed rCTE345418: [clang-doc] Switch to default to all-TUs executor.
[clang-doc] Switch to default to all-TUs executor
Oct 26 2018, 12:14 PM
juliehockett closed D53170: [clang-doc] Switch to default to all-TUs executor.
Oct 26 2018, 12:14 PM · Restricted Project

Oct 17 2018

juliehockett committed rCTE344707: [clang-doc] Bringing bitcode tests in line.
[clang-doc] Bringing bitcode tests in line
Oct 17 2018, 1:18 PM
juliehockett committed rL344707: [clang-doc] Bringing bitcode tests in line.
[clang-doc] Bringing bitcode tests in line
Oct 17 2018, 1:18 PM
juliehockett closed D53381: [clang-doc] Bringing bitcode tests in line.
Oct 17 2018, 1:18 PM · Restricted Project
juliehockett created D53382: [clang-doc] Update documentation.
Oct 17 2018, 11:43 AM · Restricted Project
juliehockett created D53381: [clang-doc] Bringing bitcode tests in line.
Oct 17 2018, 11:29 AM · Restricted Project

Oct 16 2018

juliehockett committed rL344655: [clang-doc] Limit integration tests.
[clang-doc] Limit integration tests
Oct 16 2018, 4:10 PM
juliehockett committed rCTE344655: [clang-doc] Limit integration tests.
[clang-doc] Limit integration tests
Oct 16 2018, 4:10 PM
juliehockett closed D53150: [clang-doc] Limit integration tests.
Oct 16 2018, 4:09 PM · Restricted Project
juliehockett closed D53150: [clang-doc] Limit integration tests.
Oct 16 2018, 4:09 PM · Restricted Project
juliehockett committed rCTE344654: [clang-doc] Add unit tests for Markdown generation.
[clang-doc] Add unit tests for Markdown generation
Oct 16 2018, 4:09 PM
juliehockett committed rL344654: [clang-doc] Add unit tests for Markdown generation.
[clang-doc] Add unit tests for Markdown generation
Oct 16 2018, 4:09 PM
juliehockett closed D53085: [clang-doc] Add unit tests for Markdown.
Oct 16 2018, 4:09 PM · Restricted Project
juliehockett closed D53085: [clang-doc] Add unit tests for Markdown.
Oct 16 2018, 4:09 PM · Restricted Project
juliehockett committed rL344653: [clang-doc] Add unit tests for YAML generation.
[clang-doc] Add unit tests for YAML generation
Oct 16 2018, 4:09 PM
juliehockett committed rCTE344653: [clang-doc] Add unit tests for YAML generation.
[clang-doc] Add unit tests for YAML generation
Oct 16 2018, 4:09 PM
juliehockett committed rCTE344652: [clang-doc] Add unit tests for merging.
[clang-doc] Add unit tests for merging
Oct 16 2018, 4:09 PM
juliehockett closed D53084: [clang-doc] Add unit tests for YAML.
Oct 16 2018, 4:09 PM · Restricted Project
juliehockett committed rL344652: [clang-doc] Add unit tests for merging.
[clang-doc] Add unit tests for merging
Oct 16 2018, 4:09 PM
juliehockett committed rL344651: [clang-doc] Add unit tests for bitcode.
[clang-doc] Add unit tests for bitcode
Oct 16 2018, 4:09 PM
juliehockett closed D53083: [clang-doc] Add unit tests for merging.
Oct 16 2018, 4:09 PM · Restricted Project
juliehockett committed rCTE344651: [clang-doc] Add unit tests for bitcode.
[clang-doc] Add unit tests for bitcode
Oct 16 2018, 4:09 PM
juliehockett closed D53082: [clang-doc] Add unit tests for bitcode.
Oct 16 2018, 4:08 PM · Restricted Project
juliehockett committed rL344650: [clang-doc] Add unit tests for serialization.
[clang-doc] Add unit tests for serialization
Oct 16 2018, 4:08 PM
juliehockett committed rCTE344650: [clang-doc] Add unit tests for serialization.
[clang-doc] Add unit tests for serialization
Oct 16 2018, 4:08 PM
juliehockett closed D53081: [clang-doc] Add unit tests for serialization.
Oct 16 2018, 4:08 PM · Restricted Project

Oct 15 2018

juliehockett updated the diff for D53081: [clang-doc] Add unit tests for serialization.
Oct 15 2018, 2:04 PM · Restricted Project
juliehockett updated the diff for D53085: [clang-doc] Add unit tests for Markdown.
Oct 15 2018, 1:58 PM · Restricted Project
juliehockett updated the diff for D53084: [clang-doc] Add unit tests for YAML.
Oct 15 2018, 1:57 PM · Restricted Project
juliehockett updated the diff for D53082: [clang-doc] Add unit tests for bitcode.
Oct 15 2018, 1:51 PM · Restricted Project
juliehockett updated the diff for D53081: [clang-doc] Add unit tests for serialization.
Oct 15 2018, 1:50 PM · Restricted Project