Page MenuHomePhabricator

juliehockett (Julie Hockett)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2017, 3:56 PM (92 w, 1 d)

Recent Activity

Today

juliehockett committed rG245154de5002: [clang-doc] Bump BitcodeWriter max line number to 32U (authored by juliehockett).
[clang-doc] Bump BitcodeWriter max line number to 32U
Fri, Aug 23, 2:14 PM
juliehockett committed rL369811: [clang-doc] Bump BitcodeWriter max line number to 32U.
[clang-doc] Bump BitcodeWriter max line number to 32U
Fri, Aug 23, 2:14 PM
juliehockett closed D66681: [clang-doc] Bump BitcodeWriter max line number to 32U.
Fri, Aug 23, 2:13 PM · Restricted Project, Restricted Project
juliehockett created D66681: [clang-doc] Bump BitcodeWriter max line number to 32U.
Fri, Aug 23, 1:40 PM · Restricted Project, Restricted Project

Tue, Aug 20

juliehockett created D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error.
Tue, Aug 20, 3:42 PM · Restricted Project

Fri, Aug 16

juliehockett added a comment to D66378: [clang-doc] Fix casting not working in gcc 5.4.0.

LGTM, for posterity

Fri, Aug 16, 6:47 PM · Restricted Project, Restricted Project
juliehockett accepted D66353: [clang-doc] Redesign of generated HTML files.

LGTM

Fri, Aug 16, 11:33 AM · Restricted Project, Restricted Project
juliehockett added inline comments to D66353: [clang-doc] Redesign of generated HTML files.
Fri, Aug 16, 10:09 AM · Restricted Project, Restricted Project
juliehockett accepted D66298: [clang-doc] Fix records in global namespace.
Fri, Aug 16, 8:59 AM · Restricted Project, Restricted Project

Thu, Aug 15

juliehockett accepted D66299: [clang-doc] Sort index elements case insensitive.
Thu, Aug 15, 9:17 AM · Restricted Project, Restricted Project
juliehockett added inline comments to D66298: [clang-doc] Fix records in global namespace.
Thu, Aug 15, 8:56 AM · Restricted Project, Restricted Project
juliehockett accepted D66268: [clang-doc] Fix use of source-root flag.
Thu, Aug 15, 8:50 AM · Restricted Project, Restricted Project
juliehockett accepted D66238: [clang-doc] Serialize inherited attributes and methods.
Thu, Aug 15, 8:48 AM · Restricted Project, Restricted Project

Wed, Aug 14

juliehockett added inline comments to D66238: [clang-doc] Serialize inherited attributes and methods.
Wed, Aug 14, 4:16 PM · Restricted Project, Restricted Project

Tue, Aug 13

juliehockett accepted D66151: [clang-doc] Fix bitcode writer.

One comment then LGTM

Tue, Aug 13, 3:26 PM · Restricted Project, Restricted Project
juliehockett accepted D66124: [clang-doc] Add missing check in tests.
Tue, Aug 13, 9:11 AM · Restricted Project, Restricted Project

Mon, Aug 12

juliehockett accepted D65987: [clang-doc] Generate HTML links for children namespaces/records.

LGTM

Mon, Aug 12, 10:52 AM · Restricted Project, Restricted Project

Fri, Aug 9

juliehockett added inline comments to D65987: [clang-doc] Generate HTML links for children namespaces/records.
Fri, Aug 9, 9:18 AM · Restricted Project, Restricted Project
juliehockett accepted D65483: [clang-doc] Add link to source code in file definitions.

LGTM

Fri, Aug 9, 9:10 AM · Restricted Project, Restricted Project
juliehockett accepted D65918: [clang-doc] Generate an HTML index file.
Fri, Aug 9, 9:10 AM · Restricted Project, Restricted Project
juliehockett abandoned D53382: [clang-doc] Update documentation.
Fri, Aug 9, 9:06 AM · Restricted Project

Wed, Aug 7

juliehockett accepted D65915: [clang-doc] Protect Index with mutex during reducing and generation stage.

LGTM

Wed, Aug 7, 8:05 PM · Restricted Project, Restricted Project
juliehockett accepted D65628: [clang-doc] Parallelize reducing phase.

LGTM (after comment nit addressed)

Wed, Aug 7, 1:37 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D65483: [clang-doc] Add link to source code in file definitions.
Wed, Aug 7, 1:32 PM · Restricted Project, Restricted Project
juliehockett added a comment to D65030: [clang-doc] Add second index for sections within info's content.

LGTM

Wed, Aug 7, 1:29 PM · Restricted Project, Restricted Project

Tue, Aug 6

juliehockett added reviewers for D65833: [Tooling] Expose ExecutorConcurrency option.: sammccall, ioeric, ilya-biryukov.
Tue, Aug 6, 5:23 PM · Restricted Project
juliehockett accepted D65827: [clang-doc] Fix paths of js in import tags.

LGTM (let's make sure we double check this next time)

Tue, Aug 6, 1:57 PM · Restricted Project, Restricted Project
juliehockett accepted D65690: [clang-doc] Add index in each info html file.

LGTM

Tue, Aug 6, 9:03 AM · Restricted Project, Restricted Project

Mon, Aug 5

juliehockett added a comment to D65622: [clang-doc] Update documentation.

Sorry for the delayed review, but a few things I caught :)

Mon, Aug 5, 5:15 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D65690: [clang-doc] Add index in each info html file.
Mon, Aug 5, 5:10 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D65030: [clang-doc] Add second index for sections within info's content.
Mon, Aug 5, 4:59 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D65483: [clang-doc] Add link to source code in file definitions.
Mon, Aug 5, 4:59 PM · Restricted Project, Restricted Project
juliehockett accepted D64958: [clang-doc] Fix link generation.

LGTM with a comment correction

Mon, Aug 5, 4:59 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D65628: [clang-doc] Parallelize reducing phase.
Mon, Aug 5, 4:42 PM · Restricted Project, Restricted Project

Mon, Jul 29

juliehockett accepted D65425: [clang-doc] Fix expected output in tests.
Mon, Jul 29, 4:50 PM · Restricted Project, Restricted Project
juliehockett accepted D65419: [clang-doc] Fix failing tests on Windows.
Mon, Jul 29, 2:51 PM · Restricted Project, Restricted Project

Fri, Jul 26

juliehockett accepted D65309: [clang-format] Fix style of css file paths.

LGTM after adding a comment to explain

Fri, Jul 26, 9:36 AM · Restricted Project, Restricted Project

Thu, Jul 25

juliehockett accepted D65306: [clang-doc] Fix failing tests on Windows.

Make sure you update the other stylesheet patch, as well, before landing that.

Thu, Jul 25, 4:10 PM · Restricted Project, Restricted Project
juliehockett accepted D64938: [clang-doc] Add option for user provided stylesheets.

LGTM

Thu, Jul 25, 2:09 PM · Restricted Project, Restricted Project
juliehockett added a comment to D65030: [clang-doc] Add second index for sections within info's content.

Looks mostly good to me, with a small formatting thing

Thu, Jul 25, 9:07 AM · Restricted Project, Restricted Project
juliehockett added inline comments to D65003: [clang-doc] Add index in each info html file.
Thu, Jul 25, 8:57 AM · Restricted Project
juliehockett added a comment to D64958: [clang-doc] Fix link generation.

Under what circumstances, exactly, is the path not set where you would need to create a link despite that? Is it only in the global namespace case? If so, could you special-case that and ignore other empty paths?

Thu, Jul 25, 8:49 AM · Restricted Project, Restricted Project

Jul 23 2019

juliehockett accepted D65005: [clang-doc] Fix output format of html.
Jul 23 2019, 3:02 PM · Restricted Project, Restricted Project
juliehockett accepted D65107: [clang-doc] Fix html entities in rendered text.

LGTM

Jul 23 2019, 2:43 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D64938: [clang-doc] Add option for user provided stylesheets.
Jul 23 2019, 2:42 PM · Restricted Project, Restricted Project
juliehockett accepted D64539: [clang-doc] Add stylesheet to generated html docs.

LGTM

Jul 23 2019, 2:37 PM · Restricted Project, Restricted Project

Jul 18 2019

juliehockett accepted D64539: [clang-doc] Add stylesheet to generated html docs.

LGTM

Jul 18 2019, 11:41 AM · Restricted Project, Restricted Project

Jul 17 2019

juliehockett committed rG337aea438c5e: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance (authored by juliehockett).
[clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance
Jul 17 2019, 10:45 AM
juliehockett committed rL366354: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance.
[clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance
Jul 17 2019, 10:41 AM
juliehockett closed D64813: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance.
Jul 17 2019, 10:41 AM · Restricted Project, Restricted Project

Jul 16 2019

juliehockett updated subscribers of D64813: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance.
Jul 16 2019, 11:32 AM · Restricted Project, Restricted Project
juliehockett created D64813: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance.
Jul 16 2019, 11:32 AM · Restricted Project, Restricted Project

Jul 12 2019

juliehockett committed rGb131ad0be284: [clang-doc] Fix failing tests on Windows (authored by juliehockett).
[clang-doc] Fix failing tests on Windows
Jul 12 2019, 3:22 PM
juliehockett committed rL365967: [clang-doc] Fix failing tests on Windows.
[clang-doc] Fix failing tests on Windows
Jul 12 2019, 3:19 PM
juliehockett closed D64669: [clang-doc] Fix failing tests on Windows.
Jul 12 2019, 3:19 PM · Restricted Project, Restricted Project
juliehockett accepted D64669: [clang-doc] Fix failing tests on Windows.

LGTM

Jul 12 2019, 3:04 PM · Restricted Project, Restricted Project
juliehockett accepted D64539: [clang-doc] Add stylesheet to generated html docs.
Jul 12 2019, 12:56 PM · Restricted Project, Restricted Project
juliehockett committed rG2c1c9a240776: [clang-doc] Add html links to references (authored by juliehockett).
[clang-doc] Add html links to references
Jul 12 2019, 11:33 AM
juliehockett committed rL365937: [clang-doc] Add html links to references.
[clang-doc] Add html links to references
Jul 12 2019, 11:32 AM
juliehockett closed D63663: [clang-doc] Add html links to references.
Jul 12 2019, 11:31 AM · Restricted Project, Restricted Project

Jul 11 2019

juliehockett accepted D63663: [clang-doc] Add html links to references.
Jul 11 2019, 8:40 AM · Restricted Project, Restricted Project
juliehockett added inline comments to D64539: [clang-doc] Add stylesheet to generated html docs.
Jul 11 2019, 8:37 AM · Restricted Project, Restricted Project

Jul 10 2019

juliehockett added inline comments to D63663: [clang-doc] Add html links to references.
Jul 10 2019, 3:58 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D64539: [clang-doc] Add stylesheet to generated html docs.
Jul 10 2019, 3:42 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D64539: [clang-doc] Add stylesheet to generated html docs.
Jul 10 2019, 3:42 PM · Restricted Project, Restricted Project
juliehockett committed rG671bac743673: [clang-doc] Add a structured HTML generator (authored by juliehockett).
[clang-doc] Add a structured HTML generator
Jul 10 2019, 12:04 PM
juliehockett committed rL365687: [clang-doc] Add a structured HTML generator.
[clang-doc] Add a structured HTML generator
Jul 10 2019, 12:04 PM
juliehockett closed D63857: [clang-doc] Add a structured HTML generator.
Jul 10 2019, 12:04 PM · Restricted Project, Restricted Project
juliehockett committed rGc32742139ed3: Update libc++ include path detection to use VFS on Linux (authored by juliehockett).
Update libc++ include path detection to use VFS on Linux
Jul 10 2019, 11:42 AM
juliehockett committed rL365682: Update libc++ include path detection to use VFS on Linux.
Update libc++ include path detection to use VFS on Linux
Jul 10 2019, 11:41 AM
juliehockett closed D64381: Update libc++ include path detection to use VFS on Linux.
Jul 10 2019, 11:41 AM · Restricted Project

Jul 9 2019

juliehockett added a comment to D63663: [clang-doc] Add html links to references.

I've also just noticed that the YAML generator is missing from this -- could you add the Path fields to hat output as well?

Jul 9 2019, 2:57 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D63663: [clang-doc] Add html links to references.
Jul 9 2019, 9:26 AM · Restricted Project, Restricted Project
juliehockett accepted D63857: [clang-doc] Add a structured HTML generator.

LGTM, unless Jake has further comments.

Jul 9 2019, 9:03 AM · Restricted Project, Restricted Project

Jul 8 2019

juliehockett created D64381: Update libc++ include path detection to use VFS on Linux.
Jul 8 2019, 5:15 PM · Restricted Project

Jul 2 2019

juliehockett committed rG097aedc9d9cf: [clang-doc] Serialize child namespaces and records (authored by juliehockett).
[clang-doc] Serialize child namespaces and records
Jul 2 2019, 1:01 PM
juliehockett committed rL364963: [clang-doc] Serialize child namespaces and records.
[clang-doc] Serialize child namespaces and records
Jul 2 2019, 1:00 PM
juliehockett closed D63911: [clang-doc] Serialize child namespaces and records.
Jul 2 2019, 1:00 PM · Restricted Project, Restricted Project
juliehockett committed rGd42f22997e4b: [clang-doc] Fix segfault in comment sorting (authored by juliehockett).
[clang-doc] Fix segfault in comment sorting
Jul 2 2019, 11:01 AM
juliehockett committed rL364949: [clang-doc] Fix segfault in comment sorting.
[clang-doc] Fix segfault in comment sorting
Jul 2 2019, 10:57 AM
juliehockett closed D63962: [clang-doc] Fix segfault in comment sorting.
Jul 2 2019, 10:57 AM · Restricted Project, Restricted Project
juliehockett accepted D63911: [clang-doc] Serialize child namespaces and records.
Jul 2 2019, 10:48 AM · Restricted Project, Restricted Project

Jun 28 2019

juliehockett created D63962: [clang-doc] Fix segfault in comment sorting.
Jun 28 2019, 4:15 PM · Restricted Project, Restricted Project
juliehockett added a comment to D63180: [clang-doc] Adds HTML generator.

I'm getting confused in all the different patches. I reviewed the HTML generator one like yesterday and was awaiting changes. Doesn't this do the same thing?

Jun 28 2019, 2:41 PM · Restricted Project
juliehockett added inline comments to D63911: [clang-doc] Serialize child namespaces and records.
Jun 28 2019, 1:05 PM · Restricted Project, Restricted Project
juliehockett committed rGd900ef0a5b13: [clang-doc] Handle anonymous namespaces (authored by juliehockett).
[clang-doc] Handle anonymous namespaces
Jun 28 2019, 12:09 PM
juliehockett committed rL364674: [clang-doc] Handle anonymous namespaces.
[clang-doc] Handle anonymous namespaces
Jun 28 2019, 12:08 PM
juliehockett closed D52847: [clang-doc] Handle anonymous namespaces.
Jun 28 2019, 12:08 PM · Restricted Project, Restricted Project
juliehockett abandoned D53882: [clang-tidy] Adding Zircon checker for std namespace.
Jun 28 2019, 11:23 AM · Restricted Project
juliehockett committed rG93a290fdc974: [clang-doc] De-duplicate comments and locations (authored by juliehockett).
[clang-doc] De-duplicate comments and locations
Jun 28 2019, 11:21 AM
juliehockett committed rL364670: [clang-doc] De-duplicate comments and locations.
[clang-doc] De-duplicate comments and locations
Jun 28 2019, 11:18 AM
juliehockett closed D62970: [clang-doc] De-duplicate comments and locations.
Jun 28 2019, 11:18 AM · Restricted Project, Restricted Project
juliehockett committed rG021d2f209339: Update CODE_OWNERS.txt for clang-doc (authored by juliehockett).
Update CODE_OWNERS.txt for clang-doc
Jun 28 2019, 10:36 AM
juliehockett committed rL364663: Update CODE_OWNERS.txt for clang-doc.
Update CODE_OWNERS.txt for clang-doc
Jun 28 2019, 10:35 AM
juliehockett closed D63734: Update CODE_OWNERS.txt for clang-doc.
Jun 28 2019, 10:35 AM · Restricted Project, Restricted Project

Jun 27 2019

juliehockett updated the diff for D52847: [clang-doc] Handle anonymous namespaces.
Jun 27 2019, 5:47 PM · Restricted Project, Restricted Project
juliehockett added inline comments to D63911: [clang-doc] Serialize child namespaces and records.
Jun 27 2019, 5:45 PM · Restricted Project, Restricted Project

Jun 26 2019

juliehockett added inline comments to D63857: [clang-doc] Add a structured HTML generator.
Jun 26 2019, 6:00 PM · Restricted Project, Restricted Project
juliehockett added a comment to D63734: Update CODE_OWNERS.txt for clang-doc.

ping

Jun 26 2019, 11:08 AM · Restricted Project, Restricted Project
juliehockett accepted D62970: [clang-doc] De-duplicate comments and locations.
Jun 26 2019, 10:19 AM · Restricted Project, Restricted Project