Page MenuHomePhabricator
Differential D46469

[sanitizer] Port fast stack unwinder to sparcv8
ClosedPublic
Actions

Authored by waltl on May 4 2018, 1:51 PM.

Details

Reviewers
vitalybuka
eugenis
alekseyshl
Commits
rG603c7ae232a9: [sanitizer] Port fast stack unwinder to sparcv8
rL332046: [sanitizer] Port fast stack unwinder to sparcv8
rCRT332046: [sanitizer] Port fast stack unwinder to sparcv8

Diff Detail

Event Timeline

waltl created this revision.May 4 2018, 1:51 PM
Herald added subscribers: chrib, fedor.sergeev, kubamracek, jyknight. · View Herald TranscriptMay 4 2018, 1:51 PM
kcc added inline comments.May 4 2018, 2:19 PM
compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cc
74 ↗(On Diff #145286)

This code is already too complex and fragile. Please avoid any #ifdefs
One option is to fork this function into a sparc-specific file.

waltl updated this revision to Diff 145786.May 8 2018, 2:24 PM

Move sparc support for fast stack unwinding into separate file

Harbormaster completed remote builds in B17858: Diff 145786.May 8 2018, 2:24 PM
Herald added subscribers: jrtc27, mgorny. · View Herald TranscriptMay 8 2018, 2:24 PM
waltl marked an inline comment as done.May 8 2018, 2:25 PM
vitalybuka accepted this revision.May 10 2018, 1:54 PM
This revision is now accepted and ready to land.May 10 2018, 1:54 PM
Closed by commit rCRT332046: [sanitizer] Port fast stack unwinder to sparcv8 (authored by waltl). · Explain WhyMay 10 2018, 2:44 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptMay 10 2018, 2:44 PM

Revision Contents
Changeset List

PathSize
lib/
sanitizer_common/
1 line
7 lines
58 lines

Diff 146231

View Options

lib/sanitizer_common/CMakeLists.txt

Loading...
View Options

lib/sanitizer_common/sanitizer_stacktrace.cc

Loading...
View Options

lib/sanitizer_common/sanitizer_stacktrace_sparc.cc

Loading...