This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add --stack-first option which places the shadow stack at start of linear memory
ClosedPublic

Authored by sbc100 on Apr 26 2018, 11:56 AM.

Event Timeline

sbc100 created this revision.Apr 26 2018, 11:56 AM
sbc100 updated this revision to Diff 144175.Apr 26 2018, 12:00 PM
  • move test
sbc100 updated this revision to Diff 144987.May 3 2018, 1:20 AM
  • move test
  • typos
  • add comment
ncw accepted this revision.May 3 2018, 3:23 AM

Nice, looks safe and potentially useful.

test/wasm/stack-first.test
3–4 ↗(On Diff #144987)

Could also test/assert the positions of some pieces of static data, and the __heap_base, ie check all the calculations are correct when --stack-first is used.

wasm/Writer.cpp
644

Broken sentence

This revision is now accepted and ready to land.May 3 2018, 3:23 AM
sbc100 updated this revision to Diff 145044.May 3 2018, 10:24 AM
  • feedback
This revision was automatically updated to reflect the committed changes.