- User Since
- Nov 24 2017, 7:16 AM (30 w, 2 d)
Thu, Jun 21
I've been quiet for a while as well ... I keep meaning to get back to my patch queue and try and get them reviewed and submitted. I have a couple of features completed or mostly-completed, I just need a few days away from my main job to get them back on track! Maybe it's time to get LLD ready for native-exception "sections" as well - that's a feature I'm really hoping will arrive soon in WebAssembly.
Looks good. I'm deducing that when you removed the "hidden" from "used_undef_fn" and "unused_undef_fn", the test then failed - and then the code change makes it pass again. Makes sense.
May 8 2018
This looks like a nice size optimisation, great.
May 3 2018
Nice, looks safe and potentially useful.
May 1 2018
Apr 26 2018
Apr 24 2018
Looks good :)
Apr 20 2018
Now there's nothing contentious, I think this one is safe to land too? It's been a loong time (weeks) since there was any movement on these LLD bugs. If you want me to come back and make further changes however, I'm happy to do that.
Apr 13 2018
Thanks for the feedback! I'll merge in a week if I haven't heard anything more.
Apr 11 2018
It's been another fortnight on this issue - is it now ready to go?
There are no outstanding review comments, and this is blocking the already-approved D44440. Is it good to land?
@sunfish, @dschuff, it's been another fortnight on this PR. If you don't want to look at it, or want to suggest another reviewer - that's fine, but it would be helpful to know, to get some feedback on whether I should by trying to get this in, or abandon it.
Apr 3 2018
Updated: removed redundant comment
Mar 29 2018
Updated, with clear differentiation between (symbol) name and debug name.
Mar 28 2018
Mar 27 2018
How about we do the multi-stage thing:
Updated - sorry for the long wait!
Mar 16 2018
Thanks for that! OK, I'll update these reviews and nudge them forwards next week. I've just been very busy at work this week with a customer project, and nut been able to spend and time on wasm in the evenings at home.
Mar 14 2018
I opened a can of worms! I think it can be cleaned up though...
Updated to not export by default, and creates export/import based on last-specified of --export-table and --import-table
Looks good, well caught
Mar 13 2018
Since callback APIs are so common (eg high usage of dynCall in Emscripten applications) it would be nice if engines could optimise table-based access so that it's usable. Why standardise an API for doing an indirect call from JS, then tell users, "write a Wasm trampoline instead since that's faster than the browser-provided method".
- rebased and fixed conflicts
- Move Live flag from Symbol to UndefinedFunction::ImportLive to clarify what it is that we're marking live
- small nits based on feedback
Updated: removed chunk from MarkLive, fixed conflicts on rebase.
D44150 is blocked on this. There's not a huge benefit to moving the header into the LLVM repo, but it could enable code-sharing with WasmObjectWriter which would be nice.
Landing with just the name section changes (in Writer.cpp and Driver.cpp).
I'm hoping this one can be approved too, since it goes along with D44343. Any objections?
Mar 12 2018
Updated: un-hid function used in test
Updated: addressed feedback, undid toString mangling changes
Updated to remove max/initial mem args, this just covers demangle now