Page MenuHomePhabricator

alexcrichton (Alex Crichton)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 9:19 AM (216 w, 6 d)

Recent Activity

Mon, Sep 16

alexcrichton accepted D67639: [WebAssembly] Restore defaults for stores per memop.

I've tested this patch compiling the motivating test case for the original performance issue for Firefox and performance is back to what it was in LLVM 8, so I can at least say from my perspective that this does the trick!

Mon, Sep 16, 7:17 PM · Restricted Project

Dec 16 2018

alexcrichton added a comment to D50017: ELF: Add libcall symbols to the link when LTO is being used..

Hello! We've discovered a regression in the Rust project from this commit, and I've opened a dedicated LLVM bug for that as well, and figured it'd be good to mention here as well!

Dec 16 2018, 12:07 PM

Nov 8 2018

alexcrichton added a comment to D54279: wasm32: Respect `--no-mangle` in more locations in LLD.

Thanks for the tip! The test should now be deduplicated

Nov 8 2018, 7:25 PM
alexcrichton updated the diff for D54279: wasm32: Respect `--no-mangle` in more locations in LLD.
Nov 8 2018, 7:24 PM
alexcrichton added a comment to D54279: wasm32: Respect `--no-mangle` in more locations in LLD.
Did you run the tests?
Nov 8 2018, 4:33 PM
alexcrichton updated the diff for D54279: wasm32: Respect `--no-mangle` in more locations in LLD.

Fix tests

Nov 8 2018, 4:32 PM
alexcrichton added a comment to D54279: wasm32: Respect `--no-mangle` in more locations in LLD.

Er oops sorry haven't submitted too many patches before so was just using git diff, but I've tried an update with git diff -U100000 and that should have more context!

Nov 8 2018, 3:48 PM
alexcrichton updated the diff for D54279: wasm32: Respect `--no-mangle` in more locations in LLD.

Updated diff with more context

Nov 8 2018, 3:48 PM
alexcrichton created D54279: wasm32: Respect `--no-mangle` in more locations in LLD.
Nov 8 2018, 3:35 PM

Oct 16 2018

Herald updated subscribers of D53252: [WebAssembly] Implement vector sext_inreg and tests with comparisons.
Oct 16 2018, 8:13 AM

Oct 2 2018

alexcrichton added a comment to D49034: [WebAssembly] Move/clone DBG_VALUE during WebAssemblyRegStackify pass.

er sorry, looks like some problems may already be known!

Oct 2 2018, 8:59 PM · debug-info
alexcrichton added a comment to D49034: [WebAssembly] Move/clone DBG_VALUE during WebAssemblyRegStackify pass.

I think this has unfortunately caused a regression :( -- https://bugs.llvm.org/show_bug.cgi?id=39158

Oct 2 2018, 8:58 PM · debug-info

Aug 29 2018

alexcrichton added a comment to D51460: [WebAssembly] Be a little more conservative in WebAssemblyFixFunctionBitcasts.

In some local tests it looks like this fixes the issue we were seeing, thanks so much!

Aug 29 2018, 5:48 PM

Aug 26 2018

alexcrichton added a comment to D49517: [WebAssembly] Ensure all bitcasts that would be invalid in wasm are removed by FixFunctionBitcasts pass.

I'm a bit late to this diff but I've bisected a regression in the Rust repo to this revision -- https://bugs.llvm.org/show_bug.cgi?id=38711

Aug 26 2018, 4:22 PM

Jul 6 2018

alexcrichton added a comment to D40146: [JumpThreading] Preservation of DT and LVI across the pass.

This is a bit late on this, but we're currently trying to upgrade LLVM in Rust and we've run into a performance regression bisected to this change, if those here familiar with this commit could help investigate that it'd be much appreciated!

Jul 6 2018, 6:37 PM

Jul 3 2018

alexcrichton added a comment to D44282: [PR16756] JumpThreading: explicitly update SSA rather than use SSAUpdater..

I've bisected a recent regression we discovered in Rust to this commit and cc'd some of y'all on the bug there, but if anyone else would like to help take a look at the performance regression there that'd be much appreciated!

Jul 3 2018, 10:55 PM

Jul 2 2018

alexcrichton added a comment to D40922: [ARM] Optimize {s|u}mul.with.overflow..

Oh no worries at all, thanks!

Jul 2 2018, 2:35 PM

Jul 1 2018

Herald added a reviewer for D40922: [ARM] Optimize {s|u}mul.with.overflow.: javed.absar.

FWIW https://bugs.llvm.org/show_bug.cgi?id=37382 was bisected back to this revision which has shown up when we upgraded LLVM in the Rust project

Jul 1 2018, 3:55 PM

May 29 2018

alexcrichton accepted D47500: [WebAssembly] Add support for response file parsing.

Awesome, thanks for the quick fix!

May 29 2018, 3:12 PM

Mar 12 2018

alexcrichton added a comment to D44357: [COFF] Adjust how we flag weak externals.

Thanks! This looks like it would do the trick yeah. I think we've since removed the C++ code that caused the error on our end (for entirely unrelated reasons) so we're unlikely to hit this any more (and can probably revert the patch I had), but this'd be good to get into the next version of LLVM!

Mar 12 2018, 7:24 AM

Jan 31 2018

alexcrichton added a comment to D42511: [WebAssembly] Add support for --gc-sections.

Wow that was fast, thanks so much! We'll be updating to this as soon as we can!

Jan 31 2018, 6:34 PM

Jan 30 2018

alexcrichton added a comment to D42511: [WebAssembly] Add support for --gc-sections.

FWIW I've just recently started testing LLD support w/ Rust code again and LLD master is working beautifully! The output of lld was a little large given the set of exported items, but @sunfish pointed me at this diff which worked perfectly for us as well! This managed to strip notably all the unused entries in the global table for call_indirect entries.

Jan 30 2018, 11:45 AM

Jan 24 2018

alexcrichton added a comment to D42509: [LivePhysRegs] Preserve pristine registers in blocks with no successors..

FWIW I've tested this locally and it does indeed fix the issues we were seeing!

Jan 24 2018, 4:20 PM

Nov 13 2017

alexcrichton added a comment to D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..

Thanks so much for helping us with this @JDevlieghere!

Nov 13 2017, 3:26 PM

Nov 10 2017

alexcrichton accepted D39866: [WebAssembly] Fix stack offsets of return values from call lowering..
Nov 10 2017, 5:31 AM
alexcrichton added a comment to D39866: [WebAssembly] Fix stack offsets of return values from call lowering..

FWIW I've confirmed that this fixes the issue I was seeing and our entire test suite now passes, thanks again!

Nov 10 2017, 2:20 AM

Oct 10 2017

alexcrichton added a comment to D38765: Don't replace constants with constants in GVN.

Oops sorry about that! Missed that last request, but should be taken care of now.

Oct 10 2017, 9:11 PM
alexcrichton updated the diff for D38765: Don't replace constants with constants in GVN.
Oct 10 2017, 9:10 PM
alexcrichton updated the diff for D38765: Don't replace constants with constants in GVN.

Ok thanks for the help! I've updated with some CHECK directives now. Mind helping me land the patch as well?

Oct 10 2017, 9:02 PM
alexcrichton added inline comments to D38765: Don't replace constants with constants in GVN.
Oct 10 2017, 8:48 PM
alexcrichton updated the diff for D38765: Don't replace constants with constants in GVN.

Sure thing, updated!

Oct 10 2017, 8:39 PM
alexcrichton added a comment to D38154: [PassManager] Run global opts after the inliner.

Ok, thanks for the info!

Oct 10 2017, 2:52 PM
alexcrichton created D38765: Don't replace constants with constants in GVN.
Oct 10 2017, 2:48 PM
alexcrichton added a comment to D38154: [PassManager] Run global opts after the inliner.

@chandlerc since we saw such a drastic decrease in compile times after including the original version of this patch, could you elaborate on the downsides of what would happen if we were to do that in our local fork of LLVM? Or would it still be unacceptable to send this patch upstream?

Oct 10 2017, 11:42 AM

Jun 24 2017

alexcrichton updated the diff for D34599: [builtins] Flag __builtin_cl* functions as `static`.
Jun 24 2017, 9:53 PM
alexcrichton created D34599: [builtins] Flag __builtin_cl* functions as `static`.
Jun 24 2017, 12:00 PM

Aug 18 2015

alexcrichton updated subscribers of D12099: Fix FREM on 32-bit MSVC on x86.
Aug 18 2015, 9:19 AM