Page MenuHomePhabricator

fitzgen (Nick Fitzgerald)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2017, 11:16 AM (242 w, 4 d)

Recent Activity

Jul 22 2021

fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Removed chunk that shouldn't have been in this patch.

Jul 22 2021, 1:39 PM · Restricted Project, lld
fitzgen added inline comments to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.
Jul 22 2021, 1:37 PM · Restricted Project, lld
fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

@sbc100, would you mind relanding this for me? Thank you!

Jul 22 2021, 12:52 PM · Restricted Project, lld
fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Updated to only hash/compare WasmLimits's Maximum when Flags & WASM_LIMITS_FLAGS_HAS_MAX. This should fix the use of uninitialized data that led to reverting the original commit.

Jul 22 2021, 12:52 PM · Restricted Project, lld
fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

I'm pretty sure the issue was that I was comparing/hashing maximums in WasmLimits's operator== and hash traits unconditionally, rather than only if Flags & WASM_LIMITS_FLAG_HAS_MAX.

Jul 22 2021, 10:43 AM · Restricted Project, lld

Jul 21 2021

fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Is there documentation anywhere on how to build wasm-ld with memory sanitizer enabled?

Jul 21 2021, 4:49 PM · Restricted Project, lld

Jul 20 2021

fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Reverted by 16aac493e59519377071e900d119ba2e7e5b525d due to an use-of-uninitialized-value bug.

Jul 20 2021, 8:52 AM · Restricted Project, lld

Jul 19 2021

fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Rebased.

Jul 19 2021, 1:57 PM · Restricted Project, lld
fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

I'm OK landing this first. Just say when you ready. Still lgtm.

Jul 19 2021, 9:20 AM · Restricted Project, lld

Jul 16 2021

fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Fixed failing tests.

Jul 16 2021, 11:30 AM · Restricted Project, lld
fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

What do you think about landing https://reviews.llvm.org/D106026 first? (would avoid the use of template <typename UndefinedT> in this patch).

Jul 16 2021, 10:44 AM · Restricted Project, lld
fitzgen added inline comments to D106026: [lld][WebAssembly] Cleanup duplicate fields in Symbols.h. NFC.
Jul 16 2021, 10:43 AM · Restricted Project
fitzgen added inline comments to D106026: [lld][WebAssembly] Cleanup duplicate fields in Symbols.h. NFC.
Jul 16 2021, 10:40 AM · Restricted Project
fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Do you have any idea what is up with https://reviews.llvm.org/harbormaster/unit/view/870129/ ? Locally the test passes just fine, and the types certainly look correct to me. It almost looks like whatever version of llvm-mc running in CI doesn't understand ref types properly? Pretty confused here.

@aardappel just added the type checker vary recently (https://reviews.llvm.org/D104945). So maybe you need to update your local branch?

Jul 16 2021, 10:31 AM · Restricted Project, lld

Jul 15 2021

fitzgen added a comment to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Do you have any idea what is up with https://reviews.llvm.org/harbormaster/unit/view/870129/ ? Locally the test passes just fine, and the types certainly look correct to me. It almost looks like whatever version of llvm-mc running in CI doesn't understand ref types properly? Pretty confused here.

Jul 15 2021, 2:03 PM · Restricted Project, lld
fitzgen added inline comments to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.
Jul 15 2021, 1:46 PM · Restricted Project, lld

Jul 14 2021

fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Make it so getImportModuleAndName does not take optional out parameters.

Jul 14 2021, 2:43 PM · Restricted Project, lld

Jul 8 2021

fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Ran clang-format.

Jul 8 2021, 9:18 AM · Restricted Project, lld

Jul 7 2021

fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Rewrote duplicate-function-imports.ll into duplicate-function-imports.s.

Jul 7 2021, 3:01 PM · Restricted Project, lld
fitzgen updated the diff for D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.

Updated based on review feedback:

Jul 7 2021, 2:48 PM · Restricted Project, lld
fitzgen added inline comments to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.
Jul 7 2021, 2:45 PM · Restricted Project, lld
fitzgen added inline comments to D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.
Jul 7 2021, 1:40 PM · Restricted Project, lld

Jul 6 2021

fitzgen requested review of D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type.
Jul 6 2021, 5:54 PM · Restricted Project, lld

Dec 6 2019

fitzgen added a comment to D70738: [libFuzzer] Add custom output function.

Thanks for the in-depth replies, @kcc and @vitalybuka.

Dec 6 2019, 1:20 PM · Restricted Project, Restricted Project

Dec 3 2019

fitzgen added a comment to D70738: [libFuzzer] Add custom output function.

Hi, I'd just like to voice my support for this functionality as another user of cargo-fuzz.

Dec 3 2019, 10:24 AM · Restricted Project, Restricted Project

Nov 8 2018

fitzgen added a comment to D54279: wasm32: Respect `--no-mangle` in more locations in LLD.

Do you even want mangled names in the names section?

Nov 8 2018, 3:48 PM

Aug 8 2018

fitzgen accepted D50424: [WebAssembly] Group rodata into a single output segment.

Looks good to me!

Aug 8 2018, 10:09 AM

May 8 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

Hi Sam,

May 8 2018, 5:34 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.

The test data is now named @a, @b, @c, @d.

May 8 2018, 5:33 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.

This iteration has a single .ll test file that checks both merging and separate data segments.

May 8 2018, 3:17 PM

May 7 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

Ok, I've added two tests: one for when we do --no-merge-data-segments and one for when we don't.

May 7 2018, 1:42 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.
May 7 2018, 1:41 PM
fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

FYI the tests are pretty simple. They live in 'test/wasm' and can be run using llvm-lit. The command I normally run is ninja && ./bin/llvm-lit ../llvm/tools/lld/test

It looks like these tests might require llc, llvm-as, etc, but I can't figure out how to enable building them. I get this when I run the tests:

May 7 2018, 1:16 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.
May 7 2018, 1:11 PM
fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

FYI the tests are pretty simple. They live in 'test/wasm' and can be run using llvm-lit. The command I normally run is ninja && ./bin/llvm-lit ../llvm/tools/lld/test

May 7 2018, 1:11 PM

May 4 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

FYI the tests are pretty simple. They live in 'test/wasm' and can be run using llvm-lit. The command I normally run is ninja && ./bin/llvm-lit ../llvm/tools/lld/test

May 4 2018, 5:07 PM

May 3 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

I don't know how to write a test for lld -- would appreciate some guidance doing that!

May 3 2018, 7:17 PM
fitzgen created D46417: wasm: Add a flag to control merging data segments.
May 3 2018, 7:12 PM