Page MenuHomePhabricator

fitzgen (Nick Fitzgerald)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2017, 11:16 AM (184 w, 5 d)

Recent Activity

Dec 6 2019

fitzgen added a comment to D70738: [libFuzzer] Add custom output function.

Thanks for the in-depth replies, @kcc and @vitalybuka.

Dec 6 2019, 1:20 PM · Restricted Project, Restricted Project

Dec 3 2019

fitzgen added a comment to D70738: [libFuzzer] Add custom output function.

Hi, I'd just like to voice my support for this functionality as another user of cargo-fuzz.

Dec 3 2019, 10:24 AM · Restricted Project, Restricted Project

Nov 8 2018

fitzgen added a comment to D54279: wasm32: Respect `--no-mangle` in more locations in LLD.

Do you even want mangled names in the names section?

Nov 8 2018, 3:48 PM

Aug 8 2018

fitzgen accepted D50424: [WebAssembly] Group rodata into a single output segment.

Looks good to me!

Aug 8 2018, 10:09 AM

May 8 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

Hi Sam,

May 8 2018, 5:34 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.

The test data is now named @a, @b, @c, @d.

May 8 2018, 5:33 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.

This iteration has a single .ll test file that checks both merging and separate data segments.

May 8 2018, 3:17 PM

May 7 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

Ok, I've added two tests: one for when we do --no-merge-data-segments and one for when we don't.

May 7 2018, 1:42 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.
May 7 2018, 1:41 PM
fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

FYI the tests are pretty simple. They live in 'test/wasm' and can be run using llvm-lit. The command I normally run is ninja && ./bin/llvm-lit ../llvm/tools/lld/test

It looks like these tests might require llc, llvm-as, etc, but I can't figure out how to enable building them. I get this when I run the tests:

May 7 2018, 1:16 PM
fitzgen updated the diff for D46417: wasm: Add a flag to control merging data segments.
May 7 2018, 1:11 PM
fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

FYI the tests are pretty simple. They live in 'test/wasm' and can be run using llvm-lit. The command I normally run is ninja && ./bin/llvm-lit ../llvm/tools/lld/test

May 7 2018, 1:11 PM

May 4 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

FYI the tests are pretty simple. They live in 'test/wasm' and can be run using llvm-lit. The command I normally run is ninja && ./bin/llvm-lit ../llvm/tools/lld/test

May 4 2018, 5:07 PM

May 3 2018

fitzgen added a comment to D46417: wasm: Add a flag to control merging data segments.

I don't know how to write a test for lld -- would appreciate some guidance doing that!

May 3 2018, 7:17 PM
fitzgen created D46417: wasm: Add a flag to control merging data segments.
May 3 2018, 7:12 PM