This is an archive of the discontinued LLVM Phabricator instance.

Differential D45588

Start reserving x18 by default on Android targets.
ClosedPublic

Authored by pcc on Apr 12 2018, 1:16 PM.

Details

Reviewers
srhines
eugenis
vlad.tsyrklevich
kcc
javed.absar
Commits
rG9c9c8b22d2ea: Start reserving x18 by default on Android targets.
rL340889: Start reserving x18 by default on Android targets.
rC340889: Start reserving x18 by default on Android targets.

Diff Detail

Repository
rC Clang

Event Timeline

pcc created this revision.Apr 12 2018, 1:16 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptApr 12 2018, 1:16 PM
Harbormaster completed remote builds in B17033: Diff 142246.Apr 12 2018, 1:16 PM
kcc added a comment.Apr 12 2018, 5:18 PM

Don't you need a test?
srhines@, what kind of documentation change need to be done?

pcc updated this revision to Diff 142321.Apr 12 2018, 8:07 PM
  • Add test
pcc added a comment.Apr 12 2018, 8:07 PM
In D45588#1066620, @kcc wrote:

Don't you need a test?

Probably the easiest way to test this is to check that clang -fsanitize=shadow-call-stack does not complain about needing -ffixed-x18, so that is what I've done.

Harbormaster completed remote builds in B17050: Diff 142321.Apr 12 2018, 8:07 PM
kcc added a comment.Apr 13 2018, 11:07 AM

This test is great, but I'd like to also see some more direct test, maybe something in tools/clang/test/Driver/aarch64-fixed-x18.c?

LGTM for the code, but I still want to hear LGTM from srhines@

pcc updated this revision to Diff 142448.Apr 13 2018, 11:32 AM
  • Add LLVM code generation test
Herald added a subscriber: javed.absar. · View Herald TranscriptApr 13 2018, 11:32 AM
Harbormaster completed remote builds in B17076: Diff 142448.Apr 13 2018, 11:33 AM
pcc added a comment.Apr 13 2018, 11:34 AM
In D45588#1067402, @kcc wrote:

This test is great, but I'd like to also see some more direct test, maybe something in tools/clang/test/Driver/aarch64-fixed-x18.c?

That won't test what we want here because the platform defaults are not applied via target features. I added a case for Android to one of the code generation tests.

kcc added a comment.Apr 13 2018, 11:35 AM

Yep, that's the one, thanks!

pcc added a comment.Aug 28 2018, 3:26 PM

@srhines Ping.

Herald added a reviewer: javed.absar. · View Herald TranscriptAug 28 2018, 3:26 PM
srhines accepted this revision.Aug 28 2018, 6:00 PM

Sorry, this got buried in my inbox back in April right before EuroLLVM.

This revision is now accepted and ready to land.Aug 28 2018, 6:00 PM
Closed by commit rC340889: Start reserving x18 by default on Android targets. (authored by pcc). · Explain WhyAug 28 2018, 6:39 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: cfe-commits. · View Herald TranscriptAug 28 2018, 6:39 PM

Revision Contents

PathSize
test/
Driver/
3 lines

Diff 163003

test/Driver/sanitizer-ld.c

Show First 20 Lines • Show All 569 Lines • ▼ Show 20 Lines
// CHECK-SHADOWCALLSTACK-LINUX-AARCH64: '-fsanitize=shadow-call-stack' only allowed with '-ffixed-x18' // CHECK-SHADOWCALLSTACK-LINUX-AARCH64: '-fsanitize=shadow-call-stack' only allowed with '-ffixed-x18'
// RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \
// RUN: -target aarch64-unknown-linux -fuse-ld=ld -ffixed-x18 \ // RUN: -target aarch64-unknown-linux -fuse-ld=ld -ffixed-x18 \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s
// RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \
// RUN: -target arm64-unknown-ios -fuse-ld=ld \ // RUN: -target arm64-unknown-ios -fuse-ld=ld \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s
// RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \
// RUN: -target aarch64-unknown-linux-android -fuse-ld=ld \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s
// CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18-NOT: error: // CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18-NOT: error:
// RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \
// RUN: -target x86-unknown-linux -fuse-ld=ld \ // RUN: -target x86-unknown-linux -fuse-ld=ld \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-X86 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-X86 %s
// CHECK-SHADOWCALLSTACK-LINUX-X86: error: unsupported option '-fsanitize=shadow-call-stack' for target 'x86-unknown-linux' // CHECK-SHADOWCALLSTACK-LINUX-X86: error: unsupported option '-fsanitize=shadow-call-stack' for target 'x86-unknown-linux'
// RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack %s -### -o %t.o 2>&1 \
▲ Show 20 Lines • Show All 255 Lines • Show Last 20 Lines