[clang-format] Wildcard expansion on Windows.

[alexfh]

Summary

Add support for wildcard expansion in command line arguments on Windows.
See https://docs.microsoft.com/en-us/cpp/c-language/expanding-wildcard-arguments

Fixes https://bugs.llvm.org/show_bug.cgi?id=17217

[zturner]

Never seen this PURE_WINDOWS CMake variable. How is it different than MSVC?

[smeenai]

PURE_WINDOWS is all Windows except Cygwin. It's an LLVM thing, not a CMake thing.

I don't know if setargv.obj is available on MinGW, and even if it is it's probably not gonna have the .obj extension, so this should probably be limited to MSVC.

[rnk]

Use llvm::sys::Process::GetArgumentVector, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.

[alexfh]

In D44778#1046251, @rnk wrote:

Use llvm::sys::Process::GetArgumentVector, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.

I vaguely remember that windows console applications have to define wmain() instead of main() in order to work with unicode. Does llvm::sys::Process::GetArgumentVector allow to work around this?

[alexfh]

In D44778#1046301, @alexfh wrote:

In D44778#1046251, @rnk wrote:

Use llvm::sys::Process::GetArgumentVector, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.

I vaguely remember that windows console applications have to define wmain() instead of main() in order to work with unicode. Does llvm::sys::Process::GetArgumentVector allow to work around this?

Never mind. I looked at the windows implementation and see how =)

Thanks for the pointer. I'll update the patch.

[alexfh]

• Use llvm::sys::Process::GetArgumentVector.

[alexfh]

I've not tested this on Windows, but I hope llvm::sys::Process::GetArgumentVector should have been tested by someone already.

[rnk]

lgtm

tools/clang-format/ClangFormat.cpp

348

s/couldn'g/couldn't/

tools/clang-format/ClangFormat.cpp

 #include "clang/Basic/DiagnosticOptions.h"
 #include "clang/Basic/FileManager.h"
 #include "clang/Basic/SourceManager.h"
 #include "clang/Basic/Version.h"
 #include "clang/Format/Format.h"
 #include "clang/Rewrite/Core/Rewriter.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/FileSystem.h"
+#include "llvm/Support/Process.h"
 #include "llvm/Support/Signals.h"
 
 using namespace llvm;
 using clang::tooling::Replacements;
 
 static cl::opt<bool> Help("h", cl::desc("Alias for -help"), cl::Hidden);
 
 // Mark all our options with this category, everything else (except for -version

 
 static void PrintVersion(raw_ostream &OS) {
   OS << clang::getClangToolFullVersion("clang-format") << '\n';
 }
 
 int main(int argc, const char **argv) {
   llvm::sys::PrintStackTraceOnErrorSignal(argv[0]);
 
+  SmallVector<const char *, 256> Args;
+  llvm::SpecificBumpPtrAllocator<char> ArgAllocator;
+  std::error_code EC = llvm::sys::Process::GetArgumentVector(
+      Args, llvm::makeArrayRef(argv, argc), ArgAllocator);
+  if (EC) {
+    llvm::errs() << "error: couldn't get arguments: " << EC.message() << '\n';
+  }
+
   cl::HideUnrelatedOptions(ClangFormatCategory);
 
   cl::SetVersionPrinter(PrintVersion);
   cl::ParseCommandLineOptions(
-      argc, argv,
+      Args.size(), &Args[0],
       "A tool to format C/C++/Java/JavaScript/Objective-C/Protobuf code.\n\n"
       "If no arguments are specified, it formats the code from standard input\n"
       "and writes the result to the standard output.\n"
       "If <file>s are given, it reformats the files. If -i is specified\n"
       "together with <file>s, the files are edited in-place. Otherwise, the\n"
       "result is written to the standard output.\n");
 
   if (Help) {