[clang-format] Wildcard expansion on Windows.

[alexfh]

Summary

Add support for wildcard expansion in command line arguments on Windows.
See https://docs.microsoft.com/en-us/cpp/c-language/expanding-wildcard-arguments

Fixes https://bugs.llvm.org/show_bug.cgi?id=17217

[zturner]

Never seen this PURE_WINDOWS CMake variable. How is it different than MSVC?

[smeenai]

PURE_WINDOWS is all Windows except Cygwin. It's an LLVM thing, not a CMake thing.

I don't know if setargv.obj is available on MinGW, and even if it is it's probably not gonna have the .obj extension, so this should probably be limited to MSVC.

[rnk]

Use llvm::sys::Process::GetArgumentVector, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.

[alexfh]

In D44778#1046251, @rnk wrote:

Use llvm::sys::Process::GetArgumentVector, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.

I vaguely remember that windows console applications have to define wmain() instead of main() in order to work with unicode. Does llvm::sys::Process::GetArgumentVector allow to work around this?

[alexfh]

In D44778#1046301, @alexfh wrote:

In D44778#1046251, @rnk wrote:

Use llvm::sys::Process::GetArgumentVector, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.

I vaguely remember that windows console applications have to define wmain() instead of main() in order to work with unicode. Does llvm::sys::Process::GetArgumentVector allow to work around this?

Never mind. I looked at the windows implementation and see how =)

Thanks for the pointer. I'll update the patch.

[alexfh]

• Use llvm::sys::Process::GetArgumentVector.

[alexfh]

I've not tested this on Windows, but I hope llvm::sys::Process::GetArgumentVector should have been tested by someone already.

[rnk]

lgtm

tools/clang-format/ClangFormat.cpp

348 ↗

(On Diff #139593)

s/couldn'g/couldn't/

tools/clang-format/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS support)
 
 add_clang_tool(clang-format
   ClangFormat.cpp
   )
 
+if( PURE_WINDOWS )
+  # Add support for wildcard expansion in command-line arguments on Windows.
+  # See
+  # https://docs.microsoft.com/en-us/cpp/c-language/expanding-wildcard-arguments
+  set_property(TARGET clang-format APPEND_STRING PROPERTY
+    LINK_FLAGS " setargv.obj")
+endif()
+
 set(CLANG_FORMAT_LIB_DEPS
   clangBasic
   clangFormat
   clangRewrite
   clangToolingCore
   )
 
 target_link_libraries(clang-format