Page MenuHomePhabricator

[libcxx] Disable tautological-type-limit-compare warning
AbandonedPublic

Authored by bcain on Jan 4 2018, 8:54 AM.

Details

Summary

Clang change to "cripple" the warning (rC321691) was not effective for libcxx because we opt-in to Wextra

But since the warning is partitioned now, we could opt-out of this specific one?

Diff Detail

Repository
rCXX libc++

Event Timeline

bcain created this revision.Jan 4 2018, 8:54 AM

Note that it won't help for the cases where libc++ is used, and -Wextra -Wsystem-headers is specified.

bcain added a comment.Jan 4 2018, 9:09 AM

Note that it won't help for the cases where libc++ is used, and -Wextra -Wsystem-headers is specified.

I think that's acceptable and I think we should have known/expected that as of the change to clang.

The only real way to mitigate that is with a local pragma to disable the warning for those spots, correct? And I believe that had been proposed and rejected before.

smeenai added a subscriber: smeenai.Jan 4 2018, 1:43 PM
lebedev.ri added inline comments.Jan 16 2018, 9:11 AM
libcxx/utils/libcxx/test/config.py
904

Why not self.cxx.addWarningFlagIfSupported('-Wno-tautological-type-limit-compare'), like seen on the next lines ?

LGTM with the change mentioned by @lebedev.ri .

bcain added a comment.Jan 17 2018, 3:21 PM

LGTM with the change mentioned by @lebedev.ri .

I agree that the change suggested is a good one but from the cfe-dev discussion this change may be obsolete. It sounds like the plan is to remove the warning from Wextra.

@bcain Can we land it and then revert it once Clang decides what it's up to? That way we can get the 32bit builder green?

@bcain Can we land it and then revert it once Clang decides what it's up to? That way we can get the 32bit builder green?

+Nico who's I believe working on moving the bad flag out of -Wextra.

bcain updated this revision to Diff 130431.Jan 18 2018, 9:49 AM

Changed per review

bcain abandoned this revision.Aug 17 2018, 12:42 PM

I think this is now obsolete due to clang changing the warning.