Page MenuHomePhabricator

[AMDGPU, AsmParser] Enable the mnemonic spell corrector.
ClosedPublic

Authored by Quolyk on Nov 30 2017, 12:18 AM.

Details

Diff Detail

Event Timeline

Quolyk created this revision.Nov 30 2017, 12:18 AM
Quolyk edited the summary of this revision. (Show Details)Nov 30 2017, 12:21 AM
arsenm accepted this revision.Nov 30 2017, 10:34 AM

LGTM

This revision is now accepted and ready to land.Nov 30 2017, 10:34 AM
sdardis added inline comments.Nov 30 2017, 10:54 AM
test/MC/AMDGPU/invalid-instructions-spellcheck.s
2

You can drop -show-encoding from this as you're not testing the encoding.

Quolyk updated this revision to Diff 125077.Nov 30 2017, 10:37 PM

Deleted -show-encoding from test

Quolyk marked an inline comment as done.Nov 30 2017, 10:38 PM

BTW, I don't have commit access.

arsenm requested changes to this revision.Dec 20 2017, 10:32 AM

There is a test failure with this. This seems to do the wrong thing when there are subtarget differences with the instruction.

Failing test test/MC/AMDGPU/vop1-gfx9-err.s

This revision now requires changes to proceed.Dec 20 2017, 10:32 AM
arsenm accepted this revision.Dec 20 2017, 10:53 AM

I fixed the test, but the errors are still not great. They weren't great before, so it is only tangentially related.

This revision is now accepted and ready to land.Dec 20 2017, 10:53 AM
arsenm closed this revision.Dec 20 2017, 10:54 AM

r321202