This is an archive of the discontinued LLVM Phabricator instance.

[asan] Use dynamic shadow on 32-bit Android, try 2.
ClosedPublic

Authored by eugenis on Nov 17 2017, 5:40 PM.

Details

Summary

This change reverts r318575 and change FindDynamicShadowStart() to
keep the memory range it found mapped PROT_NONE to make sure it is
not reused. We also skip MemoryRangeIsAvailable() check, because is
is (a) unnecessary, and (b) would fail anyway.

Event Timeline

eugenis created this revision.Nov 17 2017, 5:40 PM
pcc edited edge metadata.Nov 17 2017, 5:57 PM

Could you show me a diff against your revert of r318575?

pcc accepted this revision.Nov 17 2017, 6:23 PM

LGTM

This revision is now accepted and ready to land.Nov 17 2017, 6:23 PM
eugenis updated this revision to Diff 123609.Nov 20 2017, 9:41 AM

align PremapShadowSize(), too

This revision was automatically updated to reflect the committed changes.