This is an archive of the discontinued LLVM Phabricator instance.

[asan] Test ASan instrumentation for shadow scale value of 5
ClosedPublic

Authored by waltl on Nov 7 2017, 4:26 PM.

Details

Summary

Add additional RUN clauses to test for -asan-mapping-scale=5 in
selective tests, with special CHECK statements where needed.

Event Timeline

waltl created this revision.Nov 7 2017, 4:26 PM
waltl updated this revision to Diff 122461.Nov 10 2017, 9:19 AM

Change approach to only override shadow scale in compiler_rt

waltl updated this revision to Diff 122692.Nov 13 2017, 11:01 AM

Add test for metadata_array alignment

vitalybuka requested changes to this revision.Nov 15 2017, 4:24 PM
vitalybuka added inline comments.
llvm/test/Instrumentation/AddressSanitizer/test64.ll
1–2

Looks to complicated. I'd prefer if you:

  1. don't move files into ShadowScale3
  2. Remove %opt_asan
  3. remove asan_test_shadow_scale and just add additional RUN: in tests where it makes sense. E.g.:

; RUN: %opt < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S3 %s
; RUN: %opt -asan-mapping-scale=5 < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S5 %s

This revision now requires changes to proceed.Nov 15 2017, 4:24 PM
waltl updated this revision to Diff 123242.Nov 16 2017, 2:25 PM
waltl edited edge metadata.

Address CR comments

waltl marked an inline comment as done.Nov 16 2017, 2:28 PM
waltl added inline comments.
llvm/test/Instrumentation/AddressSanitizer/test64.ll
1–2

Done. I selectively enabled some tests; it seems that the stack-poisoning/stack_layout tests are useful as well but they are harder to port, so perhaps I'll do that in a separate commit.

waltl edited the summary of this revision. (Show Details)Nov 16 2017, 2:31 PM
This revision is now accepted and ready to land.Nov 16 2017, 3:37 PM
This revision was automatically updated to reflect the committed changes.
waltl marked an inline comment as done.