[asan] Ensure that the minimum redzone is at least SHADOW_GRANULARITY
ClosedPublic
Actions

Authored by waltl on Oct 31 2017, 1:58 PM.

Details

Reviewers

vitalybuka
eugenis
alekseyshl

Commits

rG13a3cf3b6a23: [asan] Ensure that the minimum redzone is at least SHADOW_GRANULARITY
rCRT318422: [asan] Ensure that the minimum redzone is at least SHADOW_GRANULARITY
rL318422: [asan] Ensure that the minimum redzone is at least SHADOW_GRANULARITY

Summary

This is required by the Asan run-time.

Diff Detail

Build Status

Buildable 11685
Build 11685: arc lint + arc unit

Event Timeline

waltl created this revision.Oct 31 2017, 1:58 PM

Herald added a subscriber: kubamracek. · View Herald TranscriptOct 31 2017, 1:58 PM

kosarev added a subscriber: kosarev.Nov 1 2017, 1:38 AM

waltl added reviewers: vitalybuka, eugenis, alekseyshl.Nov 7 2017, 5:01 PM

waltl added subscribers: kcc, llvm-commits.

vitalybuka added inline comments.Nov 15 2017, 2:39 PM

compiler-rt/lib/asan/asan_activation.cc
117	disabled.max_redzone = disabled.min_redzone
compiler-rt/lib/asan/asan_flags.cc
73	This should be around line 147, // Flag validation:

Address CR comments

waltl marked 2 inline comments as done.Nov 16 2017, 8:05 AM

Harbormaster completed remote builds in B12241: Diff 123184.Nov 16 2017, 8:06 AM

vitalybuka accepted this revision.Nov 16 2017, 8:24 AM

This revision is now accepted and ready to land.Nov 16 2017, 8:24 AM

Closed by commit rL318422: [asan] Ensure that the minimum redzone is at least SHADOW_GRANULARITY (authored by waltl). · Explain WhyNov 16 2017, 9:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

compiler-rt/

lib/

asan/

asan_activation.cc

7 lines

asan_flags.cc

2 lines

Diff 121051

View Options

compiler-rt/lib/asan/asan_activation.cc