This is an archive of the discontinued LLVM Phabricator instance.

[asan] Ensure that the minimum redzone is at least SHADOW_GRANULARITY
ClosedPublic

Authored by waltl on Oct 31 2017, 1:58 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

waltl created this revision.Oct 31 2017, 1:58 PM
kosarev added a subscriber: kosarev.Nov 1 2017, 1:38 AM
vitalybuka added inline comments.Nov 15 2017, 2:39 PM
compiler-rt/lib/asan/asan_activation.cc
117 ↗(On Diff #121051)

disabled.max_redzone = disabled.min_redzone

compiler-rt/lib/asan/asan_flags.cc
73 ↗(On Diff #121051)

This should be around line 147, // Flag validation:

waltl updated this revision to Diff 123184.Nov 16 2017, 8:04 AM

Address CR comments

waltl marked 2 inline comments as done.Nov 16 2017, 8:05 AM
vitalybuka accepted this revision.Nov 16 2017, 8:24 AM
This revision is now accepted and ready to land.Nov 16 2017, 8:24 AM
This revision was automatically updated to reflect the committed changes.