Enable profile on NetBSD

[krytarowski]

Summary

make check-profile:

Failing Tests (2):

  Profile-i386 :: instrprof-dlopen.test
  Profile-x86_64 :: instrprof-dlopen.test

Expected Passes    : 64
Unsupported Tests  : 42
Unexpected Failures: 2

Sponsored by <The NetBSD Foundation>

[vsk]

What's causing the test failure? Do you plan on XFAIL'ing the test on NetBSD initially?

[krytarowski]

In D36603#839335, @vsk wrote:

What's causing the test failure? Do you plan on XFAIL'ing the test on NetBSD initially?

Right now I'm upstreaming what works (close to 99% including other sanitizers). Later I will work on the remaining issues (including XFAIL marks) and attaching NetBSD buildbot.

[vsk]

I think it would be better to XFAIL the test from the onset so that people reading the source are aware of the issue. That way, if for any reason this can't make its way back on your priority list, the build will remain in good shape.

[krytarowski]

In D36603#839356, @vsk wrote:

I think it would be better to XFAIL the test from the onset so that people reading the source are aware of the issue. That way, if for any reason this can't make its way back on your priority list, the build will remain in good shape.

This does not affect the build, only one test in both archs.

I will be back to corrections later (at least filing problem reports on bugzilla).

[vsk]

In D36603#840139, @krytarowski wrote:

In D36603#839356, @vsk wrote:

I think it would be better to XFAIL the test from the onset so that people reading the source are aware of the issue. That way, if for any reason this can't make its way back on your priority list, the build will remain in good shape.

This does not affect the build, only one test in both archs.

By 'the build', I meant the compiler-rt test targets on NetBSD machines. As-is, this patch breaks those test targets, and may bewilder users.

I will be back to corrections later (at least filing problem reports on bugzilla).

If there are known correctness issues with a patch, there's no need to rush it through. Please use more caution. All it takes here is to add an "XFAIL: *netbsd" line to the test.

[krytarowski]

I've reverted the commit on demand.

I was trying to restore the setup for check-profile after upgrading the sources.. and I hit new failures.

http://www.netbsd.org/~kamil/llvm/check-profile

I have new failures in sanitizers too.. Maybe my SVN checkout was in a faulty revision. For now I will move on and focus on sanitizers.

[vsk]

In D36603#841785, @krytarowski wrote:

I've reverted the commit on demand.

I was trying to restore the setup for check-profile after upgrading the sources.. and I hit new failures.

http://www.netbsd.org/~kamil/llvm/check-profile

I have new failures in sanitizers too.. Maybe my SVN checkout was in a faulty revision. For now I will move on and focus on sanitizers.

If you see these failures again, could you upload the *.profdata files from:
/public/llvm-build/projects/compiler-rt/test/profile/

I can help take a look.

[krytarowski]

I've compressed the whole directory (for which I had more issues) and uploaded:

http://www.netbsd.org/~kamil/llvm/profile.tar.bz2 1.5MB

cmake/config-ix.cmake

 if (COMPILER_RT_HAS_SANITIZER_COMMON AND MSAN_SUPPORTED_ARCH AND
     OS_NAME MATCHES "Linux")
   set(COMPILER_RT_HAS_MSAN TRUE)
 else()
   set(COMPILER_RT_HAS_MSAN FALSE)
 endif()
 
 if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
-    OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows|Android")
+    OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows|Android|NetBSD")
   set(COMPILER_RT_HAS_PROFILE TRUE)
 else()
   set(COMPILER_RT_HAS_PROFILE FALSE)
 endif()
 
 if (COMPILER_RT_HAS_SANITIZER_COMMON AND TSAN_SUPPORTED_ARCH AND
     OS_NAME MATCHES "Darwin|Linux|FreeBSD|Android")
   set(COMPILER_RT_HAS_TSAN TRUE)

test/profile/lit.cfg

 config.substitutions.append( ("%clang_profgen_gcc=", build_invocation(clang_cflags) + " -fprofile-generate=") )
 config.substitutions.append( ("%clang_profuse_gcc=", build_invocation(clang_cflags) + " -fprofile-use=") )
 
 config.substitutions.append( ("%clang_profuse=", build_invocation(clang_cflags) + " -fprofile-instr-use=") )
 config.substitutions.append( ("%clangxx_profuse=", build_invocation(clang_cxxflags) + " -fprofile-instr-use=") )
 
 config.substitutions.append( ("%clang_lto_profgen=", build_invocation(clang_cflags, True) + " -fprofile-instr-generate=") )
 
-if config.host_os not in ['Darwin', 'FreeBSD', 'Linux']:
+if config.host_os not in ['Darwin', 'FreeBSD', 'Linux', 'NetBSD']:
   config.unsupported = True
 
 if config.target_arch in ['armv7l']:
   config.unsupported = True