This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer_common] Fuchsia OS support code
ClosedPublic

Authored by mcgrathr on Jul 28 2017, 3:42 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

mcgrathr created this revision.Jul 28 2017, 3:42 PM
vitalybuka accepted this revision.Jul 28 2017, 4:23 PM

I looked sanitizer_fuchsia.cc very briefly.
The rest LGTM

lib/sanitizer_common/sanitizer_printf.cc
260 ↗(On Diff #108731)

I guess you would like to enabled as many as possible compiler-rt tests in future
So maybe better to avoid diverging if this is not critical?

This revision is now accepted and ready to land.Jul 28 2017, 4:23 PM
mcgrathr added inline comments.Jul 28 2017, 4:27 PM
lib/sanitizer_common/sanitizer_printf.cc
260 ↗(On Diff #108731)

I will be getting the tests going at some point.
The logging story is very different on Fuchsia, so there will be a bunch more work in getting the tests right.
We absolutely do not want the sanitizer logging to do this kind of tagging for Fuchsia.

mcgrathr updated this revision to Diff 109169.Aug 1 2017, 12:05 PM

This is rebased and ready to land after D36029 lands.
Please land it for me!

Thanks,
Roland

This revision was automatically updated to reflect the committed changes.