Page MenuHomePhabricator

[clang-tidy] Add a close-on-exec check on inotify_init() in Android module.
ClosedPublic

Authored by yawanng on Jul 13 2017, 10:45 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

yawanng created this revision.Jul 13 2017, 10:45 AM
yawanng edited the summary of this revision. (Show Details)Jul 13 2017, 10:53 AM
yawanng edited the summary of this revision. (Show Details)Jul 13 2017, 11:00 AM
Eugene.Zelenko edited reviewers, added: alexfh, aaron.ballman, hokein; removed: chh.Jul 13 2017, 11:21 AM
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
chh added a subscriber: chh.Jul 13 2017, 12:01 PM
Eugene.Zelenko added inline comments.
docs/ReleaseNotes.rst
60 ↗(On Diff #106464)

Please sort checks in alphabetical order.

yawanng updated this revision to Diff 106517.Jul 13 2017, 1:44 PM
yawanng marked an inline comment as done.
alexfh requested changes to this revision.Jul 15 2017, 1:22 AM

See the comment on D35372.

This revision now requires changes to proceed.Jul 15 2017, 1:22 AM
yawanng updated this revision to Diff 110646.Aug 10 2017, 4:13 PM
yawanng edited edge metadata.
hokein added inline comments.Aug 11 2017, 7:10 AM
clang-tidy/android/CloexecInotifyInitCheck.cpp
27 ↗(On Diff #110646)

The parameter 2 and 3 are not clear at the first glance. Maybe add /*WarningMsg=*/, and /*FixMsg=*/.

test/clang-tidy/android-cloexec-inotify-init.cpp
8 ↗(On Diff #110646)

nit: trailing ;.

yawanng updated this revision to Diff 110749.Aug 11 2017, 9:58 AM
yawanng marked an inline comment as done.
yawanng marked an inline comment as done.
hokein accepted this revision.Aug 14 2017, 1:22 AM

LGTM

This revision was automatically updated to reflect the committed changes.