Page MenuHomePhabricator

[clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.
ClosedPublic

Authored by yawanng on Jul 13 2017, 10:39 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

yawanng created this revision.Jul 13 2017, 10:39 AM
yawanng edited the summary of this revision. (Show Details)Jul 13 2017, 10:54 AM
yawanng edited the summary of this revision. (Show Details)Jul 13 2017, 11:01 AM
Eugene.Zelenko edited reviewers, added: alexfh, hokein, aaron.ballman; removed: chh.Jul 13 2017, 11:17 AM
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
chh added a subscriber: chh.Jul 13 2017, 11:59 AM
Eugene.Zelenko added inline comments.
clang-tidy/android/CloexecEpollCreate1Check.cpp
21 ↗(On Diff #106457)

Please make this declaration consent across all checks. In some checks it declared inside namespaces, in some - outside.

docs/ReleaseNotes.rst
60 ↗(On Diff #106457)

Please sort checks in alphabetical order.

yawanng updated this revision to Diff 106523.Jul 13 2017, 1:54 PM
yawanng marked 2 inline comments as done.
alexfh requested changes to this revision.Jul 15 2017, 1:28 AM

See the comment on D35372.

This revision now requires changes to proceed.Jul 15 2017, 1:28 AM
yawanng updated this revision to Diff 110652.Aug 10 2017, 4:42 PM
yawanng edited edge metadata.
yawanng updated this revision to Diff 110752.Aug 11 2017, 10:04 AM
This revision is now accepted and ready to land.Aug 16 2017, 8:28 AM
This revision was automatically updated to reflect the committed changes.