[COFF, ARM64] Set the data type widths and the data layout string
ClosedPublic

Authored by mgrang on Thu, Jun 29, 7:16 PM.

Details

Summary

COFF ARM64 is LLP64 platform. So int is 4 bytes, long is 4 bytes and long long is 8 bytes.

Diff Detail

Repository
rL LLVM
mgrang created this revision.Thu, Jun 29, 7:16 PM
compnerd accepted this revision.Thu, Jun 29, 10:44 PM

Can you please double check the type of long double as well?

lib/Basic/Targets.cpp
6583 ↗(On Diff #104807)

Typo: platform.

This revision is now accepted and ready to land.Thu, Jun 29, 10:44 PM
mgrang updated this revision to Diff 106811.Sun, Jul 16, 11:06 AM

Fixed typo.
Added size for long double.
Added test cases.

mgrang marked an inline comment as done.Sun, Jul 16, 11:10 AM
efriedma added inline comments.
lib/Basic/Targets.cpp
6662 ↗(On Diff #106811)

If you're changing LongDoubleWidth and LongDoubleAlign, you also have to change LongDoubleFormat.

mgrang updated this revision to Diff 106925.Mon, Jul 17, 1:07 PM
mgrang retitled this revision from [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64 to [COFF, ARM64] Set the data type widths and the data layout string.
mgrang set the repository for this revision to rL LLVM.
mgrang marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.