This is an archive of the discontinued LLVM Phabricator instance.

[COFF, ARM64] Correct the data layout string for COFF ARM64 target
ClosedPublic

Authored by mgrang on Jun 29 2017, 7:13 PM.

Download Raw Diff

Details

Reviewers

compnerd
ruiu
rnk

Summary

COFF ARM64 is LLP64 platform. So int is 4 bytes, long is 4 bytes and long long is 8 bytes.

Diff Detail

Repository: rL LLVM

Event Timeline

mgrang created this revision.Jun 29 2017, 7:13 PM

Herald added subscribers: kristof.beyls, javed.absar, aemerson. · View Herald TranscriptJun 29 2017, 7:13 PM

compnerd accepted this revision.Jun 29 2017, 10:46 PM

This revision is now accepted and ready to land.Jun 29 2017, 10:46 PM

efriedma added a subscriber: efriedma.Jun 30 2017, 11:32 AM

efriedma added inline comments.

lib/Target/AArch64/AArch64TargetMachine.cpp
185	Are you intentionally dropping the "-n32:64-S128" part of the string?

Matched the data layout string to the one in D34859

mgrang added a parent revision: D34859: [COFF, ARM64] Set the data type widths and the data layout string.Jul 16 2017, 5:07 PM

Committed here: https://reviews.llvm.org/rL308223

mgrang closed this revision.Jul 17 2017, 2:29 PM

Revision Contents

Path

Size

lib/

Target/

AArch64/

AArch64TargetMachine.cpp

2 lines

Diff 106812

lib/Target/AArch64/AArch64TargetMachine.cpp

	Show First 20 Lines • Show All 176 Lines • ▼ Show 20 Lines
	static std::string computeDataLayout(const Triple &TT,			static std::string computeDataLayout(const Triple &TT,
	const MCTargetOptions &Options,			const MCTargetOptions &Options,
	bool LittleEndian) {			bool LittleEndian) {
	if (Options.getABIName() == "ilp32")			if (Options.getABIName() == "ilp32")
	return "e-m:e-p:32:32-i8:8-i16:16-i64:64-S128";			return "e-m:e-p:32:32-i8:8-i16:16-i64:64-S128";
	if (TT.isOSBinFormatMachO())			if (TT.isOSBinFormatMachO())
	return "e-m:o-i64:64-i128:128-n32:64-S128";			return "e-m:o-i64:64-i128:128-n32:64-S128";
	if (TT.isOSBinFormatCOFF())			if (TT.isOSBinFormatCOFF())
	return "e-m:w-i64:64-i128:128-n32:64-S128";			return "e-m:w-p:64:64-i32:32-i64:64-i128:128-n32:64-S128";
				efriedmaUnsubmitted Not Done Reply Inline Actions Are you intentionally dropping the "-n32:64-S128" part of the string? efriedma: Are you intentionally dropping the "-n32:64-S128" part of the string?
	if (LittleEndian)			if (LittleEndian)
	return "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128";			return "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128";
	return "E-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128";			return "E-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128";
	}			}

	static Reloc::Model getEffectiveRelocModel(const Triple &TT,			static Reloc::Model getEffectiveRelocModel(const Triple &TT,
	Optional<Reloc::Model> RM) {			Optional<Reloc::Model> RM) {
	// AArch64 Darwin is always PIC.			// AArch64 Darwin is always PIC.
	▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines