This is an archive of the discontinued LLVM Phabricator instance.

[COFF, ARM64] Add support for Windows ARM64 COFF format
ClosedPublic

Authored by mgrang on Jun 27 2017, 1:29 PM.

Details

Summary

This is the llvm part of the initial implementation to support Windows ARM64 COFF format.
I will gradually add more functionality in subsequent patches.

Diff Detail

Event Timeline

mgrang created this revision.Jun 27 2017, 1:29 PM

Here is the clang part of this patch: https://reviews.llvm.org/D34706

compnerd accepted this revision.Jun 27 2017, 1:35 PM

Please add a check for the incremental link compatible flag.

This revision is now accepted and ready to land.Jun 27 2017, 1:35 PM
ruiu added inline comments.Jun 27 2017, 1:50 PM
lib/Target/AArch64/AArch64MCInstLower.cpp
168

Remove else as the last if ends with return.

lib/Target/AArch64/AArch64MCInstLower.h
46

Fix indentation

lib/Target/AArch64/AArch64TargetMachine.cpp
170

Ditto

lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp
51–52

For now, remove switch and default.

mgrang updated this revision to Diff 104309.Jun 27 2017, 4:30 PM

Comments addressed.

ruiu accepted this revision.Jun 27 2017, 4:36 PM

I'm no expert of this code, but as Saleem has already LGTMed, I think you can go ahead to submit.

lib/Object/COFFObjectFile.cpp
1221

Sort alphabetically.

lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFStreamer.cpp
22

Is this the correct indentation? Please use clang-format-diff on your patch so that we don't need to worry about formatting.

This revision was automatically updated to reflect the committed changes.