[OpenMP] Pass -v to PTXAS if it was passed to the driver.

[gtbercea]

Summary

When compiling code being offloaded by OpenMP to an NVIDIA GPU, pass the -v to PTXAS if it was passed to the CLANG driver.

[jlebar]

I'm fine with this.

[gtbercea]

Update patch to reflect latest source code changes.

[Hahnfeld]

test/Driver/openmp-offload.c

607 ↗

(On Diff #93176)

This path might not be correct on all systems. Do we really need this check?

[gtbercea]

Remove redundant check.

[gtbercea]

Change prefix name in test.

[Hahnfeld]

Just noticed that this isn't specific to OpenMP. Could you move the test to Driver/cuda-external-tools.cu where the rest of ptxas is tested?

[gtbercea]

Move test.

lib/Driver/ToolChains/Cuda.cpp

if (Args.hasFlag(options::OPT_cuda_noopt_device_debug,
     }
     CmdArgs.push_back(Args.MakeArgString(llvm::Twine("-O") + OOpt));
   } else {
     // If no -O was passed, pass -O0 to ptxas -- no opt flag should correspond
     // to no optimizations, but ptxas's default is -O3.
     CmdArgs.push_back("-O0");
   }
 
+  // Pass -v to ptxas if it was passed to the driver.
+  if (Args.hasArg(options::OPT_v))
+    CmdArgs.push_back("-v");
+
   CmdArgs.push_back("--gpu-name");
   CmdArgs.push_back(Args.MakeArgString(CudaArchToString(gpu_arch)));
   CmdArgs.push_back("--output-file");
   CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
   for (const auto& II : Inputs)
     CmdArgs.push_back(Args.MakeArgString(II.getFilename()));
 
   for (const auto& A : Args.getAllArgValues(options::OPT_Xcuda_ptxas))

test/Driver/cuda-external-tools.cu

 // MacOS spot-checks
 // RUN: %clang -### -target x86_64-apple-macosx -O0 -c %s 2>&1 \
 // RUN: | FileCheck -check-prefix ARCH64 -check-prefix SM20 -check-prefix OPT0 %s
 // RUN: %clang -### -target x86_64-apple-macosx --cuda-gpu-arch=sm_35 -c %s 2>&1 \
 // RUN: | FileCheck -check-prefix ARCH64 -check-prefix SM35 %s
 // RUN: %clang -### -target x86_32-apple-macosx -c %s 2>&1 \
 // RUN: | FileCheck -check-prefix ARCH32 -check-prefix SM20 %s
 
+// Check that CLANG forwards the -v flag to PTXAS.
+// RUN:   %clang -### -save-temps -no-canonical-prefixes -v %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHK-PTXAS-VERBOSE %s
+
 // Match clang job that produces PTX assembly.
 // CHECK: "-cc1" "-triple" "nvptx64-nvidia-cuda"
 // SM20: "-target-cpu" "sm_20"
 // SM35: "-target-cpu" "sm_35"
 // SM20: "-o" "[[PTXFILE:[^"]*]]"
 // SM35: "-o" "[[PTXFILE:[^"]*]]"
 
 // Match the call to ptxas (which assembles PTX to SASS).

 // SM20-DAG: "--image=profile=sm_20,file=[[CUBINFILE]]"
 // SM35-DAG: "--image=profile=sm_35,file=[[CUBINFILE]]"
 // FATBINARY-EXTRA: "-bar1"
 // FATBINARY-EXTRA-SAME: "-bar2"
 
 // Match the clang job for host compilation.
 // CHECK: "-cc1" "-triple" "x86_64--linux-gnu"
 // CHECK-SAME: "-fcuda-include-gpubinary" "[[FATBINARY]]"
+
+// CHK-PTXAS-VERBOSE: ptxas{{.*}}" "-v"