This is an archive of the discontinued LLVM Phabricator instance.

Differential D27652

Using auto for calls to cast-like functions to cover LLVM style guide.
AcceptedPublic

Authored by staronj on Dec 10 2016, 5:21 AM.

Details

Reviewers
Prazek
• tstellarAMD
mehdi_amini
Summary

Changes in LLVM code to satisfy Use auto Type Deduction to Make Code More Readable rule in LLVM coding standards.

Diff is produced by prototype check that is similar to enchantments made by malcolm.parsons in D27166 (modernize-use-auto).

Diff Detail

Event Timeline

staronj updated this revision to Diff 80998.Dec 10 2016, 5:21 AM
staronj retitled this revision from to Changes in LLVM after running llvm-use-auto-in-calls check..
staronj updated this object.
staronj added a reviewer: Prazek.
Herald added a reviewer: • tstellarAMD. · View Herald TranscriptDec 10 2016, 5:21 AM
Herald added subscribers: JDevlieghere, amehsan, nhaehnle and 10 others. · View Herald Transcript
Eugene.Zelenko added a subscriber: Eugene.Zelenko.Dec 10 2016, 1:18 PM

It's reasonable application of Clang-tidy, but I think will be better to split fixes in several commits based on functionality.

Did you also enable analysis of headers?

Eugene.Zelenko added a comment.Dec 10 2016, 1:25 PM

Could you please clarify situation with check? Similar thing is implemented in D27166.

Eugene.Zelenko edited edge metadata.Dec 10 2016, 1:25 PM
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: malcolm.parsons.
nemanjai added a comment.Dec 11 2016, 5:06 PM

Forgive me if this question is too general or has an obvious answer...

I am wondering what the advantage is of using the auto type specifier in place of actual type specifiers in general. I certainly understand it when it comes to overly verbose iterator declarations and nested types, but I fail to see the advantage of applying such a change as widely as this.

So I am not fundamentally opposed to this change, but I would like to understand the rationale a bit more clearly rather than seeing a patch that has no description other than "results of running clang-tidy on LLVM source". As a PowerPC back end developer I spend a lot of time in that code and as I look at this patch, I do not see it as an obvious improvement to the code that is currently there. That is not to say I see any changes that hinder readability since it appears to only be applied to calls where the the explicit template argument specifies the return type.

mehdi_amini added a comment.Dec 11 2016, 6:12 PM
In D27652#619531, @nemanjai wrote:

Forgive me if this question is too general or has an obvious answer...

I am wondering what the advantage is of using the auto type specifier in place of actual type specifiers in general.

In general: none.

I certainly understand it when it comes to overly verbose iterator declarations and nested types, but I fail to see the advantage of applying such a change as widely as this.

So I am not fundamentally opposed to this change, but I would like to understand the rationale a bit more clearly rather than seeing a patch that has no description other than "results of running clang-tidy on LLVM source".

I agree this a poorly described patch.

As a PowerPC back end developer I spend a lot of time in that code and as I look at this patch, I do not see it as an obvious improvement to the code that is currently there. That is not to say I see any changes that hinder readability since it appears to only be applied to calls where the the explicit template argument specifies the return type.

From I saw in this patch, it is implementing this: http://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable : do use auto with initializers like cast<Foo>(...) or other places where the type is already obvious from the context

Prazek edited edge metadata.Dec 12 2016, 3:01 AM
In D27652#619240, @Eugene.Zelenko wrote:

Could you please clarify situation with check? Similar thing is implemented in D27166.

We had race condition in fixing this bug and Malcolm published his solution before us. The check is doing the same thing.
Jakub, maybe you should remove check name from commit, because it won't gonna land in trunk with this name.

Prazek added a comment.Dec 12 2016, 3:03 AM
In D27652#619237, @Eugene.Zelenko wrote:

It's reasonable application of Clang-tidy, but I think will be better to split fixes in several commits based on functionality.

Did you also enable analysis of headers?

What is the good way to split it in your opinion? These are changes to only this one case (auto * I = dyn_cast<Instr> etc), so there is only one functionality.

Prazek added a comment.Dec 12 2016, 3:05 AM
In D27652#619547, @mehdi_amini wrote:
In D27652#619531, @nemanjai wrote:

Forgive me if this question is too general or has an obvious answer...

I am wondering what the advantage is of using the auto type specifier in place of actual type specifiers in general.

In general: none.

I certainly understand it when it comes to overly verbose iterator declarations and nested types, but I fail to see the advantage of applying such a change as widely as this.

So I am not fundamentally opposed to this change, but I would like to understand the rationale a bit more clearly rather than seeing a patch that has no description other than "results of running clang-tidy on LLVM source".

I agree this a poorly described patch.

As a PowerPC back end developer I spend a lot of time in that code and as I look at this patch, I do not see it as an obvious improvement to the code that is currently there. That is not to say I see any changes that hinder readability since it appears to only be applied to calls where the the explicit template argument specifies the return type.

From I saw in this patch, it is implementing this: http://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable : do use auto with initializers like cast<Foo>(...) or other places where the type is already obvious from the context

Exactly. Having redundant type is 1) redundant 2) bugprone (someone could change single type when modyfying source code).
I saw that in most of the cases reviewers are enforcing that rule. The diff is so large because LLVM was started before c++11

malcolm.parsons added a subscriber: llvm-commits.Dec 12 2016, 4:29 AM
mehdi_amini added a comment.Dec 12 2016, 11:09 AM
In D27652#619704, @Prazek wrote:

What is the good way to split it in your opinion? These are changes to only this one case (auto * I = dyn_cast<Instr> etc), so there is only one functionality.

Yes, because it is largely automatic and the pattern is well identified, I'm fine with a single patch. But please update the description!

staronj retitled this revision from Changes in LLVM after running llvm-use-auto-in-calls check. to Using auto for calls to cast-like functions to cover LLVM style guide..Dec 13 2016, 6:43 AM
staronj updated this object.
staronj edited edge metadata.
mehdi_amini accepted this revision.Dec 13 2016, 8:32 AM
mehdi_amini added a reviewer: mehdi_amini.

LGTM.

This revision is now accepted and ready to land.Dec 13 2016, 8:32 AM

Large Diff

This large diff affects 472 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
examples/
BrainF/
2 lines
2 lines
Fibonacci/
2 lines
HowToUseJIT/
4 lines
ParallelJIT/
4 lines
lib/
Analysis/
4 lines
16 lines
54 lines
22 lines
2 lines
6 lines
12 lines
10 lines
30 lines
8 lines
20 lines
116 lines
10 lines
28 lines
12 lines
50 lines
164 lines
2 lines
50 lines
44 lines
24 lines
28 lines
18 lines
2 lines
10 lines
2 lines
36 lines
30 lines
10 lines
2 lines
16 lines
36 lines
504 lines
6 lines
106 lines
10 lines
4 lines
14 lines
12 lines
190 lines
28 lines
AsmParser/
26 lines
Bitcode/
Reader/
66 lines
Writer/
54 lines
14 lines
CodeGen/
26 lines
AsmPrinter/
46 lines
8 lines
2 lines
4 lines
4 lines
2 lines
2 lines
2 lines
4 lines
190 lines
2 lines
8 lines
12 lines
8 lines
2 lines
2 lines
MIRParser/
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
SelectionDAG/
312 lines
18 lines
16 lines
40 lines
22 lines
16 lines
14 lines
4 lines
8 lines
12 lines
2 lines
166 lines
170 lines
40 lines
26 lines
12 lines
42 lines
6 lines
4 lines
4 lines
24 lines
2 lines
4 lines
4 lines
2 lines
12 lines
DebugInfo/
DWARF/
2 lines
Symbolize/
4 lines
ExecutionEngine/
32 lines
Interpreter/
16 lines
Orc/
8 lines
IR/
136 lines
36 lines
10 lines
164 lines
156 lines
50 lines
2 lines
14 lines
54 lines
8 lines
10 lines
2 lines
34 lines
92 lines
2 lines
4 lines
10 lines
2 lines
22 lines
4 lines
4 lines
32 lines
8 lines
92 lines
LTO/
26 lines
Linker/
36 lines
MC/
2 lines
6 lines
22 lines
2 lines
20 lines
20 lines
2 lines
2 lines
MCParser/
18 lines
4 lines
2 lines
10 lines
4 lines
2 lines
Object/
2 lines
ProfileData/
2 lines
Support/
36 lines
TableGen/
140 lines
18 lines
62 lines
Target/
AArch64/
10 lines
44 lines
44 lines
144 lines
2 lines
6 lines
4 lines
2 lines
AsmParser/
168 lines
InstPrinter/
2 lines
MCTargetDesc/
4 lines
2 lines
2 lines
AMDGPU/
2 lines
4 lines
2 lines
8 lines
54 lines
44 lines
2 lines
10 lines
56 lines
10 lines
AsmParser/
2 lines
MCTargetDesc/
8 lines
6 lines
36 lines
8 lines
70 lines
4 lines
4 lines
ARM/
2 lines
6 lines
6 lines
60 lines
80 lines
136 lines
2 lines
4 lines
AsmParser/
252 lines
InstPrinter/
2 lines
MCTargetDesc/
4 lines
4 lines
4 lines
BPF/
10 lines
4 lines
Hexagon/
AsmParser/
8 lines
48 lines
6 lines
52 lines
42 lines
12 lines
2 lines
14 lines
4 lines
MCTargetDesc/
2 lines
4 lines
Lanai/
AsmParser/
70 lines
14 lines
32 lines
2 lines
MCTargetDesc/
2 lines
MSP430/
14 lines
20 lines
Mips/
AsmParser/
18 lines
MCTargetDesc/
2 lines
8 lines
4 lines
6 lines
6 lines
2 lines
4 lines
32 lines
44 lines
2 lines
18 lines
18 lines
2 lines
NVPTX/
2 lines
68 lines
42 lines
30 lines
6 lines
14 lines
16 lines
8 lines
8 lines
36 lines
2 lines
8 lines
PowerPC/
AsmParser/
30 lines
InstPrinter/
2 lines
26 lines
14 lines
34 lines
26 lines
118 lines
28 lines
Sparc/
AsmParser/
6 lines
MCTargetDesc/
2 lines
4 lines
2 lines
10 lines
44 lines
SystemZ/
InstPrinter/
2 lines
2 lines
2 lines
6 lines
X86/
AsmParser/
4 lines
InstPrinter/
2 lines
2 lines
2 lines
64 lines
8 lines
64 lines
208 lines
2 lines
2 lines
2 lines
8 lines
8 lines
XCore/
InstPrinter/
4 lines
2 lines
2 lines
36 lines
12 lines
Transforms/
Coroutines/
2 lines
4 lines
IPO/
46 lines
4 lines
2 lines
30 lines
2 lines
24 lines
16 lines
232 lines
14 lines
4 lines
4 lines
10 lines
12 lines
16 lines
4 lines
2 lines
14 lines
InstCombine/
74 lines
128 lines
130 lines
122 lines
148 lines
50 lines
92 lines
62 lines
52 lines
66 lines
46 lines
70 lines
176 lines
Instrumentation/
48 lines
12 lines
42 lines
14 lines
10 lines
18 lines
6 lines
44 lines
6 lines
8 lines
32 lines
ObjCARC/
6 lines
4 lines
8 lines
60 lines
12 lines
Scalar/
4 lines
30 lines
14 lines
2 lines
42 lines
44 lines
12 lines
66 lines
12 lines
76 lines
34 lines
102 lines
22 lines
2 lines
10 lines
6 lines
56 lines
56 lines
52 lines
18 lines
2 lines
2 lines
180 lines
14 lines
40 lines
6 lines
10 lines
16 lines
68 lines
4 lines
10 lines
2 lines
6 lines
62 lines
2 lines
66 lines
6 lines
140 lines
32 lines
36 lines
4 lines
8 lines
4 lines
4 lines
22 lines
26 lines
Utils/
2 lines
22 lines
8 lines
30 lines
4 lines
32 lines
6 lines
2 lines
26 lines
12 lines
10 lines
4 lines
62 lines
24 lines
74 lines
24 lines
68 lines
14 lines
10 lines
4 lines
74 lines
12 lines
24 lines
16 lines
34 lines
18 lines
2 lines
12 lines
2 lines
30 lines
8 lines
44 lines
20 lines
244 lines
14 lines
78 lines
4 lines
4 lines
14 lines
Vectorize/
62 lines
50 lines
76 lines
192 lines
tools/
bugpoint-passes/
2 lines
bugpoint/
14 lines
18 lines
6 lines
lli/
2 lines
llvm-cxxdump/
6 lines
llvm-diff/
8 lines
20 lines
llvm-dis/
6 lines
llvm-nm/
28 lines
llvm-objdump/
2 lines
8 lines
30 lines
2 lines
28 lines
llvm-readobj/
2 lines
8 lines
2 lines
12 lines
llvm-size/
38 lines
llvm-stress/
4 lines
obj2yaml/
2 lines
opt/
2 lines
sancov/
16 lines
unittests/
Analysis/
4 lines
20 lines
AsmParser/
12 lines
IR/
4 lines
2 lines
2 lines
2 lines
10 lines
Linker/
2 lines
Support/
34 lines
18 lines
Transforms/
Utils/
8 lines
16 lines
18 lines
utils/
TableGen/
16 lines
4 lines
8 lines
50 lines
18 lines
4 lines
2 lines
16 lines
30 lines
10 lines
32 lines
4 lines
16 lines
2 lines
6 lines
8 lines
6 lines
10 lines
yaml-bench/
10 lines

Diff 80998

examples/BrainF/BrainF.cpp

examples/BrainF/BrainFDriver.cpp

examples/Fibonacci/fibonacci.cpp

examples/HowToUseJIT/HowToUseJIT.cpp

examples/ParallelJIT/ParallelJIT.cpp

lib/Analysis/AliasAnalysis.cpp

lib/Analysis/AliasSetTracker.cpp

lib/Analysis/BasicAliasAnalysis.cpp

lib/Analysis/BranchProbabilityInfo.cpp

lib/Analysis/CGSCCPassManager.cpp

lib/Analysis/CaptureTracking.cpp

lib/Analysis/CodeMetrics.cpp

lib/Analysis/ConstantFolding.cpp

lib/Analysis/CostModel.cpp

lib/Analysis/Delinearization.cpp

lib/Analysis/DemandedBits.cpp

lib/Analysis/DependenceAnalysis.cpp

lib/Analysis/DivergenceAnalysis.cpp

lib/Analysis/GlobalsModRef.cpp

lib/Analysis/IVUsers.cpp

lib/Analysis/InlineCost.cpp

lib/Analysis/InstructionSimplify.cpp

lib/Analysis/LazyCallGraph.cpp

lib/Analysis/LazyValueInfo.cpp

lib/Analysis/Lint.cpp

lib/Analysis/Loads.cpp

lib/Analysis/LoopAccessAnalysis.cpp

lib/Analysis/LoopInfo.cpp

lib/Analysis/LoopPass.cpp

lib/Analysis/LoopUnrollAnalyzer.cpp

lib/Analysis/MemDerefPrinter.cpp

lib/Analysis/MemoryBuiltins.cpp

lib/Analysis/MemoryDependenceAnalysis.cpp

lib/Analysis/MemoryLocation.cpp

lib/Analysis/ModuleSummaryAnalysis.cpp

lib/Analysis/ObjCARCInstKind.cpp

lib/Analysis/PHITransAddr.cpp

lib/Analysis/ScalarEvolution.cpp

lib/Analysis/ScalarEvolutionAliasAnalysis.cpp

lib/Analysis/ScalarEvolutionExpander.cpp

lib/Analysis/ScalarEvolutionNormalization.cpp

lib/Analysis/ScopedNoAliasAA.cpp

lib/Analysis/SparsePropagation.cpp

lib/Analysis/TypeBasedAliasAnalysis.cpp

lib/Analysis/ValueTracking.cpp

lib/Analysis/VectorUtils.cpp

lib/AsmParser/LLParser.cpp

lib/Bitcode/Reader/BitcodeReader.cpp

lib/Bitcode/Writer/BitcodeWriter.cpp

lib/Bitcode/Writer/ValueEnumerator.cpp

lib/CodeGen/Analysis.cpp

lib/CodeGen/AsmPrinter/AsmPrinter.cpp

lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp

lib/CodeGen/AsmPrinter/DwarfDebug.cpp

lib/CodeGen/AsmPrinter/DwarfUnit.cpp

lib/CodeGen/AsmPrinter/EHStreamer.cpp

lib/CodeGen/AsmPrinter/WinException.cpp

lib/CodeGen/AtomicExpandPass.cpp

lib/CodeGen/BuiltinGCs.cpp

lib/CodeGen/CodeGenPrepare.cpp

lib/CodeGen/DwarfEHPrepare.cpp

lib/CodeGen/GCRootLowering.cpp

lib/CodeGen/GlobalMerge.cpp

lib/CodeGen/InterleavedAccessPass.cpp

lib/CodeGen/IntrinsicLowering.cpp

lib/CodeGen/LowerEmuTLS.cpp

lib/CodeGen/MIRParser/MIRParser.cpp

lib/CodeGen/MachineFunction.cpp

lib/CodeGen/MachineLICM.cpp

lib/CodeGen/MachineModuleInfo.cpp

lib/CodeGen/MachineRegisterInfo.cpp

lib/CodeGen/MachineVerifier.cpp

lib/CodeGen/SafeStack.cpp

lib/CodeGen/ScheduleDAGInstrs.cpp

lib/CodeGen/SelectionDAG/DAGCombiner.cpp

lib/CodeGen/SelectionDAG/FastISel.cpp

lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp

lib/CodeGen/SelectionDAG/InstrEmitter.cpp

lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp

lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp

lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp

lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp

lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp

lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp

lib/CodeGen/SelectionDAG/SelectionDAG.cpp

lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp

lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

lib/CodeGen/SelectionDAG/StatepointLowering.cpp

lib/CodeGen/SelectionDAG/TargetLowering.cpp

lib/CodeGen/ShadowStackGCLowering.cpp

lib/CodeGen/SjLjEHPrepare.cpp

lib/CodeGen/StackColoring.cpp

lib/CodeGen/StackProtector.cpp

lib/CodeGen/StackSlotColoring.cpp

lib/CodeGen/TargetInstrInfo.cpp

lib/CodeGen/TargetLoweringObjectFileImpl.cpp

lib/CodeGen/UnreachableBlockElim.cpp

lib/CodeGen/WinEHPrepare.cpp

lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

lib/DebugInfo/Symbolize/Symbolize.cpp

lib/ExecutionEngine/ExecutionEngine.cpp

lib/ExecutionEngine/Interpreter/Execution.cpp

lib/ExecutionEngine/Orc/ExecutionUtils.cpp

lib/IR/AsmWriter.cpp

lib/IR/AutoUpgrade.cpp

lib/IR/BasicBlock.cpp

lib/IR/ConstantFold.cpp

lib/IR/Constants.cpp

lib/IR/Core.cpp

lib/IR/DataLayout.cpp

lib/IR/Dominators.cpp

lib/IR/Function.cpp

lib/IR/Globals.cpp

lib/IR/IRBuilder.cpp

lib/IR/InlineAsm.cpp

lib/IR/Instruction.cpp

lib/IR/Instructions.cpp

lib/IR/Mangler.cpp

lib/IR/Metadata.cpp

lib/IR/Module.cpp

lib/IR/Operator.cpp

lib/IR/ProfileSummary.cpp

lib/IR/Type.cpp

lib/IR/TypeFinder.cpp

lib/IR/Value.cpp

lib/IR/ValueTypes.cpp

lib/IR/Verifier.cpp

lib/LTO/LTOModule.cpp

lib/Linker/IRMover.cpp

lib/MC/ConstantPools.cpp

lib/MC/ELFObjectWriter.cpp

lib/MC/MCAssembler.cpp

lib/MC/MCELFStreamer.cpp

lib/MC/MCExpr.cpp

lib/MC/MCFragment.cpp

lib/MC/MCMachOStreamer.cpp

lib/MC/MCObjectStreamer.cpp

lib/MC/MCParser/AsmParser.cpp

lib/MC/MCParser/ELFAsmParser.cpp

lib/MC/MCStreamer.cpp

lib/MC/MachObjectWriter.cpp

lib/MC/WinCOFFObjectWriter.cpp

lib/MC/WinCOFFStreamer.cpp

lib/Object/ModuleSymbolTable.cpp

lib/ProfileData/InstrProf.cpp

lib/Support/YAMLTraits.cpp

lib/TableGen/Record.cpp

lib/TableGen/SetTheory.cpp

lib/TableGen/TGParser.cpp

lib/Target/AArch64/AArch64AddressTypePromotion.cpp

lib/Target/AArch64/AArch64FastISel.cpp

lib/Target/AArch64/AArch64ISelDAGToDAG.cpp

lib/Target/AArch64/AArch64ISelLowering.cpp

lib/Target/AArch64/AArch64InstrInfo.cpp

lib/Target/AArch64/AArch64PromoteConstant.cpp

lib/Target/AArch64/AArch64SelectionDAGInfo.cpp

lib/Target/AArch64/AArch64TargetTransformInfo.cpp

lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp

lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp

lib/Target/AArch64/MCTargetDesc/AArch64MCExpr.cpp

lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp

lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp

lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp

lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp

lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp

lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp

lib/Target/AMDGPU/AMDGPUISelLowering.cpp

lib/Target/AMDGPU/AMDGPUIntrinsicInfo.cpp

lib/Target/AMDGPU/AMDGPUOpenCLImageTypeLoweringPass.cpp

lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp

lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp

lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp

lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp

lib/Target/AMDGPU/R600ISelLowering.cpp

lib/Target/AMDGPU/SIAnnotateControlFlow.cpp

lib/Target/AMDGPU/SIISelLowering.cpp

lib/Target/AMDGPU/SIInstrInfo.cpp

lib/Target/AMDGPU/SITypeRewriter.cpp

lib/Target/ARM/ARMAsmPrinter.cpp

lib/Target/ARM/ARMBaseInstrInfo.cpp

lib/Target/ARM/ARMConstantPoolValue.cpp

lib/Target/ARM/ARMFastISel.cpp

lib/Target/ARM/ARMISelDAGToDAG.cpp

lib/Target/ARM/ARMISelLowering.cpp

lib/Target/ARM/ARMInstrInfo.cpp

lib/Target/ARM/ARMSelectionDAGInfo.cpp

lib/Target/ARM/AsmParser/ARMAsmParser.cpp

lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp

lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp

lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp

lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp

lib/Target/BPF/BPFISelDAGToDAG.cpp

lib/Target/BPF/BPFISelLowering.cpp

lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp

lib/Target/Hexagon/HexagonCommonGEP.cpp

lib/Target/Hexagon/HexagonConstPropagation.cpp

lib/Target/Hexagon/HexagonISelDAGToDAG.cpp

lib/Target/Hexagon/HexagonISelLowering.cpp

lib/Target/Hexagon/HexagonOptimizeSZextends.cpp

lib/Target/Hexagon/HexagonSelectionDAGInfo.cpp

lib/Target/Hexagon/HexagonTargetObjectFile.cpp

lib/Target/Hexagon/HexagonTargetTransformInfo.cpp

lib/Target/Hexagon/MCTargetDesc/HexagonMCCodeEmitter.cpp

lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.cpp

lib/Target/Lanai/AsmParser/LanaiAsmParser.cpp

lib/Target/Lanai/LanaiISelDAGToDAG.cpp

lib/Target/Lanai/LanaiISelLowering.cpp

lib/Target/Lanai/LanaiSelectionDAGInfo.cpp

lib/Target/Lanai/MCTargetDesc/LanaiMCCodeEmitter.cpp

lib/Target/MSP430/MSP430ISelDAGToDAG.cpp

lib/Target/MSP430/MSP430ISelLowering.cpp

lib/Target/Mips/AsmParser/MipsAsmParser.cpp

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp

lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp

lib/Target/Mips/Mips16HardFloat.cpp

lib/Target/Mips/Mips16ISelDAGToDAG.cpp

lib/Target/Mips/Mips16ISelLowering.cpp

lib/Target/Mips/MipsAsmPrinter.cpp

lib/Target/Mips/MipsCCState.cpp

lib/Target/Mips/MipsFastISel.cpp

lib/Target/Mips/MipsISelLowering.cpp

lib/Target/Mips/MipsOs16.cpp

lib/Target/Mips/MipsSEISelDAGToDAG.cpp

lib/Target/Mips/MipsSEISelLowering.cpp

lib/Target/Mips/MipsTargetObjectFile.cpp

lib/Target/NVPTX/NVPTXAllocaHoisting.cpp

lib/Target/NVPTX/NVPTXAsmPrinter.cpp

lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp

lib/Target/NVPTX/NVPTXISelLowering.cpp

lib/Target/NVPTX/NVPTXImageOptimizer.cpp

lib/Target/NVPTX/NVPTXInferAddressSpaces.cpp

lib/Target/NVPTX/NVPTXLowerAggrCopies.cpp

lib/Target/NVPTX/NVPTXLowerArgs.cpp

lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp

lib/Target/NVPTX/NVPTXUtilities.cpp

lib/Target/NVPTX/NVVMIntrRange.cpp

lib/Target/NVPTX/NVVMReflect.cpp

lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp

lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp

lib/Target/PowerPC/PPCBoolRetToInt.cpp

lib/Target/PowerPC/PPCCTRLoops.cpp

lib/Target/PowerPC/PPCFastISel.cpp

lib/Target/PowerPC/PPCISelDAGToDAG.cpp

lib/Target/PowerPC/PPCISelLowering.cpp

lib/Target/PowerPC/PPCLoopPreIncPrep.cpp

lib/Target/Sparc/AsmParser/SparcAsmParser.cpp

lib/Target/Sparc/MCTargetDesc/SparcELFObjectWriter.cpp

lib/Target/Sparc/MCTargetDesc/SparcMCCodeEmitter.cpp

lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp

lib/Target/Sparc/SparcISelDAGToDAG.cpp

lib/Target/Sparc/SparcISelLowering.cpp

lib/Target/SystemZ/InstPrinter/SystemZInstPrinter.cpp

lib/Target/SystemZ/SystemZISelLowering.cpp

lib/Target/SystemZ/SystemZTDC.cpp

lib/Target/TargetLoweringObjectFile.cpp

lib/Target/X86/AsmParser/X86AsmParser.cpp

lib/Target/X86/InstPrinter/X86ATTInstPrinter.cpp

lib/Target/X86/InstPrinter/X86IntelInstPrinter.cpp

lib/Target/X86/X86AsmPrinter.cpp

lib/Target/X86/X86FastISel.cpp

lib/Target/X86/X86FrameLowering.cpp

lib/Target/X86/X86ISelDAGToDAG.cpp

lib/Target/X86/X86ISelLowering.cpp

lib/Target/X86/X86InstrInfo.cpp

lib/Target/X86/X86InterleavedAccess.cpp

lib/Target/X86/X86MCInstLower.cpp

lib/Target/X86/X86SelectionDAGInfo.cpp

lib/Target/X86/X86TargetTransformInfo.cpp

lib/Target/XCore/InstPrinter/XCoreInstPrinter.cpp

lib/Target/XCore/XCoreAsmPrinter.cpp

lib/Target/XCore/XCoreISelDAGToDAG.cpp

lib/Target/XCore/XCoreISelLowering.cpp

lib/Target/XCore/XCoreLowerThreadLocal.cpp

lib/Transforms/Coroutines/CoroFrame.cpp

lib/Transforms/Coroutines/CoroSplit.cpp

lib/Transforms/IPO/ArgumentPromotion.cpp

lib/Transforms/IPO/ConstantMerge.cpp

lib/Transforms/IPO/CrossDSOCFI.cpp

lib/Transforms/IPO/DeadArgumentElimination.cpp

lib/Transforms/IPO/ExtractGV.cpp

lib/Transforms/IPO/FunctionAttrs.cpp

lib/Transforms/IPO/GlobalDCE.cpp

lib/Transforms/IPO/GlobalOpt.cpp

lib/Transforms/IPO/IPConstantPropagation.cpp

lib/Transforms/IPO/Inliner.cpp

lib/Transforms/IPO/LoopExtractor.cpp

lib/Transforms/IPO/LowerTypeTests.cpp

lib/Transforms/IPO/MergeFunctions.cpp

lib/Transforms/IPO/PartialInlining.cpp

lib/Transforms/IPO/PruneEH.cpp

lib/Transforms/IPO/SampleProfile.cpp

lib/Transforms/IPO/StripSymbols.cpp

lib/Transforms/InstCombine/InstCombineAddSub.cpp

lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

lib/Transforms/InstCombine/InstCombineCalls.cpp

lib/Transforms/InstCombine/InstCombineCasts.cpp

lib/Transforms/InstCombine/InstCombineCompares.cpp

lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp

lib/Transforms/InstCombine/InstCombineMulDivRem.cpp

lib/Transforms/InstCombine/InstCombinePHI.cpp

lib/Transforms/InstCombine/InstCombineSelect.cpp

lib/Transforms/InstCombine/InstCombineShifts.cpp

lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp

lib/Transforms/InstCombine/InstCombineVectorOps.cpp

lib/Transforms/InstCombine/InstructionCombining.cpp

lib/Transforms/Instrumentation/AddressSanitizer.cpp

lib/Transforms/Instrumentation/BoundsChecking.cpp

lib/Transforms/Instrumentation/DataFlowSanitizer.cpp

lib/Transforms/Instrumentation/EfficiencySanitizer.cpp

lib/Transforms/Instrumentation/GCOVProfiling.cpp

lib/Transforms/Instrumentation/IndirectCallPromotion.cpp

lib/Transforms/Instrumentation/InstrProfiling.cpp

lib/Transforms/Instrumentation/MemorySanitizer.cpp

lib/Transforms/Instrumentation/PGOInstrumentation.cpp

lib/Transforms/Instrumentation/SanitizerCoverage.cpp

lib/Transforms/Instrumentation/ThreadSanitizer.cpp

lib/Transforms/ObjCARC/DependencyAnalysis.cpp

lib/Transforms/ObjCARC/ObjCARCAPElim.cpp

lib/Transforms/ObjCARC/ObjCARCContract.cpp

lib/Transforms/ObjCARC/ObjCARCOpts.cpp

lib/Transforms/ObjCARC/ProvenanceAnalysis.cpp

lib/Transforms/Scalar/ADCE.cpp

lib/Transforms/Scalar/AlignmentFromAssumptions.cpp

lib/Transforms/Scalar/CorrelatedValuePropagation.cpp

lib/Transforms/Scalar/DCE.cpp

lib/Transforms/Scalar/DeadStoreElimination.cpp

lib/Transforms/Scalar/EarlyCSE.cpp

lib/Transforms/Scalar/Float2Int.cpp

lib/Transforms/Scalar/GVN.cpp

lib/Transforms/Scalar/GVNHoist.cpp

lib/Transforms/Scalar/IndVarSimplify.cpp

lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp

lib/Transforms/Scalar/JumpThreading.cpp

lib/Transforms/Scalar/LICM.cpp

lib/Transforms/Scalar/LoadCombine.cpp

lib/Transforms/Scalar/LoopDataPrefetch.cpp

lib/Transforms/Scalar/LoopDeletion.cpp

lib/Transforms/Scalar/LoopIdiomRecognize.cpp

lib/Transforms/Scalar/LoopInterchange.cpp

lib/Transforms/Scalar/LoopRerollPass.cpp

lib/Transforms/Scalar/LoopRotation.cpp

lib/Transforms/Scalar/LoopSimplifyCFG.cpp

lib/Transforms/Scalar/LoopSink.cpp

lib/Transforms/Scalar/LoopStrengthReduce.cpp

lib/Transforms/Scalar/LoopUnrollPass.cpp

lib/Transforms/Scalar/LoopUnswitch.cpp

lib/Transforms/Scalar/LoopVersioningLICM.cpp

lib/Transforms/Scalar/LowerAtomic.cpp

lib/Transforms/Scalar/LowerExpectIntrinsic.cpp

lib/Transforms/Scalar/MemCpyOptimizer.cpp

lib/Transforms/Scalar/MergedLoadStoreMotion.cpp

lib/Transforms/Scalar/NaryReassociate.cpp

lib/Transforms/Scalar/PartiallyInlineLibCalls.cpp

lib/Transforms/Scalar/PlaceSafepoints.cpp

lib/Transforms/Scalar/Reassociate.cpp

lib/Transforms/Scalar/Reg2Mem.cpp

lib/Transforms/Scalar/RewriteStatepointsForGC.cpp

lib/Transforms/Scalar/SCCP.cpp

lib/Transforms/Scalar/SROA.cpp

lib/Transforms/Scalar/Scalarizer.cpp

lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp

lib/Transforms/Scalar/SimplifyCFGPass.cpp

lib/Transforms/Scalar/Sink.cpp

lib/Transforms/Scalar/SpeculativeExecution.cpp

lib/Transforms/Scalar/StraightLineStrengthReduce.cpp

lib/Transforms/Scalar/StructurizeCFG.cpp

lib/Transforms/Scalar/TailRecursionElimination.cpp

lib/Transforms/Utils/AddDiscriminators.cpp

lib/Transforms/Utils/BasicBlockUtils.cpp

lib/Transforms/Utils/BreakCriticalEdges.cpp

lib/Transforms/Utils/BuildLibCalls.cpp

lib/Transforms/Utils/BypassSlowDivision.cpp

lib/Transforms/Utils/CloneFunction.cpp

lib/Transforms/Utils/CloneModule.cpp

lib/Transforms/Utils/CmpInstAnalysis.cpp

lib/Transforms/Utils/CodeExtractor.cpp

lib/Transforms/Utils/CtorUtils.cpp

lib/Transforms/Utils/DemoteRegToStack.cpp

lib/Transforms/Utils/EscapeEnumerator.cpp

lib/Transforms/Utils/Evaluator.cpp

lib/Transforms/Utils/FlattenCFG.cpp

lib/Transforms/Utils/FunctionComparator.cpp

lib/Transforms/Utils/GlobalStatus.cpp

lib/Transforms/Utils/InlineFunction.cpp

lib/Transforms/Utils/IntegerDivision.cpp

lib/Transforms/Utils/LCSSA.cpp

lib/Transforms/Utils/LibCallsShrinkWrap.cpp

lib/Transforms/Utils/Local.cpp

lib/Transforms/Utils/LoopSimplify.cpp

lib/Transforms/Utils/LoopUnroll.cpp

lib/Transforms/Utils/LoopUnrollPeel.cpp

lib/Transforms/Utils/LoopUnrollRuntime.cpp

lib/Transforms/Utils/LoopUtils.cpp

lib/Transforms/Utils/LowerInvoke.cpp

lib/Transforms/Utils/LowerSwitch.cpp

lib/Transforms/Utils/Mem2Reg.cpp

lib/Transforms/Utils/MemorySSA.cpp

lib/Transforms/Utils/ModuleUtils.cpp

lib/Transforms/Utils/PromoteMemoryToRegister.cpp

lib/Transforms/Utils/SSAUpdater.cpp

lib/Transforms/Utils/SimplifyCFG.cpp

lib/Transforms/Utils/SimplifyIndVar.cpp

lib/Transforms/Utils/SimplifyLibCalls.cpp

lib/Transforms/Utils/SplitModule.cpp

lib/Transforms/Utils/SymbolRewriter.cpp

lib/Transforms/Utils/ValueMapper.cpp

lib/Transforms/Vectorize/BBVectorize.cpp

lib/Transforms/Vectorize/LoadStoreVectorizer.cpp

lib/Transforms/Vectorize/LoopVectorize.cpp

lib/Transforms/Vectorize/SLPVectorizer.cpp

tools/bugpoint-passes/TestPasses.cpp

tools/bugpoint/CrashDebugger.cpp

tools/bugpoint/ExtractFunction.cpp

tools/bugpoint/Miscompilation.cpp

tools/lli/lli.cpp

tools/llvm-cxxdump/llvm-cxxdump.cpp

tools/llvm-diff/DiffConsumer.cpp

tools/llvm-diff/DifferenceEngine.cpp

tools/llvm-dis/llvm-dis.cpp

tools/llvm-nm/llvm-nm.cpp

tools/llvm-objdump/COFFDump.cpp

tools/llvm-objdump/ELFDump.cpp

tools/llvm-objdump/MachODump.cpp

tools/llvm-objdump/WasmDump.cpp

tools/llvm-objdump/llvm-objdump.cpp

tools/llvm-readobj/COFFDumper.cpp

tools/llvm-readobj/ELFDumper.cpp

tools/llvm-readobj/MachODumper.cpp

tools/llvm-readobj/llvm-readobj.cpp

tools/llvm-size/llvm-size.cpp

tools/llvm-stress/llvm-stress.cpp

tools/obj2yaml/obj2yaml.cpp

tools/opt/AnalysisWrappers.cpp

tools/sancov/sancov.cc

unittests/Analysis/LazyCallGraphTest.cpp

unittests/Analysis/ScalarEvolutionTest.cpp

unittests/AsmParser/AsmParserTest.cpp

unittests/IR/IRBuilderTest.cpp

unittests/IR/InstructionsTest.cpp

unittests/IR/MetadataTest.cpp

unittests/IR/UserTest.cpp

unittests/IR/VerifierTest.cpp

unittests/Linker/LinkModulesTest.cpp

unittests/Support/Casting.cpp

unittests/Support/YAMLParserTest.cpp

unittests/Transforms/Utils/Cloning.cpp

unittests/Transforms/Utils/IntegerDivision.cpp

unittests/Transforms/Utils/MemorySSA.cpp

utils/TableGen/AsmMatcherEmitter.cpp

utils/TableGen/AsmWriterEmitter.cpp

utils/TableGen/CodeEmitterGen.cpp

utils/TableGen/CodeGenDAGPatterns.cpp

utils/TableGen/CodeGenInstruction.cpp

utils/TableGen/CodeGenMapTable.cpp

utils/TableGen/CodeGenSchedule.cpp

utils/TableGen/DAGISelMatcher.cpp

utils/TableGen/DAGISelMatcherEmitter.cpp

utils/TableGen/DAGISelMatcherGen.cpp

utils/TableGen/DAGISelMatcherOpt.cpp

utils/TableGen/FastISelEmitter.cpp

utils/TableGen/FixedLenDecoderEmitter.cpp

utils/TableGen/InstrInfoEmitter.cpp

utils/TableGen/OptParserEmitter.cpp

utils/TableGen/PseudoLoweringEmitter.cpp

utils/TableGen/RegisterInfoEmitter.cpp

utils/TableGen/SearchableTableEmitter.cpp

utils/yaml-bench/YAMLBench.cpp