This is an archive of the discontinued LLVM Phabricator instance.

[lsan] [aarch64] Fix printing of pointers in make check tests - update
ClosedPublic

Authored by spetrovic on Oct 28 2016, 9:33 AM.

Details

Summary

This patch replaces fprintf with print_address function in LSAN tests. This is necessary because of different printing of pointers in fprintf and sanitizer's print function. After this patch is committed, we can enable make check-lsan option on aarch64 architecture.

Diff Detail

Event Timeline

spetrovic updated this revision to Diff 76207.Oct 28 2016, 9:33 AM
spetrovic retitled this revision from to [lsan] [aarch64] Fix printing of pointers in make check tests - update.
spetrovic updated this object.
spetrovic added subscribers: llvm-commits, petarj, ivanbaev.
kcc added inline comments.Oct 28 2016, 10:57 AM
test/tsan/deadlock_detector_stress_test.cc
14 ↗(On Diff #76207)

Don't change the tsan tests, instead include the new file into tsan's test.h

test/tsan/lit.cfg
47–49

use /../ instead of /../sanitizer_common/"
and then include sanitizer_common/print_address.h

spetrovic updated this revision to Diff 76403.Oct 31 2016, 7:46 AM
kubamracek added inline comments.Oct 31 2016, 10:31 AM
test/lsan/lit.common.cfg
34–36

For consistency, this should also be just /../ and the header should be included in LSan tests as #include "sanitizer_common/print_address.h".

spetrovic updated this revision to Diff 76538.Nov 1 2016, 3:41 AM
spetrovic marked an inline comment as done.

Comments addressed, thanks for review.

kcc accepted this revision.Nov 7 2016, 4:44 PM
kcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 7 2016, 4:44 PM
kcc added a comment.Nov 10 2016, 6:45 PM

will some one actually submit it?

kcc added a comment.Nov 15 2016, 6:31 PM

Hello, anyone?

spetrovic closed this revision.Nov 16 2016, 4:00 AM

This was committed a few days ago. I guess that the ending dot in the "Differential Revision" link prevented this issue to be automatically updated.

commit f2247b9c1a68a294ba6b027edc71808a5202ce3a
Author: Strahinja Petrovic <strahinja.petrovic@rt-rk.com>
Date: Mon Nov 14 11:40:56 2016 +0000

[lsan] [aarch64] Fix printing of pointers in make check tests - update

This patch replaces fprintf with print_address function in LSAN
tests. This is necessary because of different printing of pointers
in fprintf and sanitizer's print function.
Differential Revision: https://reviews.llvm.org/D26084.