Page MenuHomePhabricator

spetrovic (Strahinja Petrovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 29 2015, 9:35 AM (246 w, 22 m)

Recent Activity

Apr 2 2019

spetrovic committed rG4f839ac1883a: [PowerPC] Fix issue with inline asm - soft float mode (authored by spetrovic).
[PowerPC] Fix issue with inline asm - soft float mode
Apr 2 2019, 3:59 AM
spetrovic committed rL357466: [PowerPC] Fix issue with inline asm - soft float mode.
[PowerPC] Fix issue with inline asm - soft float mode
Apr 2 2019, 3:59 AM
spetrovic committed rC357466: [PowerPC] Fix issue with inline asm - soft float mode.
[PowerPC] Fix issue with inline asm - soft float mode
Apr 2 2019, 3:59 AM
spetrovic closed D59310: [PowerPC] Fix issue with inline asm - soft float mode.
Apr 2 2019, 3:59 AM · Restricted Project, Restricted Project
spetrovic updated the summary of D59310: [PowerPC] Fix issue with inline asm - soft float mode.
Apr 2 2019, 3:12 AM · Restricted Project, Restricted Project
spetrovic added a comment to D59310: [PowerPC] Fix issue with inline asm - soft float mode.

Sure, I will change summary, thanks for review!

Apr 2 2019, 3:11 AM · Restricted Project, Restricted Project

Mar 14 2019

spetrovic added a comment to D59310: [PowerPC] Fix issue with inline asm - soft float mode.

For this example:

Mar 14 2019, 10:16 AM · Restricted Project, Restricted Project

Mar 13 2019

spetrovic created D59310: [PowerPC] Fix issue with inline asm - soft float mode.
Mar 13 2019, 10:40 AM · Restricted Project, Restricted Project

Mar 6 2019

spetrovic committed rG94fccc93dec5: [PowerPC] Add secure plt support for TLS symbols (authored by spetrovic).
[PowerPC] Add secure plt support for TLS symbols
Mar 6 2019, 7:01 AM
spetrovic committed rL355513: [PowerPC] Add secure plt support for TLS symbols.
[PowerPC] Add secure plt support for TLS symbols
Mar 6 2019, 7:01 AM
spetrovic closed D45520: [PowerPC] add secure plt support for TLS symbols.
Mar 6 2019, 7:01 AM · Restricted Project

Feb 12 2019

spetrovic updated the diff for D56722: [lld] [ELF] Support for warn-once option.
Feb 12 2019, 7:54 AM · Restricted Project

Feb 11 2019

spetrovic updated the diff for D56722: [lld] [ELF] Support for warn-once option.
Feb 11 2019, 7:57 AM · Restricted Project

Feb 6 2019

Herald added a project to D56722: [lld] [ELF] Support for warn-once option: Restricted Project.

ping

Feb 6 2019, 7:53 AM · Restricted Project

Jan 21 2019

spetrovic added a comment to D56722: [lld] [ELF] Support for warn-once option.

Well yes, but it would be nicer not having to modify the scripts which we currently use in our build systems.

Jan 21 2019, 8:47 AM · Restricted Project

Jan 17 2019

spetrovic added a comment to D56722: [lld] [ELF] Support for warn-once option.

I have something like this in many places:

Jan 17 2019, 8:14 AM · Restricted Project

Jan 15 2019

spetrovic created D56722: [lld] [ELF] Support for warn-once option.
Jan 15 2019, 7:41 AM · Restricted Project

Sep 17 2018

spetrovic committed rL342368: [PowerPC] Fix label address calculation for ppc64.
[PowerPC] Fix label address calculation for ppc64
Sep 17 2018, 4:06 AM
spetrovic closed D50965: [PowerPC] Fix label address calculation for ppc64.
Sep 17 2018, 4:06 AM

Aug 28 2018

spetrovic updated the diff for D50965: [PowerPC] Fix label address calculation for ppc64.

Comments Addressed. Thanks for the review.

Aug 28 2018, 7:57 AM

Aug 20 2018

spetrovic created D50965: [PowerPC] Fix label address calculation for ppc64.
Aug 20 2018, 4:19 AM

Jun 19 2018

spetrovic committed rL335043: [PowerPC] Fix label address calculation for ppc32.
[PowerPC] Fix label address calculation for ppc32
Jun 19 2018, 6:12 AM
spetrovic closed D46582: [PowerPC] Fix label address calculation for ppc32.
Jun 19 2018, 6:12 AM

Jun 18 2018

spetrovic added inline comments to D45520: [PowerPC] add secure plt support for TLS symbols.
Jun 18 2018, 8:49 AM · Restricted Project

Jun 4 2018

spetrovic added a comment to D45520: [PowerPC] add secure plt support for TLS symbols.

ping

Jun 4 2018, 7:06 AM · Restricted Project
spetrovic added a comment to D46582: [PowerPC] Fix label address calculation for ppc32.

ping

Jun 4 2018, 7:06 AM

May 28 2018

spetrovic updated the diff for D46582: [PowerPC] Fix label address calculation for ppc32.
May 28 2018, 6:26 AM
spetrovic updated the diff for D45520: [PowerPC] add secure plt support for TLS symbols.
May 28 2018, 2:49 AM · Restricted Project

May 23 2018

spetrovic added a comment to D45520: [PowerPC] add secure plt support for TLS symbols.

ping

May 23 2018, 5:33 AM · Restricted Project
spetrovic added a comment to D46582: [PowerPC] Fix label address calculation for ppc32.

ping

May 23 2018, 5:33 AM

May 10 2018

spetrovic committed rC331979: This patch provides that bitfields are splitted even in case.
This patch provides that bitfields are splitted even in case
May 10 2018, 5:35 AM
spetrovic committed rL331979: This patch provides that bitfields are splitted even in case.
This patch provides that bitfields are splitted even in case
May 10 2018, 5:35 AM
spetrovic closed D39053: [Bitfield] Add more cases to making the bitfield a separate location.
May 10 2018, 5:35 AM

May 8 2018

spetrovic created D46582: [PowerPC] Fix label address calculation for ppc32.
May 8 2018, 7:38 AM

Apr 30 2018

spetrovic added a comment to D45520: [PowerPC] add secure plt support for TLS symbols.

ping

Apr 30 2018, 9:48 AM · Restricted Project

Apr 25 2018

spetrovic updated the diff for D39053: [Bitfield] Add more cases to making the bitfield a separate location.

Comments addressed

Apr 25 2018, 6:45 AM

Apr 20 2018

spetrovic updated the diff for D45520: [PowerPC] add secure plt support for TLS symbols.
Apr 20 2018, 5:13 AM · Restricted Project
spetrovic added a comment to D45520: [PowerPC] add secure plt support for TLS symbols.

Regarding secure plt in general I was using this document: http://devpit.org/wiki/Debugging_PowerPC_ELF_Binaries. This patch just expands secure-plt support for TLS symbols, basically the same thing as for functions symbols or global symbols in the last patch.
Also as a reference I'm using gcc.
I haven't run into example that fails because of shrink-wrapping. If this is a potential issue would not it have appeared so far, since
getGlobalBaseReg() is existing function and it was used before secure-plt support? Do you have some test case that potentially can reproduce issue related with shrink-wrapping?

Apr 20 2018, 5:09 AM · Restricted Project

Apr 16 2018

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

ping

Apr 16 2018, 10:25 AM

Apr 11 2018

spetrovic created D45520: [PowerPC] add secure plt support for TLS symbols.
Apr 11 2018, 7:59 AM · Restricted Project
spetrovic committed rC329795: [PowerPC] Option for secure plt mode.
[PowerPC] Option for secure plt mode
Apr 11 2018, 5:28 AM
spetrovic committed rL329795: [PowerPC] Option for secure plt mode.
[PowerPC] Option for secure plt mode
Apr 11 2018, 5:28 AM
spetrovic closed D44921: [PowerPC] Option for secure plt mode.
Apr 11 2018, 5:27 AM

Apr 4 2018

spetrovic added a comment to D44921: [PowerPC] Option for secure plt mode.

-mbss-plt is currently default in LLVM, once secure plt support is finished we can set secure plt as default in LLVM, but not for now.

Apr 4 2018, 4:16 AM

Mar 29 2018

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

ping

Mar 29 2018, 8:52 AM

Mar 28 2018

spetrovic added a comment to D44921: [PowerPC] Option for secure plt mode.

Yes, secure PLT is PowerPC specific feature.

Mar 28 2018, 3:54 AM
spetrovic added inline comments to D44921: [PowerPC] Option for secure plt mode.
Mar 28 2018, 3:46 AM
spetrovic updated the diff for D44921: [PowerPC] Option for secure plt mode.
Mar 28 2018, 3:46 AM

Mar 27 2018

spetrovic created D44921: [PowerPC] Option for secure plt mode.
Mar 27 2018, 5:45 AM
spetrovic committed rL328617: [PowerPC] Secure PLT support.
[PowerPC] Secure PLT support
Mar 27 2018, 4:26 AM
spetrovic closed D42112: [PowerPC] Secure PLT support.
Mar 27 2018, 4:26 AM

Mar 23 2018

spetrovic added a comment to D42112: [PowerPC] Secure PLT support.

Is this patch OK to commit now ?

Mar 23 2018, 9:12 AM

Mar 13 2018

spetrovic updated the diff for D42112: [PowerPC] Secure PLT support.
Mar 13 2018, 6:09 AM

Mar 12 2018

spetrovic added inline comments to D42112: [PowerPC] Secure PLT support.
Mar 12 2018, 10:08 AM

Mar 2 2018

spetrovic updated the diff for D42112: [PowerPC] Secure PLT support.
Mar 2 2018, 9:10 AM

Mar 1 2018

spetrovic updated the diff for D42112: [PowerPC] Secure PLT support.

Updated patch so it covers cases where we have just function call, without global variables as arguments or global variables used within function.

Mar 1 2018, 8:25 AM

Jan 29 2018

spetrovic updated the diff for D42112: [PowerPC] Secure PLT support.
Jan 29 2018, 9:52 AM

Jan 16 2018

spetrovic created D42112: [PowerPC] Secure PLT support.
Jan 16 2018, 10:00 AM

Dec 21 2017

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

ping

Dec 21 2017, 10:06 AM

Dec 11 2017

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

ping

Dec 11 2017, 9:43 AM

Nov 29 2017

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

I tried to compile some important libraries for X86 and MIPS64 within Chromium with clang/llvm. I have compared results between LLVM trunk, and LLVM trunk with my patch. There is code size improvement on many libraries, here are some results:

Nov 29 2017, 6:56 AM

Nov 7 2017

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

ping

Nov 7 2017, 4:30 AM

Nov 1 2017

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

I was looking if I can reslove this problem in backend. Example:

Nov 1 2017, 9:51 AM

Oct 25 2017

spetrovic added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

Well, basically I'm just expanding the existing algorithm, why should we split fields just in case when current field is integer,
I'm not resolving specific problem with unaligned loads/stores on MIPS.

Oct 25 2017, 7:02 AM

Oct 18 2017

spetrovic created D39053: [Bitfield] Add more cases to making the bitfield a separate location.
Oct 18 2017, 6:57 AM

Sep 21 2017

spetrovic added a reverting change for rL312318: Debug info for variables whose type is shrinked to bool: rL313870: Fixed reverted commit rL312318.
Sep 21 2017, 3:05 AM
spetrovic committed rL313870: Fixed reverted commit rL312318.
Fixed reverted commit rL312318
Sep 21 2017, 3:05 AM

Sep 12 2017

spetrovic committed rL313018: [ARM] Option for reading thread pointer from coprocessor register.
[ARM] Option for reading thread pointer from coprocessor register
Sep 12 2017, 3:42 AM
spetrovic closed D34878: [ARM] Option for reading thread pointer from coprocessor register by committing rL313018: [ARM] Option for reading thread pointer from coprocessor register.
Sep 12 2017, 3:42 AM

Sep 11 2017

spetrovic updated the diff for D34878: [ARM] Option for reading thread pointer from coprocessor register.

Indentations fixed.

Sep 11 2017, 8:42 AM
spetrovic added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

Thanks for the review! I will check indentations with clang format.

Sep 11 2017, 6:30 AM
spetrovic updated the diff for D34878: [ARM] Option for reading thread pointer from coprocessor register.
Sep 11 2017, 6:16 AM
spetrovic added inline comments to D34878: [ARM] Option for reading thread pointer from coprocessor register.
Sep 11 2017, 5:34 AM
spetrovic added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

Comments addressed.

Sep 11 2017, 5:22 AM
spetrovic updated the diff for D34878: [ARM] Option for reading thread pointer from coprocessor register.
Sep 11 2017, 5:21 AM

Sep 8 2017

spetrovic updated the diff for D34878: [ARM] Option for reading thread pointer from coprocessor register.
Sep 8 2017, 3:05 AM
spetrovic added inline comments to D34878: [ARM] Option for reading thread pointer from coprocessor register.
Sep 8 2017, 3:04 AM

Sep 4 2017

spetrovic committed rL312489: Fix test/Transforms/GlobalOpt/integer-bool-dwarf.
Fix test/Transforms/GlobalOpt/integer-bool-dwarf
Sep 4 2017, 8:15 AM

Sep 1 2017

spetrovic committed rL312325: Adding missing test case in rL312318.
Adding missing test case in rL312318
Sep 1 2017, 4:40 AM
spetrovic committed rL312318: Debug info for variables whose type is shrinked to bool.
Debug info for variables whose type is shrinked to bool
Sep 1 2017, 3:06 AM
spetrovic closed D35994: Debug info for variables whose type is shrinked to bool by committing rL312318: Debug info for variables whose type is shrinked to bool.
Sep 1 2017, 3:06 AM
spetrovic added a reviewer for D34878: [ARM] Option for reading thread pointer from coprocessor register: kristof.beyls.
Sep 1 2017, 2:48 AM

Aug 30 2017

spetrovic committed rL312111: [MIPS] Add support to match more patterns for BBIT instruction.
[MIPS] Add support to match more patterns for BBIT instruction
Aug 30 2017, 4:26 AM
spetrovic closed D36222: [MIPS] Add support to match more patterns for BBIT instruction. by committing rL312111: [MIPS] Add support to match more patterns for BBIT instruction.
Aug 30 2017, 4:26 AM

Aug 28 2017

spetrovic added a comment to D36222: [MIPS] Add support to match more patterns for BBIT instruction..

Comments addressed.

Aug 28 2017, 6:14 AM
spetrovic updated the diff for D36222: [MIPS] Add support to match more patterns for BBIT instruction..
Aug 28 2017, 6:14 AM

Aug 25 2017

spetrovic added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

ping

Aug 25 2017, 3:07 AM

Aug 4 2017

spetrovic added a comment to D36222: [MIPS] Add support to match more patterns for BBIT instruction..

Comments addressed.

Aug 4 2017, 7:07 AM
spetrovic updated the diff for D36222: [MIPS] Add support to match more patterns for BBIT instruction..
Aug 4 2017, 7:07 AM

Aug 3 2017

spetrovic added inline comments to D34878: [ARM] Option for reading thread pointer from coprocessor register.
Aug 3 2017, 9:09 AM
spetrovic updated the diff for D34878: [ARM] Option for reading thread pointer from coprocessor register.
Aug 3 2017, 9:09 AM

Aug 2 2017

spetrovic updated the diff for D36222: [MIPS] Add support to match more patterns for BBIT instruction..
Aug 2 2017, 7:56 AM
spetrovic created D36222: [MIPS] Add support to match more patterns for BBIT instruction..
Aug 2 2017, 7:54 AM

Aug 1 2017

spetrovic committed rL309679: [Mips] Fix for BBIT octeon instruction.
[Mips] Fix for BBIT octeon instruction
Aug 1 2017, 6:44 AM
spetrovic closed D35359: [Mips] Fix for BBIT octeon instruction by committing rL309679: [Mips] Fix for BBIT octeon instruction.
Aug 1 2017, 6:43 AM
spetrovic added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

Comments addressed.

Aug 1 2017, 5:32 AM
spetrovic updated the diff for D34878: [ARM] Option for reading thread pointer from coprocessor register.
Aug 1 2017, 5:14 AM

Jul 28 2017

spetrovic committed rL309381: [ARM] Add the option to directly access TLS pointer.
[ARM] Add the option to directly access TLS pointer
Jul 28 2017, 5:55 AM
spetrovic closed D34408: [ARM] - Add the option to directly access TLS pointer by committing rL309381: [ARM] Add the option to directly access TLS pointer.
Jul 28 2017, 5:55 AM

Jul 25 2017

spetrovic added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

Hi Bruno,

Jul 25 2017, 8:51 AM