Implement vector_insert_exp builtins - clang portion

[syzaara]

Summary

Add vec_insert_exp with prototypes:

vector double vec_insert_exp (vector double, vector unsigned long long);
vector double vec_insert_exp (vector unsigned long long, vector unsigned long long);
vector float vec_insert_exp (vector float, vector unsigned int);
vector float vec_insert_exp (vector unsigned int, vector unsigned int);

[amehsan]

@syzaara @sfertile

When you create a patch, you need to subscribe llvm-commits as well. This is a mailing list. Unfortunately there is a phabricator bug, that if you do not add llvm-commits when you create the patch, an email will not be sent to it, when you subscribe it afterwards. So technically some people may ask you to create your patch again if llvm-commits is not subscribed. I leave it to @kbarton if he wants you to create the patch again. I subscribe llvm-commits to this patch so you are familiar with the ID for the future patches.

[amehsan]

I realized @sfertile has that subscription on his patch :)

[nemanjai]

In D25956#578865, @amehsan wrote:

@syzaara @sfertile

When you create a patch, you need to subscribe llvm-commits as well. This is a mailing list. Unfortunately there is a phabricator bug, that if you do not add llvm-commits when you create the patch, an email will not be sent to it, when you subscribe it afterwards. So technically some people may ask you to create your patch again if llvm-commits is not subscribed. I leave it to @kbarton if he wants you to create the patch again. I subscribe llvm-commits to this patch so you are familiar with the ID for the future patches.

This applies to the LLVM portion of this patch. For the clang ones, we should subscribe cfe-commits. Thanks for pointing this out @amehsan. I haven't checked the patches from @jtony and @sfertile, but in any case we should be sure to subscribe the right "commits" list to our patches so that the community sees our patches.

[amehsan]

In D25956#578930, @nemanjai wrote:

In D25956#578865, @amehsan wrote:

@syzaara @sfertile

When you create a patch, you need to subscribe llvm-commits as well. This is a mailing list. Unfortunately there is a phabricator bug, that if you do not add llvm-commits when you create the patch, an email will not be sent to it, when you subscribe it afterwards. So technically some people may ask you to create your patch again if llvm-commits is not subscribed. I leave it to @kbarton if he wants you to create the patch again. I subscribe llvm-commits to this patch so you are familiar with the ID for the future patches.

This applies to the LLVM portion of this patch. For the clang ones, we should subscribe cfe-commits. Thanks for pointing this out @amehsan. I haven't checked the patches from @jtony and @sfertile, but in any case we should be sure to subscribe the right "commits" list to our patches so that the community sees our patches.

You are right :-)

[nemanjai]

lib/Headers/altivec.h

2500

Hmm... I think

&& __POWER9_VECTOR__

test/CodeGen/builtins-ppc-p9vector.c

704

I don't think this is guaranteed to succeed. If I remember correctly, Clang names temporaries differently with and without asserts. Maybe it wasn't asserts, but I remember something made Clang choose different names for temporaries (rather than %0, %1, etc.). So I think this should suffice as the regex pattern:
%{{.+}}

[nemanjai]

lib/Headers/altivec.h

2500

Actually, I take that back. It should only be POWER9_VECTOR.
This is important to get right because using this on a P8 or older machine will cause a run-time rather than a compile-time failure (i.e. it will compile just fine and executing the code would result in an illegal instruction).

[echristo]

Agreeing with Nemanja on a comment, once they're happy this LGTM.

-eric

lib/Headers/altivec.h

2500

+1

test/CodeGen/builtins-ppc-p9vector.c

704

Correct.

[Eugene.Zelenko]

lib/Headers/altivec.h

2502

Please remove space between function name and open bracket. Same below.

[syzaara]

Fix formatting, remove #ifdef VSX, and update regex for test.

[nemanjai]

Committed revision 285229.
Zaara, please close this review when you get in if there are no buildbot failures in the meantime.

include/clang/Basic/BuiltinsPPC.def

 BUILTIN(__builtin_vsx_xxleqv, "V4UiV4UiV4Ui", "")
 
 BUILTIN(__builtin_vsx_xvcpsgndp, "V2dV2dV2d", "")
 BUILTIN(__builtin_vsx_xvcpsgnsp, "V4fV4fV4f", "")
 
 BUILTIN(__builtin_vsx_xvabssp, "V4fV4f", "")
 BUILTIN(__builtin_vsx_xvabsdp, "V2dV2d", "")
 
+BUILTIN(__builtin_vsx_xviexpdp, "V2dV2ULLiV2ULLi", "")
+BUILTIN(__builtin_vsx_xviexpsp, "V4fV4UiV4Ui", "")
+
 // HTM builtins
 BUILTIN(__builtin_tbegin, "UiUIi", "")
 BUILTIN(__builtin_tend, "UiUIi", "")
 
 BUILTIN(__builtin_tabort, "UiUi", "")
 BUILTIN(__builtin_tabortdc, "UiUiUiUi", "")
 BUILTIN(__builtin_tabortdci, "UiUiUii", "")
 BUILTIN(__builtin_tabortwc, "UiUiUiUi", "")

lib/Headers/altivec.h

#else
     vec_cntlz((vector unsigned long long)vec_cmpnez(__a, __b));
 #endif
   if (__res[0] == 64) {
     return (__res[1] + 64) >> 5;
   }
   return __res[0] >> 5;
 }
 
+static __inline__ vector double  __ATTRS_o_ai
+vec_insert_exp(vector double __a, vector unsigned long long __b) {
+  return __builtin_vsx_xviexpdp((vector unsigned long long)__a,__b);
+}
+
+static __inline__ vector double  __ATTRS_o_ai
+vec_insert_exp(vector unsigned long long __a, vector unsigned long long __b) {
+  return __builtin_vsx_xviexpdp(__a,__b);
+}
+
+static __inline__ vector float  __ATTRS_o_ai
+vec_insert_exp(vector float __a, vector unsigned int __b) {
+  return __builtin_vsx_xviexpsp((vector unsigned int)__a,__b);
+}
+
+static __inline__ vector float  __ATTRS_o_ai
+vec_insert_exp(vector unsigned int __a, vector unsigned int __b) {
+  return __builtin_vsx_xviexpsp(__a,__b);
+}
+
 #endif
 
 /* vec_cpsgn */
 
 #ifdef __VSX__
 static __inline__ vector float __ATTRS_o_ai vec_cpsgn(vector float __a,
                                                       vector float __b) {
   return __builtin_vsx_xvcpsgnsp(__a, __b);

test/CodeGen/builtins-ppc-p9vector.c

 }
 vector unsigned short test54(void) {
 // CHECK-BE: @llvm.ctpop.v8i16(<8 x i16>
 // CHECK-BE-NEXT: ret <8 x i16>
 // CHECK: @llvm.ctpop.v8i16(<8 x i16>
 // CHECK-NEXT: ret <8 x i16>
   return vec_popcnt (vusa);
 }
+vector double test55(void) {
+// CHECK-BE: @llvm.ppc.vsx.xviexpdp(<2 x i64> %{{.+}}, <2 x i64>
+// CHECK-BE-NEXT: ret <2 x double>
+// CHECK: @llvm.ppc.vsx.xviexpdp(<2 x i64> %{{.+}}, <2 x i64>
+// CHECK-NEXT: ret <2 x double>
+  return vec_insert_exp (vda,vulb);
+}
+vector double test56(void) {
+// CHECK-BE: @llvm.ppc.vsx.xviexpdp(<2 x i64> %{{.+}}, <2 x i64>
+// CHECK-BE-NEXT: ret <2 x double>
+// CHECK: @llvm.ppc.vsx.xviexpdp(<2 x i64> %{{.+}}, <2 x i64>
+// CHECK-NEXT: ret <2 x double>
+  return vec_insert_exp (vula, vulb);
+}
+vector float test57(void) {
+// CHECK-BE: @llvm.ppc.vsx.xviexpsp(<4 x i32> %{{.+}}, <4 x i32>
+// CHECK-BE-NEXT: ret <4 x float>
+// CHECK: @llvm.ppc.vsx.xviexpsp(<4 x i32> %{{.+}}, <4 x i32>
+// CHECK-NEXT: ret <4 x float>
+  return vec_insert_exp (vfa,vuib);
+}
+vector float test58(void) {
+// CHECK-BE: @llvm.ppc.vsx.xviexpsp(<4 x i32> %{{.+}}, <4 x i32>
+// CHECK-BE-NEXT: ret <4 x float>
+// CHECK: @llvm.ppc.vsx.xviexpsp(<4 x i32> %{{.+}}, <4 x i32>
+// CHECK-NEXT: ret <4 x float>
+  return vec_insert_exp (vuia,vuib);
+}