Page MenuHomePhabricator

Move the global variables representing each Target behind accessor function
ClosedPublic

Authored by mehdi_amini on Oct 9 2016, 2:37 PM.

Event Timeline

mehdi_amini updated this revision to Diff 74083.Oct 9 2016, 2:37 PM
mehdi_amini retitled this revision from to Move the global variables representing each Target behind accessor function.
mehdi_amini updated this object.
mehdi_amini added reviewers: echristo, chandlerc.
mehdi_amini added a subscriber: llvm-commits.
jlebar added a subscriber: jlebar.Oct 9 2016, 3:19 PM
jlebar added inline comments.
lib/Target/AArch64/TargetInfo/AArch64TargetInfo.cpp
26

Add // namespace llvm?

lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp
13–16

Typo? If not I'm not sure what you're trying to do here, probably deserves a comment.

15

Same for this function body -- if it's not a typo, it's not clear to me what you're trying to do, or why.

lib/Target/BPF/TargetInfo/BPFTargetInfo.cpp
18–27

// namespace llvm?

lib/Target/Lanai/TargetInfo/LanaiTargetInfo.cpp
21

"// namespace llvm"?

mehdi_amini updated this revision to Diff 74086.Oct 9 2016, 4:05 PM
mehdi_amini marked an inline comment as done.
mehdi_amini edited edge metadata.

Address Justin's comments.

mehdi_amini marked 4 inline comments as done.Oct 9 2016, 4:05 PM
mehdi_amini added inline comments.
lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp
15

That's the script I used to update all these that went wrong...
(And AVR is experimental so not built by default)

jlebar accepted this revision.Oct 9 2016, 4:07 PM
jlebar added a reviewer: jlebar.
jlebar added inline comments.
lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp
14

Probably should be called TheAVRTarget?

This revision is now accepted and ready to land.Oct 9 2016, 4:07 PM
mehdi_amini marked an inline comment as done.Oct 9 2016, 4:09 PM

Thanks Justin!

lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp
14

Sure, did the change before committing.

ast added a subscriber: ast.Oct 9 2016, 5:14 PM

BPF bits look fine. Thanks