Page MenuHomePhabricator

ast (Alexei Starovoitov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2014, 6:51 PM (245 w, 5 d)

Recent Activity

Sat, Aug 17

ast accepted D66372: [BPF] Fix bpf llvm-objdump issues.
Sat, Aug 17, 8:14 AM · Restricted Project

Sat, Aug 3

ast accepted D65700: [Transforms] Do not drop !preserve.access.index metadata.

lgtm

Sat, Aug 3, 11:31 AM · Restricted Project

Fri, Aug 2

ast accepted D65618: [BPF] Handling type conversions correctly for CO-RE.

looks good now. thanks

Fri, Aug 2, 4:06 PM · Restricted Project
ast accepted D65664: [BPF] annotate DIType metadata for builtin preseve_array_access_index().
Fri, Aug 2, 11:59 AM · Restricted Project, Restricted Project

Thu, Aug 1

ast accepted D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index().

and the diff is shorter now :)

Thu, Aug 1, 5:05 PM · Restricted Project
ast added inline comments to D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index().
Thu, Aug 1, 4:04 PM · Restricted Project

Wed, Jul 24

ast accepted D65259: fix typedef issue for offset relocation.
Wed, Jul 24, 9:14 PM · Restricted Project
ast accepted D65258: fix CO-RE incorrect index access string.
Wed, Jul 24, 9:11 PM · Restricted Project

Jul 14 2019

ast accepted D64598: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic.
Jul 14 2019, 8:04 PM · Restricted Project
ast accepted D64606: [BPF] add unit tests for preserve_{array,union,struct}_access_index intrinsics.
Jul 14 2019, 8:04 PM · Restricted Project

Jun 24 2019

ast accepted D61524: [BPF] Support for compile once and run everywhere.
Jun 24 2019, 12:38 PM · Restricted Project

May 28 2019

ast accepted D61809: [BPF] Preserve debuginfo array/union/struct type/access index.

lgtm

May 28 2019, 5:22 PM · Restricted Project, Restricted Project
ast accepted D61524: [BPF] Support for compile once and run everywhere.
May 28 2019, 5:22 PM · Restricted Project

May 26 2019

ast accepted D62460: [BPF] generate R_BPF_NONE relocation for BTF DataSec variables.
May 26 2019, 7:55 AM · Restricted Project

May 23 2019

ast added inline comments to D61524: [BPF] Support for compile once and run everywhere.
May 23 2019, 7:01 PM · Restricted Project
ast added inline comments to D61524: [BPF] Support for compile once and run everywhere.
May 23 2019, 6:11 PM · Restricted Project
ast accepted D61809: [BPF] Preserve debuginfo array/union/struct type/access index.

from kernel, libbpf, tooling and user experience points of view this approach looks the best to me.

May 23 2019, 6:07 PM · Restricted Project, Restricted Project

May 12 2019

ast accepted D61826: [BPF] emit BTF sections only if debuginfo available.
May 12 2019, 6:59 PM · Restricted Project

Apr 25 2019

ast accepted D61173: [BPF] do not generate predefined macro bpf.

Macro shipit:

Apr 25 2019, 11:22 PM · Restricted Project, Restricted Project
ast added inline comments to D61173: [BPF] do not generate predefined macro bpf.
Apr 25 2019, 11:01 PM · Restricted Project, Restricted Project

Mar 28 2019

ast accepted D59943: [BPF] add proper multi-dimensional array support.
Mar 28 2019, 9:21 AM · Restricted Project

Mar 15 2019

ast accepted D59441: [BPF] Add BTF Var and DataSec Support.
Mar 15 2019, 10:28 PM · Restricted Project

Mar 4 2019

ast accepted D58936: [BPF] Do not generate BTF sections unnecessarily.
Mar 4 2019, 4:51 PM · Restricted Project

Jan 30 2019

ast accepted D57436: gn build: Add BPF target..
In D57436#1377680, @ast wrote:

hmm. so you're saying when we add new file to the normal CMakeFiles, we don't need to touch GN ?

Yes.

Jan 30 2019, 1:18 PM
ast added a comment to D57436: gn build: Add BPF target..

hmm. so you're saying when we add new file to the normal CMakeFiles, we don't need to touch GN ?
So it's going to bit rot immediately?
what's the purpose of this GN work then?

Jan 30 2019, 1:03 PM

Jan 29 2019

ast added a reviewer for D57436: gn build: Add BPF target.: yonghong-song.
Jan 29 2019, 8:59 PM
ast requested changes to D57436: gn build: Add BPF target..

thanks for doing this work.
any pointers to read about GN?
Also please include code owners as reviewers next time.

Jan 29 2019, 8:59 PM

Nov 26 2018

ast added a comment to D53736: [BTF] Add BTF DebugInfo.

I find that there hasn't been actual discussion on the mailing list

Nov 26 2018, 8:51 AM · debug-info

Oct 31 2018

ast accepted D53736: [BTF] Add BTF DebugInfo.

Eric, David, any objections to land it now?
It's orthogonal to everything else in the llvm land and we'll keep working on it for foreseeable future.
All comments were addressed and any further refactoring requests can be done later.
I'd like to avoid sitting on it for too long, since a bunch of folks in bpf community are waiting on it.
We have two large sets of kernel patches that depend on it.
We'd like to land llvm bits first, so our kernel test bots can do testing with latest llvm trunk and latest kernel tree asap.

Oct 31 2018, 4:28 PM · debug-info

Oct 12 2018

ast accepted D52950: [BPF] Add BTF generation for BPF target.

we will be landing this shortly.
BTF side was thoroughly tested and kernel support was there for some time.
If there is a better way to integrate BTF with MC please let us know.

Oct 12 2018, 9:19 AM · debug-info

Dec 5 2017

ast accepted rL315889: bpf: fix bug on silently truncating 64-bit immediate.
Dec 5 2017, 8:39 AM

Nov 18 2017

ast committed rL318615: [bpf] remove unused variable.
[bpf] remove unused variable
Nov 18 2017, 6:43 PM
ast committed rL318614: [bpf] allow direct and indirect calls.
[bpf] allow direct and indirect calls
Nov 18 2017, 5:35 PM

Jun 2 2017

ast accepted D33849: DAG: Undo and->or combine with FrameIndexes.

bpf side looks good and this undo of 'or' back into 'add' is useful for bpf backend as well,
since 'ptr |= const' is not recognized by the kernel and bpf backend emits only 'ptr +=' which causes unnecessary ugly code in places like in this test.

Jun 2 2017, 4:07 PM

May 26 2017

ast committed rL304043: [bpf] disallow global_addr+off folding.
[bpf] disallow global_addr+off folding
May 26 2017, 3:33 PM

May 5 2017

ast committed rL302265: [bpf] fix a bug which causes incorrect big endian reloc fixup.
[bpf] fix a bug which causes incorrect big endian reloc fixup
May 5 2017, 11:18 AM

May 3 2017

ast committed rL302055: [bpf] add relocation support.
[bpf] add relocation support
May 3 2017, 10:44 AM

Apr 28 2017

ast committed rL301653: [bpf] add bigendian support to disassembler.
[bpf] add bigendian support to disassembler
Apr 28 2017, 10:04 AM

Apr 13 2017

ast committed rL300269: [bpf] Fix memory offset check for loads and stores.
[bpf] Fix memory offset check for loads and stores
Apr 13 2017, 3:37 PM
ast closed D32055: [bpf] Fix memory offset check for loads and stores by committing rL300269: [bpf] Fix memory offset check for loads and stores.
Apr 13 2017, 3:37 PM
ast accepted D32055: [bpf] Fix memory offset check for loads and stores.
Apr 13 2017, 3:10 PM
ast commandeered D32055: [bpf] Fix memory offset check for loads and stores.
Apr 13 2017, 3:10 PM
ast accepted D32055: [bpf] Fix memory offset check for loads and stores.
Apr 13 2017, 3:07 PM

Jan 17 2017

ast requested changes to D28824: Revert r292204 as it introduces a stack-use-after-scope issue..

unnecessary anymore.

Jan 17 2017, 1:26 PM
ast committed rL292258: [bpf] fix stack-use-after-scope.
[bpf] fix stack-use-after-scope
Jan 17 2017, 1:25 PM

Jan 16 2017

ast committed rL292204: [bpf] error when unknown bpf helper is called.
[bpf] error when unknown bpf helper is called
Jan 16 2017, 11:37 PM
ast committed rL292180: [bpf] error when BPF stack size exceeds 512 bytes.
[bpf] error when BPF stack size exceeds 512 bytes
Jan 16 2017, 5:16 PM

Jan 6 2017

ast accepted rL291297: [BPF] Fix some Clang-tidy modernize and Include What You Use warnings; other….

lgtm

Jan 6 2017, 5:50 PM

Dec 13 2016

ast committed rL289569: [bpf] change llvm-objdump to print dec instead of hex.
[bpf] change llvm-objdump to print dec instead of hex
Dec 13 2016, 11:17 AM

Nov 20 2016

ast committed rL287522: [bpf] attempt to fix big-endian bots.
[bpf] attempt to fix big-endian bots
Nov 20 2016, 11:36 PM
ast committed rL287521: [bpf] fix dwarf elf relocs and line numbers.
[bpf] fix dwarf elf relocs and line numbers
Nov 20 2016, 10:31 PM

Nov 19 2016

ast committed rL287477: [bpf] add BPF disassembler.
[bpf] add BPF disassembler
Nov 19 2016, 6:35 PM

Nov 17 2016

ast committed rL287300: convert bpf assembler to look like kernel verifier output.
convert bpf assembler to look like kernel verifier output
Nov 17 2016, 6:42 PM

Oct 9 2016

ast added a comment to D25412: Move the global variables representing each Target behind accessor function.

BPF bits look fine. Thanks

Oct 9 2016, 5:14 PM

Oct 6 2016

ast added a comment to D25355: Target: Replace most PatLeaf patterns that match immediates with ImmLeaf patterns. NFCI..

nice cleanup. bpf bits look fine

Oct 6 2016, 7:20 PM

Sep 28 2016

ast accepted D24822: [SelectionDAG] Enable division-by-constant optimization for wide types.

lgtm
there are different front-ends and we cannot control them all, so backend has to have end-user understandable errors, though it's not pretty.

Sep 28 2016, 9:05 AM

Sep 27 2016

ast requested changes to D24822: [SelectionDAG] Enable division-by-constant optimization for wide types.
Sep 27 2016, 1:40 PM
ast added inline comments to D24822: [SelectionDAG] Enable division-by-constant optimization for wide types.
Sep 27 2016, 8:04 AM

Aug 12 2016

ast updated subscribers of D23457: Don't break curses applications in terminalHasColors().
Aug 12 2016, 5:43 PM

Jul 15 2016

ast committed rL275633: BPF: Use official ELF e_machine value.
BPF: Use official ELF e_machine value
Jul 15 2016, 3:35 PM

May 27 2016

ast accepted D20726: [BPF] Remove exit-on-error from tests (PR27768, PR27769).

looks good. thanks!

May 27 2016, 8:20 AM

May 25 2016

ast accepted D20571: [BPF] Remove exit-on-error flag in test (PR27767).

thanks!

May 25 2016, 9:31 AM

May 24 2016

ast requested changes to D20571: [BPF] Remove exit-on-error flag in test (PR27767).
May 24 2016, 11:06 AM

May 20 2016

ast accepted D20471: [BPF] Remove exit-on-error flag in test (PR27766).

lgtm
thanks

May 20 2016, 8:55 AM

Mar 18 2016

ast committed rL263842: BPF: emit an error message for unsupported signed division operation.
BPF: emit an error message for unsupported signed division operation
Mar 18 2016, 3:07 PM

Jan 27 2016

ast accepted D16591: Add backend dignostic printer for unsupported features.

thanks

Jan 27 2016, 9:02 AM

Jan 26 2016

ast added a comment to D16591: Add backend dignostic printer for unsupported features.

looks good.
could you add a testcase for DK_Unsupported ?

Jan 26 2016, 10:56 AM
ast accepted D16590: Refactor backend diagnostics for unsupported features.

lgtm as well. Thank you for working on this.

Jan 26 2016, 10:48 AM

Oct 23 2015

ast committed rL251177: Merging r249718:.
Merging r249718:
Oct 23 2015, 7:05 PM
ast committed rL251175: Merging r249371:.
Merging r249371:
Oct 23 2015, 7:00 PM
ast committed rL251174: Merging r247951:.
Merging r247951:
Oct 23 2015, 6:56 PM

Oct 8 2015

ast added auditors to rL249718: [bpf] Do not expand UNDEF SDNode during insn selection lowering: Restricted Project, llvm-commits, tstellarAMD.

bug fix

Oct 8 2015, 7:10 PM · Restricted Project
ast added auditors to rL249371: [bpf] Avoid extra pointer arithmetic for stack access: Restricted Project, llvm-commits, tstellarAMD.

bug fix

Oct 8 2015, 7:09 PM · Restricted Project
ast added auditors to rL247951: [bpf] expand indirect branches: Restricted Project, llvm-commits, tstellarAMD, ast.

important bug fix

Oct 8 2015, 7:06 PM · Restricted Project
ast committed rL249718: [bpf] Do not expand UNDEF SDNode during insn selection lowering.
[bpf] Do not expand UNDEF SDNode during insn selection lowering
Oct 8 2015, 11:54 AM · Restricted Project

Oct 5 2015

ast committed rL249371: [bpf] Avoid extra pointer arithmetic for stack access.
[bpf] Avoid extra pointer arithmetic for stack access
Oct 5 2015, 9:02 PM · Restricted Project

Sep 17 2015

ast committed rL247951: [bpf] expand indirect branches.
[bpf] expand indirect branches
Sep 17 2015, 3:19 PM · Restricted Project

Sep 10 2015

ast committed rL247340: Use 'Release' configuration for the BPF builder.
Use 'Release' configuration for the BPF builder
Sep 10 2015, 2:38 PM

Aug 14 2015

ast committed rL245105: [bpf] add documentation and instruction set description.
[bpf] add documentation and instruction set description
Aug 14 2015, 3:01 PM

Jul 23 2015

ast committed rL243087: [bpf] initial support for debug_info.
[bpf] initial support for debug_info
Jul 23 2015, 8:17 PM

Jun 17 2015

ast committed rL239979: [zorg][bpf] add experimental BPF buildbot.
[zorg][bpf] add experimental BPF buildbot
Jun 17 2015, 5:23 PM

Jun 10 2015

ast committed rL239496: [bpf] add support for BPF backend.
[bpf] add support for BPF backend
Jun 10 2015, 4:03 PM

Jun 9 2015

ast committed rL239456: fix crash.
fix crash
Jun 9 2015, 8:10 PM
ast committed rL239425: [bpf] enable BPF backend in autoconf build.
[bpf] enable BPF backend in autoconf build
Jun 9 2015, 11:57 AM
ast committed rL239410: [bpf] make BPF backend non-experimental.
[bpf] make BPF backend non-experimental
Jun 9 2015, 8:50 AM

Jun 5 2015

ast committed rL239162: [bpf] rename triple names bpf_be -> bpfeb.
[bpf] rename triple names bpf_be -> bpfeb
Jun 5 2015, 9:15 AM
ast committed rL239159: Revert "Include BPF target in CMake builds.".
Revert "Include BPF target in CMake builds."
Jun 5 2015, 8:36 AM

Jun 4 2015

ast committed rL239071: [bpf] add big- and host- endian support.
[bpf] add big- and host- endian support
Jun 4 2015, 12:19 PM
ast closed D10177: [bpf] add big- and host- endian support by committing rL239071: [bpf] add big- and host- endian support.
Jun 4 2015, 12:19 PM
ast updated the diff for D10177: [bpf] add big- and host- endian support.
Jun 4 2015, 12:00 PM

Jun 1 2015

ast retitled D10177: [bpf] add big- and host- endian support from to [bpf] add big- and host- endian support.
Jun 1 2015, 8:07 PM
ast committed rL238792: [bpf] fix build.
[bpf] fix build
Jun 1 2015, 3:28 PM

May 22 2015

ast committed rL238038: [bpf] emit jmp fixups in little endian.
[bpf] emit jmp fixups in little endian
May 22 2015, 11:51 AM

May 19 2015

ast committed rL237751: [bpf] fix build.
[bpf] fix build
May 19 2015, 5:24 PM

Apr 28 2015

ast committed rL236030: [bpf] fix build.
[bpf] fix build
Apr 28 2015, 1:42 PM

Apr 25 2015

ast committed rL235814: [bpf] fix build and remove a compiler warning in Release mode.
[bpf] fix build and remove a compiler warning in Release mode
Apr 25 2015, 7:01 PM

Apr 14 2015

ast committed rL234971: [bpf] fix build.
[bpf] fix build
Apr 14 2015, 7:52 PM

Apr 7 2015

ast committed rL234386: [bpf] support BPF backend as shared library.
[bpf] support BPF backend as shared library
Apr 7 2015, 8:49 PM
ast committed rL234349: [bpf] fix build.
[bpf] fix build
Apr 7 2015, 1:28 PM

Mar 30 2015

ast committed rL233666: [bpf] mark mov instructions as ReMaterializable.
[bpf] mark mov instructions as ReMaterializable
Mar 30 2015, 7:53 PM