This is an archive of the discontinued LLVM Phabricator instance.

Differential D24698

[asan] Stop appending -lm, -pthread and other linker options on Darwin for ASan unit tests
ClosedPublic

Authored by kubamracek on Sep 17 2016, 1:32 AM.

Details

Reviewers
kcc
filcab
eugenis
rnk
Commits
rG7bc254f89c4d: [asan] Stop appending -lm, -pthread and other linker options on Darwin for ASan…
rCRT282260: [asan] Stop appending -lm, -pthread and other linker options on Darwin for ASan…
rL282260: [asan] Stop appending -lm, -pthread and other linker options on Darwin for…
Summary

On Darwin, -lm, -pthread and others are implied. -pthread currently produces a warning (compiler option unused).

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 71727.Sep 17 2016, 1:32 AM
kubamracek retitled this revision from to [asan] Stop appending -lm, -pthread and other linker options on Darwin for ASan unit tests.
kubamracek updated this object.
kubamracek added reviewers: rnk, filcab, kcc, eugenis.
kubamracek added a project: Restricted Project.
kubamracek added subscribers: llvm-commits, zaks.anna.
Herald added subscribers: mgorny, beanz, kubamracek. · View Herald TranscriptSep 17 2016, 1:32 AM
eugenis accepted this revision.Sep 19 2016, 2:25 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 19 2016, 2:25 PM
Closed by commit rL282260: [asan] Stop appending -lm, -pthread and other linker options on Darwin for… (authored by kuba.brecka). · Explain WhySep 23 2016, 9:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
asan/
tests/
13 lines

Diff 71727

lib/asan/tests/CMakeLists.txt

Show First 20 Lines • Show All 100 Lines • ▼ Show 20 Linesset(ASAN_DYNAMIC_UNITTEST_INSTRUMENTED_LINKFLAGS
${ASAN_UNITTEST_INSTRUMENTED_LINKFLAGS} ${ASAN_UNITTEST_INSTRUMENTED_LINKFLAGS}
-shared-libasan) -shared-libasan)
set(ASAN_UNITTEST_INSTRUMENTED_LIBS) set(ASAN_UNITTEST_INSTRUMENTED_LIBS)
# NDK r10 requires -latomic almost always. # NDK r10 requires -latomic almost always.
append_list_if(ANDROID atomic ASAN_UNITTEST_INSTRUMENTED_LIBS) append_list_if(ANDROID atomic ASAN_UNITTEST_INSTRUMENTED_LIBS)
set(ASAN_UNITTEST_NOINST_LINKFLAGS ${ASAN_UNITTEST_COMMON_LINKFLAGS}) set(ASAN_UNITTEST_NOINST_LINKFLAGS ${ASAN_UNITTEST_COMMON_LINKFLAGS})
if(NOT APPLE)
append_list_if(COMPILER_RT_HAS_LIBM -lm ASAN_UNITTEST_NOINST_LINKFLAGS) append_list_if(COMPILER_RT_HAS_LIBM -lm ASAN_UNITTEST_NOINST_LINKFLAGS)
append_list_if(COMPILER_RT_HAS_LIBDL -ldl ASAN_UNITTEST_NOINST_LINKFLAGS) append_list_if(COMPILER_RT_HAS_LIBDL -ldl ASAN_UNITTEST_NOINST_LINKFLAGS)
append_list_if(COMPILER_RT_HAS_LIBRT -lrt ASAN_UNITTEST_NOINST_LINKFLAGS) append_list_if(COMPILER_RT_HAS_LIBRT -lrt ASAN_UNITTEST_NOINST_LINKFLAGS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread ASAN_UNITTEST_NOINST_LINKFLAGS) append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread ASAN_UNITTEST_NOINST_LINKFLAGS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread ASAN_DYNAMIC_UNITTEST_INSTRUMENTED_LINKFLAGS)
ASAN_DYNAMIC_UNITTEST_INSTRUMENTED_LINKFLAGS) endif()
# TODO(eugenis): move all -l flags above to _LIBS? # TODO(eugenis): move all -l flags above to _LIBS?
set(ASAN_UNITTEST_NOINST_LIBS) set(ASAN_UNITTEST_NOINST_LIBS)
append_list_if(COMPILER_RT_HAS_LIBLOG log ASAN_UNITTEST_NOINST_LIBS) append_list_if(COMPILER_RT_HAS_LIBLOG log ASAN_UNITTEST_NOINST_LIBS)
# NDK r10 requires -latomic almost always. # NDK r10 requires -latomic almost always.
append_list_if(ANDROID atomic ASAN_UNITTEST_NOINST_LIBS) append_list_if(ANDROID atomic ASAN_UNITTEST_NOINST_LIBS)
# Compile source for the given architecture, using compiler # Compile source for the given architecture, using compiler
▲ Show 20 Lines • Show All 222 Lines • Show Last 20 Lines