This is an archive of the discontinued LLVM Phabricator instance.

Differential D24657

[compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER is set
ClosedPublic

Authored by kubamracek on Sep 16 2016, 4:19 AM.

Details

Reviewers
compnerd
davidxl
vsk
Commits
rG55394c0775c8: [compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER is…
rCRT281815: [compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER is…
rL281815: [compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER…
Summary

Currently, when doing a ASanified build of LLVM (with Clang, compiler-rt and libcxx) via -DLLVM_USE_SANITIZER=Address and not using any other options, we already disable building of sanitizer runtimes (because they themselves can’t be sanitized) and also exclude the sanitizer tests. However, the same is not done for the profiling runtime, which will build fine, but then all the tests fail due to linking errors. Let’s disable the profiling runtime as well (when LLVM_USE_SANITIZER is set).

This is currently failing on the Darwin ASan+UBSan bot: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2425/console

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 71613.Sep 16 2016, 4:19 AM
kubamracek retitled this revision from to [compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER is set.
kubamracek updated this object.
kubamracek added reviewers: davidxl, vsk, compnerd.
kubamracek added subscribers: llvm-commits, zaks.anna.
Herald added subscribers: mgorny, beanz, dberris. · View Herald TranscriptSep 16 2016, 4:19 AM
davidxl accepted this revision.Sep 16 2016, 9:35 AM
davidxl edited edge metadata.

lgtm

This revision is now accepted and ready to land.Sep 16 2016, 9:35 AM
Closed by commit rL281815: [compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER… (authored by kuba.brecka). · Explain WhySep 16 2016, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
2 lines

Diff 71613

cmake/config-ix.cmake

Show First 20 Lines • Show All 456 Lines • ▼ Show 20 Lines
if (COMPILER_RT_HAS_SANITIZER_COMMON AND MSAN_SUPPORTED_ARCH AND if (COMPILER_RT_HAS_SANITIZER_COMMON AND MSAN_SUPPORTED_ARCH AND
OS_NAME MATCHES "Linux") OS_NAME MATCHES "Linux")
set(COMPILER_RT_HAS_MSAN TRUE) set(COMPILER_RT_HAS_MSAN TRUE)
else() else()
set(COMPILER_RT_HAS_MSAN FALSE) set(COMPILER_RT_HAS_MSAN FALSE)
endif() endif()
if (PROFILE_SUPPORTED_ARCH AND if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows") OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows")
set(COMPILER_RT_HAS_PROFILE TRUE) set(COMPILER_RT_HAS_PROFILE TRUE)
else() else()
set(COMPILER_RT_HAS_PROFILE FALSE) set(COMPILER_RT_HAS_PROFILE FALSE)
endif() endif()
if (COMPILER_RT_HAS_SANITIZER_COMMON AND TSAN_SUPPORTED_ARCH AND if (COMPILER_RT_HAS_SANITIZER_COMMON AND TSAN_SUPPORTED_ARCH AND
OS_NAME MATCHES "Darwin|Linux|FreeBSD") OS_NAME MATCHES "Darwin|Linux|FreeBSD")
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines