Page MenuHomePhabricator

Resurrect standalone build
AbandonedPublic

Authored by krytarowski on Jul 31 2016, 8:05 AM.

Details

Summary

LLVM doesn't install "CheckAtomic" cmake file, so add it locally.
Bump required CMake version to 3.4.3 (sync with the master CMakeLists.txt)

This fixes build on NetBSD.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski retitled this revision from to Resurrect standalone build.
krytarowski updated this object.
krytarowski added reviewers: labath, zturner.
krytarowski set the repository for this revision to rL LLVM.

I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as the 2 copy will diverge over time and cause extra maintenance cost. What do you think about trying to change LLVM to install this file instead of duplicating it into LLDB?

I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as the 2 copy will diverge over time and cause extra maintenance cost. What do you think about trying to change LLVM to install this file instead of duplicating it into LLDB?

I'm fine with it. How about LLVM devs?

labath requested changes to this revision.Aug 9 2016, 2:37 AM
labath edited edge metadata.

I agree with Tamas that this should somehow be handled in a different way. llvm already installs a bunch of cmake files. I think we should figure out a way to get the things we need installed alongside that, so we can just reuse them from there.

This revision now requires changes to proceed.Aug 9 2016, 2:37 AM
krytarowski abandoned this revision.Aug 25 2016, 10:43 AM

Will be addressed in LLVM/Clang.