Page MenuHomePhabricator

[LLDB] [cmake]: Add local module directory to search path for standalone build
AbandonedPublic

Authored by mgorny on Aug 25 2016, 10:27 AM.

Details

Reviewers
krytarowski
Summary

Add cmake/modules directory to cmake module search path as otherwise CMake fails to find CheckAtomic module when performing standalone build.

Note: I don't have commit access

Diff Detail

Event Timeline

mgorny updated this revision to Diff 69266.Aug 25 2016, 10:27 AM
mgorny retitled this revision from to cmake: Add local module directory to search path for standalone build.
mgorny updated this object.
mgorny added reviewers: krytarowski, Eugene.Zelenko.
mgorny added a subscriber: lldb-commits.

I think will be better to use LLVM_MAIN_SRC_DIR.

Eugene.Zelenko retitled this revision from cmake: Add local module directory to search path for standalone build to [LLDB] [cmake]: Add local module directory to search path for standalone build.Aug 25 2016, 10:33 AM
Eugene.Zelenko removed a reviewer: Eugene.Zelenko.
Eugene.Zelenko set the repository for this revision to rL LLVM.
krytarowski edited edge metadata.Aug 25 2016, 10:35 AM

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

mgorny added a comment.EditedAug 25 2016, 10:37 AM

I think will be better to use LLVM_MAIN_SRC_DIR.

That won't work since it would require source dir to be still available when building LLDB. The point of stand-alone build is to avoid that, and after applying this patch (and the regex fix), I'm able to achieve that. Using LLVM_MAIN_SRC_DIR would be a regression.

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

There was rejected a proposal to add CheckAtomic copy to LLDB. Not a proposal to install CheckAtomic for more customers of LLVM.

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

There was rejected a proposal to add CheckAtomic copy to LLDB. Not a proposal to install CheckAtomic for more customers of LLVM.

Ah, sorry, I didn't read that thoroughly. Should I create a patch for that, or will you handle it from here?

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

There was rejected a proposal to add CheckAtomic copy to LLDB. Not a proposal to install CheckAtomic for more customers of LLVM.

Ah, sorry, I didn't read that thoroughly. Should I create a patch for that, or will you handle it from here?

Please create it and I will test it on NetBSD.

Please add reviewers from D22999

mgorny abandoned this revision.Aug 25 2016, 1:18 PM